Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-07 Thread Bruno Haible
Billy O'Neal wrote: > I think ERROR_INVALID_DRIVE is dead. > ... > ERROR_BAD_NETPATH seems to happen when the path looks okay but DNS fails on > the input: > ... > I don’t think ERROR_DEV_NOT_EXIST can be triggered from a file path. Thanks a lot for these infos! I'm updating the error mapping in

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-04 Thread Eli Zaretskii
> From: "Billy O'Neal (VC LIBS)" > CC: "bug-gnulib@gnu.org" , "kbr...@cornell.edu" > , "emacs-de...@gnu.org" > Date: Wed, 3 May 2017 21:12:33 + > > I’m not an expert at all in this area. I did run a few queries against Win > sources though. Thanks for your input, much appreciated.

RE: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-03 Thread Billy O'Neal (VC LIBS)
;mailto:bug-gnulib@gnu.org>; kbr...@cornell.edu<mailto:kbr...@cornell.edu>; emacs-de...@gnu.org<mailto:emacs-de...@gnu.org>; Billy O'Neal (VC LIBS)<mailto:b...@microsoft.com> Subject: Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg On 05/02/2017 0

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-03 Thread Davis Herring
On 05/02/2017 03:55 PM, Bruno Haible wrote: FilenameGetLastError() errno in Emacs errno in Gnulib '\\server' ERROR_BAD_PATHNAME EINVAL ENOENT '\\server\nonexistentshare\'ERROR_BAD_NET_NAME EINVAL

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-03 Thread Eli Zaretskii
> Cc: kbr...@cornell.edu, emacs-de...@gnu.org, bug-gnulib@gnu.org > From: Paul Eggert > Date: Tue, 2 May 2017 15:35:03 -0700 > > > 1) The Emacs w32.c ports to Windows98 as well, whereas Gnulib currently > > assumes > > Windows XP at least (and will soon move to Windows 7, I guess - namely when >

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-03 Thread Eli Zaretskii
> From: Bruno Haible > Cc: kbr...@cornell.edu, emacs-de...@gnu.org, bug-gnulib@gnu.org > Date: Tue, 02 May 2017 23:55:50 +0200 > > The patch is fine with me: it has no drawbacks for other packages. Thanks. > However, it would be good to know what qualms you have with the msvc-nothrow > module.

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-02 Thread Paul Eggert
On 05/02/2017 02:55 PM, Bruno Haible wrote: it would be good to know what qualms you have with the msvc-nothrow module. Should Emacs be built with mingw, not MSVC? Is an EBADF situation never going to occur in Emacs anyway? Are the portability efforts for mingw and MSVC in Gnulib useless for Emac

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-02 Thread Bruno Haible
Paul Eggert wrote: > I'd like Bruno's opinion on the macro clash The common idiom is "#define WINDOWS_LEAN_AND_MEAN". This can be seen by comparing the number of hits of two web searches: https://www.google.de/search?q=%22define+windows_lean_and_mean%22 https://www.google.de/search?q=%22defin

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-02 Thread Eli Zaretskii
> Cc: kbr...@cornell.edu, emacs-de...@gnu.org, Bruno Haible , > Gnulib bugs > From: Paul Eggert > Date: Tue, 2 May 2017 00:52:03 -0700 > > > the utimens.c file you've brought from Gnulib has 2 problems: > > > > . it defines WIN32_LEAN_AND_MEAN unconditionally, which conflicts > > with our

Re: [Emacs-diffs] master 085c7f6 2/2: Test format-time-string with zone arg

2017-05-02 Thread Paul Eggert
Eli Zaretskii wrote: the utimens.c file you've brought from Gnulib has 2 problems: . it defines WIN32_LEAN_AND_MEAN unconditionally, which conflicts with our own definition in nt/inc/ms-w32.h, which is processed earlier; . it includes msvc-nothrow.h, which is absent in the reposito