Re: '_Noreturn' not at beginning of declaration

2012-08-23 Thread Paul Eggert
On 08/23/2012 02:44 PM, Paul Eggert wrote: > I worry that this may break on older GCCs that > don't let you put attributes at the start of a declaration. Ah, I now see that we have such declarations elsewhere, so if this were a problem we'd probably have run into it by now. So please don't bother

Re: '_Noreturn' not at beginning of declaration

2012-08-23 Thread Paul Eggert
On 08/23/2012 01:10 PM, Jim Meyering wrote: > -void _Noreturn xstrtol_fatal (enum strtol_error, > +_Noreturn void xstrtol_fatal (enum strtol_error, I worry that this may break on older GCCs that don't let you put attributes at the start of a declaration. _Noreturn expands to __attribute__ ((__nore

'_Noreturn' not at beginning of declaration

2012-08-23 Thread Jim Meyering
Building coreutils with the latest gcc from git/svn, I see this new failure: ./xstrtol.h:69:1: error: '_Noreturn' is not at beginning of declaration \ [-Werror=old-style-declaration] void _Noreturn xstrtol_fatal (enum strtol_error, ^ The following fixes it, but I suspect we'll want t