Hi Bruno,
thanks for your answer.
Just to make sure we are on the same page... When you say "that's
because you used -Werror. -Werror is not supported for Gnulib code.", do
you refer to compiling gnulib code or application code?
Because I was not talking about compiling the gnulib code itsel
Hey :)
Just updated to commit c7f29c827df9284ec56233c515286c4d57361e4c
and several CI jobs fail due to
../config.h:3932:25: error: ISO C11 does not support omitting the string
in '_Static_assert' [-Werror=c11-c2x-compat]
3932 | #define static_assert _Static_assert
|
Bruno, Dmitry, Collin, thank you so much !
The runtime improvement is amazing :)
Regards, Tim
On 4/26/24 12:14, Bruno Haible wrote:
If you are developer on a package that uses GNU gnulib as part of its build
system:
gnulib-tool has been known for being slow for many years. We have listened to
On 8/6/23 00:25, Carles Pina i Estany wrote:
When I say "long time" (and data transmission) in my case it's 9
minutes:
-
carles@pinux:[master]~/git/wget2$ time git submodule update --init
Cloning into '/home/carles/git/wget2/gnulib'...
Submodule path 'gnulib': checked out '2ae6faf9c78384dc6
On 8/3/23 20:56, Jeffrey Walton wrote:
My personal opinion is, there's nothing to fix.
That is exactly how macros are supposed to work. Anything undefined
evaluates to 0. It has been that way since the early days of C and
C++.
If there's a fix, then it is that you don't use -Wundef.
-Wundef h
Awesome, thank you Bruno !
Tested and your patch fixes the issue(s) for me.
Tim
On 8/3/23 18:11, Bruno Haible wrote:
On Donnerstag, 3. August 2023 17:52:29 CEST Tim Rühsen wrote:
Hi,
I just updated gnulib and recognized these warnings with every '#include
'. Before the update the
Hi,
I just updated gnulib and recognized these warnings with every '#include
'. Before the update there were no warnings.
../config.h:3317:34: warning: "__cplusplus" is not defined, evaluates to
0 [-Wundef]
3317 | #if !defined HAVE_C_ALIGNASOF && __cplusplus < 201103 &&
!defined alignof
On 06.08.22 19:40, Bruno Haible wrote:
Tim Rühsen wrote:
I read that even the MS C compilers / libraries support ISO C thread
nowadays,
I can't confirm this. If it were true, they would have documentation for it.
But a web search for "mtx_lock site:microsoft.com" returns no me
Hi Bruno,
On 05.08.22 20:27, Bruno Haible wrote:
Hi Tim,
I am at switching wget2 multithreading from C99+glthreads to C11
(threads.h).
I hope that you have considered the Gnulib documentation on this topic:
https://www.gnu.org/software/gnulib/manual/html_node/Choosing-a-multithreading-API.ht
Hi,
I am at switching wget2 multithreading from C99+glthreads to C11
(threads.h).
The tests work well on Linux (amd64) (Debian unstable/testing/stable,
Fedora 35, Arch, Alpine/muslc) with native builds (gcc or clang).
But they completely fail when cross-building with MinGW64 (on Debian
boo
Hi all,
On 14.06.22 00:39, Paul Eggert wrote:
In many Gnu projects, the 'configure' script is the biggest barrier to
building because it takes s long to run. Is there some way that we
could improve its performance without completely reengineering it, by
improving Bash so that it can parall
On 03.01.22 00:38, Bruno Haible wrote:
Paul Eggert wrote:
I'd like to try the approach a bit more (especially as this prompted me
to simplify it a bit :-). So I installed the first attached patch to
Gnulib, to work around the bug in BusyBox 'sed'.
Thanks. I confirm that it works on Alpine Linu
Hi,
I just updated gnulib to commit 2671376bc and have build issues on
Alpine (using docker; FROM alpine:latest).
Not saying this commit is faulty, I didn't update gnulib since April 2021.
Some generated header files look like
bash-5.1# head -3 lib/uniwidth.h
/* DO NOT EDIT! GENERATED AUTOMAT
On 23.01.21 07:09, Ryan Schmidt wrote:
On Jan 22, 2021, at 16:47, Tim Rühsen wrote:
On 21.01.21 01:34, Ryan Schmidt wrote:
Hi, I'm the maintainer of wget in MacPorts.
In the version of clang included with Xcode 12 and later, implicit declaration
of functions is an error.
During conf
On 02.08.20 15:41, Bruno Haible wrote:
> Tim Rühsen wrote:
>> The surrounding code in lib/signal.h is
>> #if 1
>> # if !0
>
> Huh? HAVE_POSIX_SIGNALBLOCKING evaluates to 0 ?!
>
> There was a change to m4/signalblocking.m4 recently, but for me it works.
> Can
Hey,
after updating gnulib, I see this on all CI pipelines (Debian, Fedora,
Alpine, Arch, ...):
In file included from /usr/include/x86_64-linux-gnu/sys/param.h:28,
from ./minmax.h:34,
from md2.c:30:
./signal.h:682:13: error: size of array 'verify_NSIG_constraint'
Hi Ed,
On 11.06.20 21:23, Ed Maste wrote:
> On Thu, 26 Mar 2020 at 05:51, Tim Rühsen wrote:
>>
>> We just need a mirror / fork on Github that we push to (sync) from time
>> to time. If someone cares for the initial Travis and/or Cirrus setup
>> with OSX / FreeBSD / Win
Hi Bruno,
On 23.05.20 22:47, Bruno Haible wrote:
> Tim Rühsen wrote:
>> - clang-10 with unset CFLAGS (*.clang-10)
>>
>> And the same set with -fsanitize... (*.sanitize).
>
> The other differences between the configure results without and with
> sanitizers
>
On 23.05.20 18:08, Paul Eggert wrote:
> On 5/23/20 8:56 AM, Pádraig Brady wrote:
>> Note -Wanalyzer... flags are ineffective without -fanalyzer.
>> Also -Wanalyzer-too-complex (now auto enabled by gnulib) is currently quite
>> problematic with -fanalyzer.
>
> Hmm, that's odd, since I recall gettin
Hi Bruno,
On 21.05.20 21:31, Bruno Haible wrote:
> Hi Tim,
>
> These comparisons are not so useful, because they not only come from different
> compilers (gcc vs. clang) but also from systems with different libcs: there
> are differences regarding libm, calloc, thrd_create, pthread_sigmask, and
Hi Bruno,
On 18.05.20 21:44, Bruno Haible wrote:
> Hi Tim,
>
>>> The way to determine the answer is:
>>> 1. Create a test dir of all gnulib modules.
>>> 2. Configure it with --config-cache.
>>> 3. Configure it with --config-cache and your sanitizer options.
>>> 4. Compare the generated config.cac
Hi Bruno,
On 20.05.20 00:46, Bruno Haible wrote:
> Hi Tim,
>
>>> rm -rf ../testdir-all; ./gnulib-tool --create-testdir
>>> --dir=../testdir-all --single-configure
>>
>> This results in:
>>
>> executing autopoint --force
>> autopoint: *** The AM_GNU_GETTEXT_VERSION declaration in your configure
On 18.05.20 21:44, Bruno Haible wrote:
> Hi Tim,
>
>>> The way to determine the answer is:
>>> 1. Create a test dir of all gnulib modules.
>>> 2. Configure it with --config-cache.
>>> 3. Configure it with --config-cache and your sanitizer options.
>>> 4. Compare the generated config.cache and co
On 19.05.20 21:10, Marc Nieper-Wißkirchen wrote:
> Am Di., 19. Mai 2020 um 19:23 Uhr schrieb Tim Rühsen :
>
>> "copyright" here means more "Nutzungsrecht" which you can transfer also
>> in Germany. You still stay the "Urheber".
>
> If transfe
On 19.05.20 18:11, Marc Nieper-Wißkirchen wrote:
> Am Di., 19. Mai 2020 um 17:51 Uhr schrieb Paul Eggert :
>>
>> On 5/19/20 8:35 AM, Marc Nieper-Wißkirchen wrote:
It is, however, locale-dependent, and there is no "c_dtoastr"
version as there is a "c_strtod". (Could we get such a wrapper?)
Hi Bruno,
On 18.05.20 13:50, Bruno Haible wrote:
> Hi Tim,
>
>> With leak sanitizer on, the test for getdelim fails due to a memory leak.
>
> Is this the only configure test that fails this way?
The only one that fails when running GNU Poke ./configure.
> I mean, it's 3 years since we last loo
,3 +1,7 @@
+2020-05-18 Tim Rühsen
+
+ * m4/getdelim.m4: Fix memleak.
+
2020-05-17 Bruno Haible
Clarify intended usage of the license file modules.
diff --git a/m4/getdelim.m4 b/m4/getdelim.m4
index 9f4c7f6e9..ac3917b11 100644
--- a/m4/getdelim.m4
+++ b/m4/getdelim.m4
@@ -1,4 +1,4 @@
-# getd
Hi,
thanks for your excellent write-up, Bruno.
Just want to add my thoughts :)
When talking about finding memory leaks, like in your wiki page, you
should also mention static analyzers and their ability to find memory
leaks (clang static analyzer, gcc-10 -fanalyzer, Coverity, cppcheck, ...).
Th
On 16.05.20 17:33, Jeffrey Walton wrote:
> On Sat, May 16, 2020 at 10:05 AM Bruno Haible wrote:
>> 3) The QA automation perspective
>>
>>
>> For QA automation, a multitude of program executions are done with a
>> memory leak checker enabled. Since it needs to be au
Hi Bruno,
On 11.05.20 18:37, Bruno Haible wrote:
> Hi Tim,
>
>> i would like to ask for your expert knowledge.
>>
>> How to prevent file descriptor leaks in a multi-threaded application
>> that fork+exec. Quick answer is surely "use O_CLOEXEC" to close those
>> file descriptors on exec.
>>
>> But
Hi,
i would like to ask for your expert knowledge.
How to prevent file descriptor leaks in a multi-threaded application
that fork+exec. Quick answer is surely "use O_CLOEXEC" to close those
file descriptors on exec.
But how does this work with fopen in a portable way ?
GNU libc has the 'e' flag
On 06.05.20 18:37, Bruno Haible wrote:
>> We could also check for an existing wget in bootstrap.conf and set
>> SKIP_PO=1 if not found. While it 'just works' it also disguises the real
>> problem and the user might get something unexpected
>> (non-internationalized wget).
>
> Alternatively, you co
On 05.05.20 03:14, Bruno Haible wrote:
> Paul Eggert wrote:
>>> We could switch the order such that Wget is the default and rsync is used
>>> as a
>>> fallback
>>
>> That sounds better than reverting, no? Perhaps you could propose a patch.
>
> No. From the point of security, "wget as default and
Hi Bruno,
thank you so much for reorganizing the code.
I updated both, Wget and Wget2, to the latest gnulib and it looks good
for me :-)
Regards, Tim
On 3/28/20 2:07 PM, Bruno Haible wrote:
Hi Tim,
dosname.h (included by dirname.h) and filename.h overlap in macro
definition. This currently
On 26.03.20 00:46, Bruno Haible wrote:
> Jeffrey Walton wrote:
>> CI tests should be catching these mistakes. (And problems like
>> _NoReturn on OS X).
>
> Yes, CI can catch some mistakes. Like, just last week, this one: [1].
>
> Tim and I maintain a continuous integration for gnulib at [2].
>
Is this EPERM intended ? If yes, there should be a comment.
lib/unlink.c (rpl_unlink):
/* Trailing NUL will overwrite the trailing slash. */
char *short_name = malloc (len);
if (!short_name)
{
errno = EPERM;
return -1;
Hi,
dosname.h (included by dirname.h) and filename.h overlap in macro
definition. This currently results in an error here:
In file included from wget.c:61:
In file included from ../lib/dirname.h:24:
../lib/dosname.h:36:10: error: 'FILE_SYSTEM_PREFIX_LEN' macro redefined
[-Werror,-Wmacro-redefined
There seems to be a prototype missing in uninorm/decompose-internal.h:
uninorm/decompose-internal.c:26:27: warning: no previous prototype for
'gl_uninorm_decompose_merge_sort_fromto' [-Wmissing-prototypes]
26 | #define merge_sort_fromto gl_uninorm_decompose_merge_sort_fromto
|
On 2/17/20 4:53 AM, Bruno Haible wrote:
> Paul Eggert wrote:
>> if GCC generated warnings for that sort of thing, the warnings would be false
>> alarms.
>
> Yes, and this in turn means that the ability to produce useful warnings via
> 'restrict' is limited. In this example:
> =
On 2/10/20 4:02 AM, Bruno Haible wrote:
> Tim Rühsen wrote:
>> gcc -Wall tells you so (gcc 8 and upwards):
>> $ gcc -Wall msg.c -o msg
>> msg.c: In function ‘main’:
>> msg.c:11:13: warning: passing argument 1 to restrict-qualified parameter
>> aliases with
On 09.02.20 15:44, Mats Erik Andersson wrote:
> Hello there!
>
> This note has its origin in a report received at bug-inetutils.
> The following test code for snprintf() is a simplyfied detection
> I have implemented as a warning-only test in Gnu Inetutils.
> My point is that Linux/glibc and kfree
Hi Bruno,
On 1/27/20 2:09 PM, Bruno Haible wrote:
>> Not sure if the compiler is correct here, but maybe worth a look:
>>
>> hash.c:549:11: error: implicit conversion from 'unsigned long' to
>> 'float' changes value from 18446744073709551615 to 18446744073709551616
>> [-Werror,-Wimplicit-int-float
On 1/20/20 7:04 PM, Bruno Haible wrote:
> CCLD wget2
>>>
>>> Please make it a habit to use "make V=1" when submitting a report.
>>> I don't want to see "CCLD wget2"; I want to see the actual link
>>> command line.
>>
>> I don't have direct console/shell access - the issue is/was on a Free
Not sure if the compiler is correct here, but maybe worth a look:
hash.c:549:11: error: implicit conversion from 'unsigned long' to
'float' changes value from 18446744073709551615 to 18446744073709551616
[-Werror,-Wimplicit-int-float-conversion]
if (SIZE_MAX <= new_candidate)
^
Hi Bruno,
thanks for your work !
I can confirm that your patch fixes the issue here.
On 1/20/20 4:01 AM, Bruno Haible wrote:
>>> FreeBSD 11.2-RELEASE-p4 (with clang 6.0):
>>>
>>> CCLD wget2
>
> Please make it a habit to use "make V=1" when submitting a report.
> I don't want to see "CCLD
after dirname is freed, the code still accesses end_name.
>
> Can you please test this patch?
>
> Thank you very much for this report! I expect that the fix will also need
> to go into glibc.
>
>
> 2020-01-17 Bruno Haible
>
> glob: Fix use-after-free bug.
cc
==1671628==ABORTING
Maybe someone who knows glob better than me could have a look. It seems
to be a regression.
Regards, Tim
/*
* Created 17.01.2019 by Tim Rühsen
*
* Call glob() using data from fuzzer crash file
*
* Build and execute with instrumented gnulib (amend -I paths as needed)
Hi Bruno,
On 1/13/20 12:01 PM, Bruno Haible wrote:
> Hi Tim,
>
>> you could look at libidn2 as an example how to use system libunistring
>> if there (or if new enough) and fallback to gnulib unistring.
>> (BTW, libunistring is made of the gnulib unistring modules)
>>
>> It creates a separate dir
Hi José,
you could look at libidn2 as an example how to use system libunistring
if there (or if new enough) and fallback to gnulib unistring.
(BTW, libunistring is made of the gnulib unistring modules)
It creates a separate dir / library for gnulib unistring functions,
*BUT* only uses it when a s
FYI, the issue below also happens with --disable-threads.
Using --enable-threads=isoc fixes it (found in an earlier post on this ML).
Regards, Tim
On 1/7/20 4:03 PM, Tim Rühsen wrote:
> Hi,
>
> with the latest gnulib (a7903da07d3d18c23314aa0815adbb4058fd7cec) on
> FreeBSD 11.2-RELE
Hi Bruno,
On 07.01.20 19:00, Bruno Haible wrote:
>> with the latest gnulib (a7903da07d3d18c23314aa0815adbb4058fd7cec) on
>> Debian Stretch:
>>
>> In file included from /usr/include/string.h:630:0,
>> from ./string.h:41,
>> from strndup.c:21:
>> strndup.c:26:1: err
On 1/7/20 3:24 PM, Tim Rühsen wrote:
> Hi,
>
> with the latest gnulib (a7903da07d3d18c23314aa0815adbb4058fd7cec) on
> Debian Stretch:
>
> In file included from /usr/include/string.h:630:0,
> from ./string.h:41,
> from strndup.c:21:
Hi,
with the latest gnulib (a7903da07d3d18c23314aa0815adbb4058fd7cec) on
FreeBSD 11.2-RELEASE-p4 (with clang 6.0):
CCLD wget2
/usr/bin/ld: undefined reference to symbol
`pthread_mutexattr_gettype@@FBSD_1.0' (try adding -lthr)
//lib/libthr.so.3: could not read symbols: Bad value
clang: error
Hi,
with the latest gnulib (a7903da07d3d18c23314aa0815adbb4058fd7cec) on
Debian Stretch:
In file included from /usr/include/string.h:630:0,
from ./string.h:41,
from strndup.c:21:
strndup.c:26:1: error: expected identifier or '(' before '__extension__'
strndup (c
On 1/6/20 5:08 PM, Tim Rühsen wrote:
>> * What about reusing the complete vasnprintf.c for (B), rather than
>> adding another, limited printf-like implementation?
>
> Yes, would be nice. At least for appending we need an extra
> malloc/malloc/memcpy/free.
>
Hi Bruno,
On 1/6/20 1:46 PM, Bruno Haible wrote:
> - providing primitives for string allocation reduces the amount of
> buffer
> overflow bugs that otherwise occur in this area. [1]
> [1] https://lists.gnu.org/archive/html/bug-gnulib/2019-09/msg00031.html
>>> ...
>> We creat
On 12/31/19 10:53 AM, Bruno Haible wrote:
> Hi Tim,
>
>>> - providing primitives for string allocation reduces the amount of buffer
>>> overflow bugs that otherwise occur in this area. [1]
>>> [1] https://lists.gnu.org/archive/html/bug-gnulib/2019-09/msg00031.html
>
>> here is a string co
On 27.12.19 11:51, Bruno Haible wrote:
> Aga wrote:
>> I do not know if
>> you can (or if it is possible, how it can be done), extract with a way a
>> specific
>> a functionality from gnulib, with the absolute necessary code and only that.
>
> gnulib-tool does this. With its --avoid option, the d
On 29.12.19 19:49, Paul Eggert wrote:
> On 12/29/19 4:07 AM, Tim Rühsen wrote:
>> Introducing a stronger 'const' could be helpful in some situations
>
> D has 'immutable' for that. It doesn't work as well as one might think.
It all depends on the implem
On 29.12.19 10:45, Bruno Haible wrote:
> Tim Rühsen wrote:
>> the use cases are mostly in the testing area (especially fuzzing).
>
> Indeed. During fuzzing, you want to check against any kind of buggy/undefined
> behaviour, and writing into arbitrary memory is one of these kinds
Hi Bruno,
On 28.12.19 12:17, Bruno Haible wrote:
> Would you find it useful to have an immutable string type in gnulib?
The idea is good in fact had similar thoughts/needs a while ago. IMO,
the use cases are mostly in the testing area (especially fuzzing).
As a more general approach, a function
Hi Bruno, hi gnulib developers,
it's a joy to follow the posts on this list - you (all) surprise,
impress and inspire me with your code but even more with your detailed
explanations / documentations.
Thank you so much for your ongoing work !!!
[E.g. this post made me check my code for mbtowc/mbr
On 12/5/19 4:12 PM, Wes Hurd wrote:
> Hi,
>
> It seems GNUlib quote encoding goes to Unicode smart quotes, which causes
> command-line program output to be in smart quotes.
> Smart quotes are dangerous for programmers and technical users, and should
> be avoided in program output.
>
> Originally
Hi Dago,
On 30.11.19 18:33, Dagobert Michelsen wrote:
> Am 30.11.2019 um 16:28 schrieb Tim Rühsen :
>> On 30.11.19 15:15, Bruno Haible wrote:
>>>> There is one LF at the end of the diff file (taken from the email I
>>>> received via mailing list, also cros
Hi Bruno,
On 30.11.19 15:15, Bruno Haible wrote:
>> There is one LF at the end of the diff file (taken from the email I
>> received via mailing list, also cross-checked with bug-gnulib archive).
>
> Indeed, the one in bug-gnulib archive and even the one I get by using
> the web access to my IMAP
Hi Bruno,
On 30.11.19 13:06, Bruno Haible wrote:
>> Please review the patch - surely some of my python constructs could be
>> done more elegant.
>
> Review:
> - GLModuleSystem.getLink: Looks good. This method corresponds to
> func_get_link_directive and therefore should not do any joining or so
On 11/28/19 11:11 PM, Bruno Haible wrote:
> Hi Dagobert,
>
> lib/gnulib.mk there is a suspicious addition to libgnu_la_LDFLAGS without
> space:
>>
>> libgnu_la_LDFLAGS += $(GETADDRINFO_LIB)$(LTLIBINTL)
>> ...
>> libgnu_la_LDFLAGS += $(LTLIBICONV)
>> libgnu_la_LDFLAGS += $(LTLIBINTL)
>> libgnu_la
On 11/28/19 11:11 PM, Bruno Haible wrote:
> Hi Dagobert,
>
> lib/gnulib.mk there is a suspicious addition to libgnu_la_LDFLAGS without
> space:
>>
>> libgnu_la_LDFLAGS += $(GETADDRINFO_LIB)$(LTLIBINTL)
>> ...
>> libgnu_la_LDFLAGS += $(LTLIBICONV)
>> libgnu_la_LDFLAGS += $(LTLIBINTL)
>> libgnu_la
There was a stale 'doc/texinfo.tex' here (no idea where it's from).
After removing it, everything works out smooth. Sorry for the wind.
Regards, Tim
On 10/18/19 10:02 AM, Tim Rühsen wrote:
> @Paul
>
> The error says
> "/home/oms/src/libmicrohttpd/doc/gpl-2.0.tex
@enumerate a
173:@end enumerate
314:@end enumerate
As you can see L67-L314 is an enumerate, where L286 (@heading) is enclosed.
So it looks like a problem in gpl-2.0.texi (or in the texi2dvi command
chain). Any ideas ?
Regards, Tim
On 10/18/19 9:54 AM, Tim Rühsen wrote:
> Hi Christian,
&g
Hi Christian,
I can even reproduce on Debian unstable:
./bootstrap
./configure
make
cd doc
make dvi
Regards, Tim
On 10/17/19 3:11 PM, Christian Grothoff wrote:
> I downloaded an Ubuntu 18.04.3 LTS VM image, installed the required
> packages (including texlive 2017 and texinfo 6.5) and it _still
Hi Bernhard,
it's already in gnulib since yesterday. I didn't expect you to come up
with a patch, else I would have informed you on the bug tracker.
Please excuse my lack of communication here.
Regards, Tim
On 10/7/19 11:13 AM, Bernhard M. Wiedemann wrote:
> e.g. when running in a build environ
From 3bde5ad266986687ad38a8742244099970ed7cc7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20R=C3=BChsen?=
Date: Sun, 6 Oct 2019 16:52:23 +0200
Subject: [PATCH] users.txt: Fix URL for libidn2
---
users.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/users.txt b/users.txt
Thank you, Paul !
On 06.10.19 06:38, Paul Eggert wrote:
> On 10/4/19 8:34 AM, Tim Rühsen wrote:
>> Instead of -q we could use -nv to avoid disguising the real error.
>> But there will be some diagnostic noice...
>
> At this point the bootstrap script is so noisy that a
Hi,
we just had an issue with the bootstrap script because wget -q
suppresses error output.
E.g. instead of
"
ERROR: cannot verify translationproject.org's certificate, issued by
'CN=Let\'s Encrypt Authority X3,O=Let\'s Encrypt,C=US':
Unable to locally verify the issuer's authority.
"
there is
Hi Bruno,
On 28.08.19 17:28, Bruno Haible wrote:
>> The option -Wused-but-marked-unused is indirectly activated by
>> -Weverything
>
> -Weverything is not something we can support in gnulib. For the
> meaning of this option, see
> https://quuxplusone.github.io/blog/2018/12/06/dont-use-weverything
Hi Bruno,
On 8/28/19 4:09 PM, Bruno Haible wrote:
> Hi Tim,
>
>> Compiling on FreeBSD 12 gives a warning per use of c_ macros, for example
>>
>> http_parse.c:187:10: warning: 'c_isblank' was marked unused but was used
>> [-Wused-but-marked-unused]
>> while (c_isblank(*s)) s++;
>>
Compiling on FreeBSD 12 gives a warning per use of c_ macros, for example
http_parse.c:187:10: warning: 'c_isblank' was marked unused but was used
[-Wused-but-marked-unused]
while (c_isblank(*s)) s++;
This is true also for c_isdigit, c_isspace, etc.
Is that expected behavior and
Hi Bruno,
sorry for the delay. This somewhat dropped off the tip of my list, but
lurks at the edge of my consciousness, coming up from time to time.
On 12/5/18 12:43 AM, Bruno Haible wrote:
> Hi Tim,
>
>> Currently we have
>> - positive integer (N): resize by old value * N
>> - negative integer
Please consider applying this
diff --git a/lib/regex_internal.c b/lib/regex_internal.c
index 9004ce809..15f38a755 100644
--- a/lib/regex_internal.c
+++ b/lib/regex_internal.c
@@ -1311,7 +1311,6 @@ re_node_set_insert (re_node_set *set, Idx elem)
first element separately to skip a check in the
On 7/10/19 9:32 PM, Akim Demaille wrote:
> I'm using 4.2.1, and it does what I meant: -p prints the rules,
> and -q (which is --question, not --quiet) avoids that we
> fired a rule (i.e., "make -q" does not run "make all").
>
> So I'm just clueless here. I don't know what to do to address
> your
Hi Akim,
On 7/10/19 9:32 PM, Akim Demaille wrote:
> Hi Tim,
>
> Sorry I dropped the ball...
NP, I dropped it as well ;-)
>> Reproducible everywhere (needs gawk being installed, else the
>> sc_prohibit_gnu_make_extensions is a no-op).
>
> Which is what I meant. So are you saying it work as (I)
On 7/10/19 11:38 AM, Tim Rühsen wrote:
>
>
> On 7/10/19 11:07 AM, Tim Rühsen wrote:
>> On 6/25/19 3:24 PM, Tim Rühsen wrote:
>>> Hi Akim,
>>>
>>> the command expands to
>>>
>>> if gawk --version | grep GNU >/dev/null 2>&1; t
On 7/10/19 11:07 AM, Tim Rühsen wrote:
> On 6/25/19 3:24 PM, Tim Rühsen wrote:
>> Hi Akim,
>>
>> the command expands to
>>
>> if gawk --version | grep GNU >/dev/null 2>&1; then \
>> (cd . && autocon
On 6/25/19 3:24 PM, Tim Rühsen wrote:
> Hi Akim,
>
> the command expands to
>
> if gawk --version | grep GNU >/dev/null 2>&1; then \
> (cd . && autoconf --trace AC_CONFIG_FILES:'$1') | \
> tr ' ' '\n' |
Here is a Dockerfile for reproducing the issue on Fedora 30.
docker build ...
docker run ...
git clone https://gitlab.com/gnuwget/wget2.git
cd wget2
git checkout tmp-stuff
./bootstrap
./configure
make syntax-check
Regards, Tim
FROM fedora:latest
LABEL maintainer "Tim Rühsen "
WO
Hi Bruno,
sorry, it doesn't.
On 6/25/19 4:37 PM, Bruno Haible wrote:
> Hi Tim,
>
>> the command expands to
>>
>> if gawk --version | grep GNU >/dev/null 2>&1; then \
>> (cd . && autoconf --trace AC_CONFIG_FILES:'$1') | \
>> tr ' ' '\n' |
Hi Akim,
the command expands to
if gawk --version | grep GNU >/dev/null 2>&1; then \
(cd . && autoconf --trace AC_CONFIG_FILES:'$1') | \
tr ' ' '\n' | \
/usr/bin/sed -ne '/Makefile/{s/\.in$//;p;}' | \
Hi Akim,
On 6/24/19 5:56 PM, Akim Demaille wrote:
> Hi Tim,
>
>> Le 24 juin 2019 à 11:42, Tim Rühsen a écrit :
>>
>> Hi Akim,
>>
>> Your proposal works here on Debian after I switched to mawk via
>> 'update-alternatives --config awk', select
Hi Akim,
On 6/22/19 5:53 PM, Akim Demaille wrote:
> Hi Tim,
>
>> Le 17 juin 2019 à 12:04, Tim Rühsen a écrit :
>>
>> Hi Akim,
>>
>> On 6/17/19 11:59 AM, Akim Demaille wrote:
>>> Hi Tim,
>>>
>>>> Le 17 juin 2019 à 11:57, Tim Rü
On 6/23/19 6:32 PM, Jim Meyering wrote:
> On Wed, Jun 19, 2019 at 3:12 AM Bruno Haible wrote:
> ...
>> Done like this:
>>
>> 2019-06-19 Bruno Haible
>>
>> Reorder pieces of header in perl scripts.
>> The desired order is
>> - Prologue part 1 (2 lines with #!)
>>
Hi Akim,
On 6/17/19 11:59 AM, Akim Demaille wrote:
> Hi Tim,
>
>> Le 17 juin 2019 à 11:57, Tim Rühsen a écrit :
>>
>> Hi Akim,
>>
>> The patch uses awk -e which is understood only by GNU awk. This breaks
>> all Debian CI tests here since Debian instal
Hi Akim,
On 5/19/19 7:42 AM, Akim Demaille wrote:
>
>> Le 18 mai 2019 à 20:21, Paul Eggert a écrit :
>>
>> Akim Demaille wrote:
>>
>>> How about this?
>>
>> Looks OK to me; thanks.
>
> Installed. Thanks!
>
The patch uses awk -e which is understood only by GNU awk. This breaks
all Debian CI t
Hi,
at GNU Wget we are currently a bit puzzled about gnulib-tool's pro-tip
#if HAVE_SYS_SOCKET_H
# include
#elif HAVE_WS2TCPIP_H
# include
#endif
and 'make syntax-check' complaining about using HAVE_SYS_SOCKET_H:
maint.mk: do not test the above HAVE__H symbol(s);
with the corresponding gnul
On 14.06.19 19:50, Paul Eggert wrote:
> On 6/14/19 10:04 AM, Tim Rühsen wrote:
>> Adding a shebang to build-aux/useless-if-before-free fixes the issue.
>
> What shebang should that be, exactly? The current style is used in
> several scripts (build-aux/announce-gen, build-aux/g
Hi,
on Alpine, with pretty much latest gnulib commit
5905d8ca9945f0d60ff40eb6cfa42afc0199ab8f, 'make syntax-check' throws out
xargs: ./build-aux/useless-if-before-free: Exec format error
Adding a shebang to build-aux/useless-if-before-free fixes the issue.
Regards, Tim
signature.asc
Descript
Hi Bruno,
On 05.05.19 02:24, Bruno Haible wrote:
> Tim Rühsen wrote:
>> Nothing documented found. After reading some code, it seems po/Makevars
>> is left alone when removing AM_GNU_GETTEXT_VERSION([0.17]) from
>> configure.ac.
>
> The Makefile.in.in from version 0.17
On 04.05.19 18:13, Bruno Haible wrote:
> Tim Rühsen wrote:
>> Both, 'po/Makevars' and 'po/Makevars.template' are overwritten by
>> './bootstrap' (the gnulib bootstrap) (adding to git doesn't matter).
>
> po/Makevars is meant to co
On 04.05.19 16:26, Tim Rühsen wrote:
> On 04.05.19 16:25, Bruno Haible wrote:
>> Tim Rühsen wrote:
>>> $ diff wget.po ../../../po/wget.pot
>>> 3c3
>>> < # This file is distributed under the same license as the wget package.
>>> ---
>>>&
On 04.05.19 16:25, Bruno Haible wrote:
> Tim Rühsen wrote:
>> $ diff wget.po ../../../po/wget.pot
>> 3c3
>> < # This file is distributed under the same license as the wget package.
>> ---
>>> # This file is distributed under the same license as the GNU wget p
1 - 100 of 262 matches
Mail list logo
