Re: [PATCH] deps: require Automake >= 1.9.6 in generated Makefile fragments

2013-05-10 Thread Stefano Lattarini
On 05/10/2013 11:22 PM, Paul Eggert wrote: > Thanks for catching that; > Thanks for another super-quick review! > please install. > Done. Best regards, Stefano

[PATCH] deps: require Automake >= 1.9.6 in generated Makefile fragments

2013-05-10 Thread Stefano Lattarini
dex 2e8f618..13dafaa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,21 @@ +2012-05-10 Stefano Lattarini + + deps: require Automake >= 1.9.6 in generated Makefile fragments + + That is the same minimal version required in the DEPENDENCIES file. + Moreover, the old code gener

Re: Regression in development version of bash w.r.t. associative hashes

2013-05-06 Thread Stefano Lattarini
On 05/06/2013 10:00 PM, Chet Ramey wrote: > On 5/3/13 5:48 AM, Stefano Lattarini wrote: >> [+cc bug-gnulib, see below for a reason] >> >> Minimal reproducer of the regression: >> >> $ cat foo.bash >> echo "$BASH_VERSION" >> declare -A

Re: Gnulib homepage and CVS mirror

2013-05-04 Thread Stefano Lattarini
On 05/04/2013 08:32 PM, Paul Eggert wrote: > That looks OK; please apply. And thanks. > Pushed, thank you. Best regards, Stefano

Re: Gnulib homepage and CVS mirror

2013-05-04 Thread Stefano Lattarini
On 05/04/2013 10:18 AM, Stefano Lattarini wrote: > Hi Dmitry. > > On 05/04/2013 01:19 AM, ghostma...@gmail.com wrote: >> Hello everyone! >> >> It really meets my needs, since I haven't added full support for CVS yet. :-) >> If it doesn't have any meani

Re: Gnulib homepage and CVS mirror

2013-05-04 Thread Stefano Lattarini
Hi Dmitry. On 05/04/2013 01:19 AM, ghostma...@gmail.com wrote: > Hello everyone! > > It really meets my needs, since I haven't added full support for CVS yet. :-) > If it doesn't have any meaning, I'll remove any "tails" to SVS and will keep > only git support in pygnulib. > I'd say go ahead :-)

Gnulib homepage and CVS mirror

2013-05-03 Thread Stefano Lattarini
On the Gnulib homepage , I read You can use CVS in a read-only way, to retrieve the latest version from the Git repository, using a command like this: cvs -d :pserver:anonym...@pserver.git.sv.gnu.org:/gnulib.git co \ -d gnulib HEAD But then, if

Regression in development version of bash w.r.t. associative hashes

2013-05-03 Thread Stefano Lattarini
[+cc bug-gnulib, see below for a reason] Minimal reproducer of the regression: $ cat foo.bash echo "$BASH_VERSION" declare -A hash echo ${hash[a/b]} echo $? $ /bin/bash foo.bash 4.2.45(1)-release 0 $ ~/bleeding/bin/bash foo.bash 4.3.0(1)-alpha foo.bash: line 3: a/b: divis

Re: bug#14253: Testsuite failure in gnulib-tests: test programs cannot be built

2013-04-30 Thread Stefano Lattarini
Hi Paul, Pádraig. On 04/25/2013 10:28 AM, Stefano Lattarini wrote: > On 04/25/2013 07:29 AM, Paul Eggert wrote: >> On 04/24/2013 02:08 AM, Pádraig Brady wrote: >>> Bernhard noticed this also: >>> http://lists.gnu.org/archive/html/coreutils/2013-03/msg00065.html >

Re: bug#14253: Testsuite failure in gnulib-tests: test programs cannot be built

2013-04-25 Thread Stefano Lattarini
On 04/25/2013 07:29 AM, Paul Eggert wrote: > On 04/24/2013 02:08 AM, Pádraig Brady wrote: >> Bernhard noticed this also: >> http://lists.gnu.org/archive/html/coreutils/2013-03/msg00065.html > > Thanks, here's a proposed patch. I'll CC: this to Bruno since he's > gettext's maintainer. > > From 31

Re: maint.mk sc_copyright_check won't handle multiple lines

2013-03-08 Thread Stefano Lattarini
On 03/08/2013 04:04 PM, Martin von Gagern wrote: > Hi! > Hi Martin. > The sc_copyright_check in maint.mk won't handle a copyright notice > spanning multiple lines. For wdiff I'll likely disable that check for > this reason, since keeping 9 years in a single copyright line for the > texi file doesn

Re: [PATCH] bootstrap: remove the need for a sorted .gitignore

2013-01-26 Thread Stefano Lattarini
Throwing in my two cents here ... On 01/26/2013 06:27 AM, Gary V. Vaughan wrote: > Hi Bernhard, Padraig, > > Sorry for the late review, I didn't notice this until after the push > notification. Comments interspersed below... > > On 21 Jan 2013, at 02:20, Bernhard Voelker wrote: >> During boots

Re: [off-list] CVS pains (was: Re: gnu-web-doc-update: fails to add new directories)

2012-12-14 Thread Stefano Lattarini
On 12/13/2012 11:53 PM, Karl Berry wrote: > > 3) Everyone agrees it would be nice to support different VCs for web > pages. Nobody needs "convincing". > This is good to know. > Maybe it will happen some day. > I hope so. It's not a big deal actually (since as Jim noted, most of the process is hi

Re: CVS pains

2012-12-13 Thread Stefano Lattarini
On 12/13/2012 06:09 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Ah, we all git lovers still forced to deal with that living fossil >> of CVS! >> Oops, I meant this as "private venting" only, but I sent it to the whole list by mistake. Sorry for the extra noise. Stefano

[off-list] CVS pains (was: Re: gnu-web-doc-update: fails to add new directories)

2012-12-13 Thread Stefano Lattarini
Ah, we all git lovers still forced to deal with that living fossil of CVS! Wouldn't it be great if someone could convince the Savannah admin to switch the web pages repository to a modern, distributed VCS? (Me ducks and run now ;-). Regards, Stefano

Re: [PATCH] maint.mk: avoid extra forks

2012-12-08 Thread Stefano Lattarini
Hi Paul, thanks for the super-quick feedback! On 12/08/2012 06:21 PM, Paul Eggert wrote: > On 12/08/2012 09:08 AM, Stefano Lattarini wrote: >> * top/maint.mk (_cfg_mk): The GNU make manual documents that >> "$(wildcard FILE)" expands to empty if FILE doesn't ex

[PATCH] maint.mk: avoid extra forks

2012-12-08 Thread Stefano Lattarini
int.mk | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b4b242e..413e435 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-12-08 Stefano Lattarini + + maint.mk: avoid extra forks + * top/maint.mk (_cfg_mk): The GNU make manual docume

Re: [bug-gettext] [PATCH] m4: use AC_PROG_MKDIR_P, not the deprecated AM_PROG_MKDIR_P

2012-12-06 Thread Stefano Lattarini
On 12/05/2012 04:22 AM, Daiki Ueno wrote: > Hi Stefano, > Hi, sorry for the delay. > Stefano Lattarini writes: > >> AM_PROG_MKDIR_P has been deprecated in Automake 1.12.1, and will >> be removed in Automake 1.13. > [...] >> gettext-runtime/m4/intl.m4 | 6 ++

Re: Libtool library used but 'LIBTOOL' is undefined

2012-11-08 Thread Stefano Lattarini
On 11/08/2012 07:56 PM, Bruce Korb wrote: > automake is trying to tell me something, but I cannot make out exactly what. > The literal meaning of the messages is pretty clear, but what they caution > about are things that appear to me to be correct. > >> autoreconf --force --install --verbose --sy

Re: bug#12820: gnulib testsuite failure in latest master

2012-11-08 Thread Stefano Lattarini
On 11/08/2012 08:44 AM, Paul Eggert wrote: > Ouch, I read your strace output incorrectly: it was napping > for 20 ms, not 2 s. Still, there should be no need to nap > for that long; 1 ms should suffice on your platform. > > I installed the following patch to cause the test > to take shorter naps.

Re: gnulib doesn't add lib/spawn.h to .gitignore?

2012-10-02 Thread Stefano Lattarini
On 10/01/2012 12:00 AM, Bruno Haible wrote: > [Dropping bug-coreutils from CC] > > Hi Stefano, > Hi Bruno, sorry for the late answer. >> OK, this is a minor annoyance rather than a real bug, but I guess >> reporting it won't hurt. >> >> In GNU coreutils, the gnulib-provided 'bootstrap' script fai

Re: maint.mk: improve the release procedure

2012-09-25 Thread Stefano Lattarini
Hi Akim, Jim. On 09/25/2012 12:32 PM, Akim Demaille wrote: > > Le 25 sept. 2012 à 12:11, Akim Demaille a écrit : > >>> Pushed. >> >> Well, there are several issues with the patch. I'm on it right now. >> Do not upgrade gnulib right now. > > Here are the proposed fixes. I had only tested these

Re: [PATCH] fts: when there is no risk of overlap, use memcpy, not memmove

2012-09-04 Thread Stefano Lattarini
On 09/04/2012 12:21 PM, Jim Meyering wrote: > While investigating the rm-vs-slash-decorated-symlink-to-dir problem, > I noticed this: > > From 9322cc5db3a6efe4c19f274512a28767872384e4 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Tue, 4 Sep 2012 11:31:09 +0200 > Subject: [PATCH] fts: when

[MICROBUG]: gnulib doesn't add lib/spawn.h to .gitignore?

2012-08-29 Thread Stefano Lattarini
Severity: minor OK, this is a minor annoyance rather than a real bug, but I guess reporting it won't hurt. In GNU coreutils, the gnulib-provided 'bootstrap' script fails to add the generated file 'lib/spawn.h' to the .gitignore in 'lib/': $ ./bootstrap && ./configure && make ... [all is OK]

Re: [PATCH] gnumakefile: better interaction with Automake-NG

2012-08-04 Thread Stefano Lattarini
Hi Jim. On 08/04/2012 06:30 PM, Jim Meyering wrote: > > ACK. Thanks! > Thanks for the quick reply. Patch pushed. Regards, Stefano

Re: [PATCH] gnumakefile: better interaction with Automake-NG

2012-08-04 Thread Stefano Lattarini
On 08/03/2012 10:14 AM, Stefano Lattarini wrote: > On 08/02/2012 07:49 PM, Eric Blake wrote: >> On 08/02/2012 11:00 AM, Eric Blake wrote: >>> On 08/02/2012 10:53 AM, Stefano Lattarini wrote: >>>> * modules/gnumakefile [Makefile.am]: The makefiles generated by >

Re: maint.mk: improve the release procedure

2012-08-03 Thread Stefano Lattarini
Hi Akim. On 08/03/2012 10:14 AM, Akim Demaille wrote: > > --- a/top/maint.mk > +++ b/top/maint.mk > @@ -1134,7 +1134,7 @@ sc_makefile_path_separator_check: > # i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release) > # and is read-only. > writable-files: > - if test -d $(

Re: [PATCH] gnumakefile: better interaction with Automake-NG

2012-08-03 Thread Stefano Lattarini
On 08/02/2012 07:49 PM, Eric Blake wrote: > On 08/02/2012 11:00 AM, Eric Blake wrote: >> On 08/02/2012 10:53 AM, Stefano Lattarini wrote: >>> * modules/gnumakefile [Makefile.am]: The makefiles generated by >>> Automake-NG always contain a definition of VPATH, even i

[PATCH] gnumakefile: better interaction with Automake-NG

2012-08-02 Thread Stefano Lattarini
0644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2012-08-02 Stefano Lattarini + + gnumakefile: better interaction with Automake-NG + * modules/gnumakefile [Makefile.am]: The makefiles generated by + Automake-NG always contain a definition of VPATH, even in non-VPATH +

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Stefano Lattarini
On 07/20/2012 05:19 PM, Joachim Schmitz wrote: > I've been told that git needs python, and in a newer version, for > getting it installed. > That is false; quoting the comments in the git Makefile: Define NO_PYTHON if you do not want Python scripts or libraries at all. > Haven't verified that y

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Stefano Lattarini
On 07/20/2012 04:42 PM, Joachim Schmitz wrote: > > First I'd need to get git ported to NonStop, this is on my todolist already. > Appare4ny git install needs Python > AFAIK, only some non-fundamental programs and features in the Git toolbox need python. Most of git is perfectly usable without pyt

Re: [PATCH] maint.mk: minor simplication.

2012-07-17 Thread Stefano Lattarini
On 07/17/2012 10:35 AM, Akim Demaille wrote: > Subject: [PATCH] maint.mk: minor simplication. > s/simplication/simplification/ in the summary line. For the rest, I like your patch (albeit it's not me who can ACK it). Regards, Stefano

Re: add --match argument to git-version-gen

2012-07-07 Thread Stefano Lattarini
On 07/07/2012 10:42 PM, Jim Meyering wrote: > Andy Wingo wrote: > ... >> +function massage_git_version() { >> +local v=$1 > > Using the "function" and "local" keywords would make this script > fail for some older shells. > With the "function" keyword, even recent ones: $ dpkg -l dash ...

Re: add --match argument to git-version-gen

2012-07-06 Thread Stefano Lattarini
On 07/06/2012 03:53 PM, Andy Wingo wrote: > > @@ -121,6 +126,9 @@ if test -z "$tarball_version_file"; then > exit 1 > fi > > +echo $match > Huh? Forgotten debugging code perhaps? > +match="${match:-$prefix\*}" > +echo $match > Likewise. > tag_sed_script="${tag_sed_script:-s/x/x/}" > > nl=

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Stefano Lattarini
On 07/06/2012 03:28 PM, Akim Demaille wrote: > > Le 6 juil. 2012 à 15:21, Stefano Lattarini a écrit : > >> Why not shave off the extra forks here? >> >>printf "$me: $warnf_format_" "$@" >&2 >> >> This shouldn't cause pro

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Stefano Lattarini
On 07/06/2012 03:11 PM, Akim Demaille wrote: > > --- a/build-aux/bootstrap > +++ b/build-aux/bootstrap > @@ -1,6 +1,6 @@ > #! /bin/sh > # Print a version string. > -scriptversion=2012-07-06.11; # UTC > +scriptversion=2012-07-06.13; # UTC > > # Bootstrap this package from checked-out sources. >

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Stefano Lattarini
On 07/06/2012 02:37 PM, Akim Demaille wrote: > Le 6 juil. 2012 à 14:24, Jim Meyering a écrit : > >>warnf '%s\n' "Error: '$app' version == $inst_ver is too old" \ >> " '$app' version >= $req_ver is required" > > Don't you mean warnf '%s\n%s\n'? Or should warnf expect a si

Re: FYI: do-release-commit-and-tag: fix typo

2012-07-05 Thread Stefano Lattarini
On 07/05/2012 05:37 PM, Akim Demaille wrote: > > Le 5 juil. 2012 à 17:13, Stefano Lattarini a écrit : > >> Hi Akim, Jim. > > hi Stefano, > >> Just a minor correction about your "set -e" interpretation ... >> >> But "false &&

Re: FYI: do-release-commit-and-tag: fix typo

2012-07-05 Thread Stefano Lattarini
Hi Akim, Jim. Just a minor correction about your "set -e" interpretation ... On 07/05/2012 04:53 PM, Jim Meyering wrote: > Akim Demaille wrote: >> Le 5 juil. 2012 à 15:24, Akim Demaille a écrit : >> >>>test "$(sed -n 3p NEWS)" = "$noteworthy_stub" \ >>> && die 'line 3 of NEWS looks fishy

Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade

2012-06-26 Thread Stefano Lattarini
Hi Eric. On 06/26/2012 06:29 PM, Eric Blake wrote: > On 06/26/2012 10:15 AM, Stefano Lattarini wrote: > >> What about this: since the great majority of the packages out there do >> not seem to override nor patch the Automake-provided auxiliary scripts, >> we could j

Re: [PATCH] config: drop scripts that automake says are not independent

2012-06-26 Thread Stefano Lattarini
On 06/26/2012 09:12 PM, Eric Blake wrote: > > [SNIP] > > And not mentioned in my proposed commit message, but I specifically kept > mdate-sh as one of the mirrored files, even though Stefano originally > suggested that it might be automake-centric; that particular script is > small enough to be use

Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade

2012-06-26 Thread Stefano Lattarini
On 06/26/2012 05:37 PM, Eric Blake wrote: > [adding bug-m4] > > On 06/26/2012 05:23 AM, Stefano Lattarini wrote: > >>>> I'm almost inclined not to do so, to force the affected >>>> projects' broken setup to be fixed; i.e., if you are using Auto

Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade (was: Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files)

2012-06-26 Thread Stefano Lattarini
Severity: minor thanks [Adding bug-automake] On 06/26/2012 12:32 PM, Bruno Haible wrote: > Stefano Lattarini wrote: >> I'm almost inclined not to do so, to force the affected >> projects' broken setup to be fixed; i.e., if you are using Automake 1.11, >> you let

Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files

2012-06-26 Thread Stefano Lattarini
Hi Eric. On 06/26/2012 05:46 AM, Eric Blake wrote: > On 06/20/2012 03:30 PM, Stefano Lattarini wrote: >> Before this change, the missing script had a twofold role: >> >> - it warned the user if some required maintainer tools was missing, >> or too old; >> &

Re: [PATCH] bootstrap: take advantage of POSIX shell features

2012-05-13 Thread Stefano Lattarini
On 05/13/2012 03:04 PM, Jim Meyering wrote: > >> + * build-aux/bootstrap: Prefer xpg4 parameter expansions over use >> + of sed/expr plus command substitutions, to save some forks. Since >> + we are at it, prefer the POSIX $(...) form of command substitution, > > The idiom

Re: [PATCH] bootstrap: take advantage of POSIX shell features

2012-05-13 Thread Stefano Lattarini
Hi Jim. On 05/13/2012 10:31 AM, Jim Meyering wrote: > >> diff --git a/build-aux/bootstrap b/build-aux/bootstrap > ... >> @@ -442,7 +442,7 @@ check_versions() { >> # "GNU automake-ng") when asked their version. >> case $app in >>automake-ng|aclocal-ng) >> -app=`echo "$app"

[PATCH] bootstrap: take advantage of POSIX shell features

2012-05-13 Thread Stefano Lattarini
eLog index 268fbe5..cf73593 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,24 @@ +2012-05-13 Stefano Lattarini + + bootstrap: take advantage of POSIX shell features + + The 'bootstrap' script offered by Gnulib script already uses POSIX + shell features (like $((..

Re: [PATCH] bootstrap: support Automake-NG in $buildreq

2012-04-26 Thread Stefano Lattarini
On 04/26/2012 03:38 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> * bootstrap (check_versions): Handle automake and aclocal from >> Automake-NG specially. They can be specified as respectively >> the "automake-ng" and "aclocal-ng" requirement

Re: [PATCH] bootstrap: support Automake-NG in $buildreq

2012-04-26 Thread Stefano Lattarini
On 04/23/2012 05:17 PM, Stefano Lattarini wrote: > * bootstrap (check_versions): Handle automake and aclocal from > Automake-NG specially. They can be specified as respectively > the "automake-ng" and "aclocal-ng" requirements. > Ping? Regards, Stefano

Re: [PATCH] bootstrap: support Automake-NG in $buildreq

2012-04-23 Thread Stefano Lattarini
Hi Eric, thanks for the quick feedback. On 04/23/2012 05:51 PM, Eric Blake wrote: > > What you have is worth committing now, but I wonder... > > Why are we doing app=`echo "$app" | sed 's/-ng$//'` instead of > app=${app%-ng}? > Because I thought ./bootstrap was expected to work also with "classi

[PATCH] bootstrap: support Automake-NG in $buildreq

2012-04-23 Thread Stefano Lattarini
* bootstrap (check_versions): Handle automake and aclocal from Automake-NG specially. They can be specified as respectively the "automake-ng" and "aclocal-ng" requirements. Signed-off-by: Stefano Lattarini --- build-aux/bootstrap | 17 - 1 file changed,

Re: should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"?

2012-03-23 Thread Stefano Lattarini
Hi Jim. On 03/23/2012 05:46 PM, Jim Meyering wrote: > Stefano Lattarini wrote: > ... >>> [1] http://savannah.gnu.org/bugs/?group=automake >>> >> (As a partial off-topic: is there any way to shut this down? Since we don't >> use the savannah tracker, allow

Re: should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"?

2012-03-23 Thread Stefano Lattarini
On 03/21/2012 11:14 PM, Bruno Haible wrote: > Hi Stefano, > >> We finally decided that the older behaviour was a bug. We've thus fixed it >> (in the automake maint branch, fix to appear in automake 1.11.4), > > Cool! Many thanks for your considerations and perseverance. > >> and I now propose t

Re: should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"?

2012-03-21 Thread Stefano Lattarini
[dropping automake list] On 03/13/2012 01:30 PM, Stefano Lattarini wrote: > [CC:ing Ralf, as I'd like to hear his opinion here] > > Reference: > <http://lists.gnu.org/archive/html/bug-gnulib/2012-03/msg00078.html> > > On 03/13/2012 01:14 PM, Stefano Lattarini

Re: should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"?

2012-03-15 Thread Stefano Lattarini
Hi Eric, sorry for the delay. On 03/13/2012 04:09 PM, Eric Blake wrote: > On 03/13/2012 08:55 AM, Robert Boehne wrote: >>> >>> So we're in a sort of a tie here: some users think that the current >>> Automake >>> behaviour is a feature (and I lean toward that position), other ones >>> (with >>> Ral

should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"? (was: Re: [PATCH] gnulib-tool: fix imprecise comments)

2012-03-13 Thread Stefano Lattarini
[CC:ing Ralf, as I'd like to hear his opinion here] Reference: <http://lists.gnu.org/archive/html/bug-gnulib/2012-03/msg00078.html> On 03/13/2012 01:14 PM, Stefano Lattarini wrote: > > Now that I think about it, I'm not sure whether it was done "by design" fr

Re: [PATCH] gnulib-tool: fix imprecise comments

2012-03-13 Thread Stefano Lattarini
Hi Bruno. On 03/13/2012 11:51 AM, Bruno Haible wrote: > Stefano Lattarini wrote: >> * gnulib-tool (func_emit_lib_Makefile_am): It's not just Automake >> versions < 1.9b that creates an empty pkgdatadir at installation >> time if pkgdata_DATA is specified to empty; m

[PATCH] gnulib-tool: fix imprecise comments

2012-03-13 Thread Stefano Lattarini
t accordingly. (func_emit_tests_Makefile_am): Likewise. Signed-off-by: Stefano Lattarini --- ChangeLog | 10 ++ gnulib-tool |8 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3a114aa..817e1d9 100644 --- a/ChangeLog +++ b/ChangeLog

Re: [PATCH] GNUmakefile: simplify detection of unconfigured trees

2012-02-17 Thread Stefano Lattarini
On 02/16/2012 09:24 PM, Eric Blake wrote: > On 02/16/2012 01:17 PM, Stefano Lattarini wrote: >> On 02/16/2012 09:24 PM, Eric Blake wrote: >>> a cool simplification. You've got my ACK. >>> >> Thanks. I will anyway wait until tomorrow before pushing, to give

Re: [PATCH] GNUmakefile: simplify detection of unconfigured trees

2012-02-16 Thread Stefano Lattarini
On 02/16/2012 09:02 PM, Eric Blake wrote: > On 02/16/2012 12:38 PM, Stefano Lattarini wrote: >> * top/GNUmakefile: Use $(wildcard) instead of $(shell) to determine >> whether the tree make is being run from is already configured or >> not. Related simplifications.

[PATCH] GNUmakefile: simplify detection of unconfigured trees

2012-02-16 Thread Stefano Lattarini
--git a/ChangeLog b/ChangeLog index ca738bf..49c12ad 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-02-16 Stefano Lattarini + + GNUmakefile: simplify detection of unconfigured trees + * top/GNUmakefile: Use $(wildcard) instead of $(shell) to determine + whether the

[PATCH] changelog: don't cluster multiple entries under the same "date line" (was: Re: [Feature request] gitlog-to-changelog: don't cluster multiple ...)

2012-01-17 Thread Stefano Lattarini
Attached is what I pushed to maint. Best regards, Stefano >From a6e60819ba512d6bf7376c543f8c40c9389eb4d7 Mon Sep 17 00:00:00 2001 Message-Id: From: Stefano Lattarini Date: Tue, 17 Jan 2012 23:31:19 +0100 Subject: [PATCH] changelog: don't cluster multiple entries under the same "date line"

Re: improve support for MSVC 9

2012-01-16 Thread Stefano Lattarini
Hi Bruno. On 01/15/2012 05:51 PM, Bruno Haible wrote: > > --- lib/sys_stat.in.h.origSun Jan 15 17:32:53 2012 > +++ lib/sys_stat.in.h Sun Jan 15 17:23:12 2012 > @@ -62,6 +62,11 @@ > # include /* mingw64, MSVC 9 */ > #endif > > +/* Native Windows platforms declare umask() in . */ > +#if 0

Re: Moving the gnupload script from automake to gnulib?

2012-01-15 Thread Stefano Lattarini
On 01/15/2012 05:06 PM, Stefano Lattarini wrote: > On 01/15/2012 05:02 PM, Jim Meyering wrote: > >> Otherwise, it looks fine. >> > Thanks. I've pushed the patch. > And for the record, I've applied the automake change as well: <http://lists.gnu.org/archive/h

Re: Moving the gnupload script from automake to gnulib?

2012-01-15 Thread Stefano Lattarini
On 01/15/2012 05:02 PM, Jim Meyering wrote: >> >> -# Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Free Software >> -# Foundation, Inc. >> +# Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Free >> +# Software Foundation, Inc. > > Might as well list 2004-2010 as a range. > Th

Re: Moving the gnupload script from automake to gnulib?

2012-01-15 Thread Stefano Lattarini
On 01/15/2012 04:50 PM, Stefano Lattarini wrote: > Hi Jim, thanks for the quick reply. > > On 01/15/2012 04:20 PM, Jim Meyering wrote: >> Stefano Lattarini wrote: >>> Hello Gnulibers. >>> >>> I've recently noticed that the gnupload script present

Re: Moving the gnupload script from automake to gnulib?

2012-01-15 Thread Stefano Lattarini
Hi Jim, thanks for the quick reply. On 01/15/2012 04:20 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Hello Gnulibers. >> >> I've recently noticed that the gnupload script present in the automake >> repository is *not* synced from an external source like I

Moving the gnupload script from automake to gnulib?

2012-01-15 Thread Stefano Lattarini
Hello Gnulibers. I've recently noticed that the gnupload script present in the automake repository is *not* synced from an external source like I thought, and like is done for other maintainer-oriented scripts and files that are not automake-specific (such as 'INSTALL', 'gitlog-to-changelog' or 'c

Re: [PATCH] init.sh: don't waste a subshell just to redirect stderr

2012-01-05 Thread Stefano Lattarini
On 01/05/2012 07:18 PM, Bruno Haible wrote: > Stefano Lattarini wrote: >> If gnulib could assume Automake 1.11, >> it could simply add the `parallel-tests' option to AUTOMAKE_OPTIONS in the >> gnulib-controlled Makefile.am. This setting would only influence the >>

Re: [PATCH] init.sh: don't waste a subshell just to redirect stderr

2012-01-05 Thread Stefano Lattarini
On 01/05/2012 05:56 PM, Bruno Haible wrote: > Eric Blake replied: >>> Wouldn't it be simpler and better to leave that redirection out altogether? >>> The output of the test scripts should be redirected to `.log' files by the >>> testsuite harness, so by being more verbose we can make those files mo

Re: [PATCH] init.sh: don't waste a subshell just to redirect stderr

2012-01-05 Thread Stefano Lattarini
Hi Jim. On 01/05/2012 04:46 PM, Jim Meyering wrote: > Looking at Bruno's recent test-init.sh failure, > I noticed the unnecessary sub-shells here: > > From a815c2160e6d6cc27d934e669ef9486bab310db3 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 5 Jan 2012 16:45:50 +0100 > Subject: [PA

Re: bug#10433: coreutils-8.14.116-1e18d: one gnulib-tests failure on Solaris 10 (with gcc)

2012-01-04 Thread Stefano Lattarini
Hi Jim. On 01/04/2012 08:20 PM, Jim Meyering wrote: > > Thank you for the report! > Here's a gnulib patch that should avoid that failure: > > From 77a1dda86f92f8e54da4e6344911a561ccfaba08 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Wed, 4 Jan 2012 20:19:37 +0100 > Subject: [PATCH] tes

Re: rationales in commit messages

2012-01-03 Thread Stefano Lattarini
On 01/03/2012 11:09 PM, Bruno Haible wrote: > Stefano Lattarini wrote: >> report in the commit message of your patch the useful and extensive >> arguments, explanations and references you have laid out so excellently in >> your mail. > > Is it better to copy the arg

Re: [PATCH] Don't use the abbreviation "win" to refer to Windows.

2012-01-03 Thread Stefano Lattarini
On 01/03/2012 12:59 AM, Bruno Haible wrote: > > [A GOOD PROPOSAL] > Thanks for this carefully thought-out proposal. My only 2 cents of advice is to report in the commit message of your patch the useful and extensive arguments, explanations and references you have laid out so excellently in your ma

Re: Don't use the abbreviation "win" to refer to Windows.

2012-01-02 Thread Stefano Lattarini
On 01/02/2012 02:53 PM, Andy Moreton wrote: > > Using the term "win32" does not connote winning or losing to any but the > most paranoid. Replacing proprietary software with free software is done > by being better: that includes being courteous, and not using derogatory > language. The term "woe32"

gitlog-to-changelog: how to specify "tiny changes"?

2011-12-30 Thread Stefano Lattarini
Hello gnulibers. Currently, the `gitlog-to-changelog' script has no way of allowing the maintainer to specify that a changeset is "small" enough not to require copyright assignment to the FSF (in hand-maintained ChangeLogs, that is done with the usual "(tiny change)" addition after the author name

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
On 12/23/2011 05:19 PM, Jim Meyering wrote: >>> However, I would prefer an adaptive/hybrid solution: if a commit log >>> is composed of two or more paragraphs, keep it in a separate block. >>> Otherwise, merge entries that would otherwise have a date--name--email >>> header identical to the precedi

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
On 12/23/2011 04:11 PM, Jim Meyering wrote: > > Stefano Lattarini wrote: > >> I hope the above argument will make you reconsider this position; >> ... > > Position? I had not taken a position. Any feature request should be > accompanied by justification. The

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
On 12/23/2011 03:38 PM, Jim Meyering wrote: > Stefano Lattarini wrote: >> Hello Gnulibers. >> >> Currently, the `gitlog-to-changelog' script clusters ChangeLog entries with >> the same date together, placing them under a single "date line" in the >&

[Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2011-12-23 Thread Stefano Lattarini
2 Jim Meyering correct previous ChangeLog entry: s/set -x/set -e/ Spotted by Stefano Lattarini. init.sh: avoid unwarranted test failure when using "set -x" * tests/init.sh (compare): Ignore nonzero exit from compare_dev_null_. Otherwise, in a t

Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"

2011-12-22 Thread Stefano Lattarini
Hi Jim. On 12/22/2011 12:44 PM, Jim Meyering wrote: > FYI, after updating to the latest tests/init.sh, I noticed new > failures in vc-dwim's "make check". Tracked it down to this: > > From ed2ad641686263add14f2081d659da0cc3a76536 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 22 Dec

Re: gitlog-to-changelog and extra blurbs

2011-12-07 Thread Stefano Lattarini
On Wednesday 07 December 2011, Werner Koch wrote: > Hi, > Hello Werner. > I started to use gitlog-to-changelog for my projects. However, there is > a little annoying thing: Every so often I like to add longer blurbs to > the git commit log which I don't want to see in a ChangeLog. Examples > are

spurious message about include files from `bootstrap' script

2011-12-02 Thread Stefano Lattarini
Hello gnulibers. While boostrapping the latest coreutils from master (v8.14-79-g1a85d4a), I've noticed some spurious lines in the messages generated (I believe) from the `bootstrap 'script; here is an excerpt that should highlight them: ... Creating ./lib/uniwidth/.gitignore Creating ./m4/.

Re: failure in building gnulib tests wih pcc on debian

2011-11-15 Thread Stefano Lattarini
On Tuesday 15 November 2011, Bruno Haible wrote: > Eric Blake wrote: > > > ... on an unstable Debian using pcc > > > (Portable C Compiler, version 1.1.0~DEVEL+20110422-1 > > ... > > Warnings like this, and the error in test-float.c, mean that all other > > packages using the same gnulib modules wil

Re: [PATCH] README-release improvements

2011-10-23 Thread Stefano Lattarini
Hi Gary. On Sunday 23 October 2011, Gary V wrote: > Hi Stefano, > > In practice, I prefer to: > > git status > > git clean -f -x -d > ./bootstrap --gnulib-srcdir=../gnulib && ./configure --disable-nls > > This is way faster, but relies on my discretion. Like Jim, I'm leary of > recommen

Re: [PATCH] README-release improvements

2011-10-22 Thread Stefano Lattarini
On Saturday 22 October 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > >> make -k maintainer-clean # Clean up previous build artefacts > >> ./configure > >> make maintainer-clean# Clean up previous build artefacts > >> git checkout master

Re: [PATCH] README-release improvements

2011-10-22 Thread Stefano Lattarini
Hi everybody. Just my two cents about this matter ... On Saturday 22 October 2011, Bruno Haible wrote: > Gary V. Vaughan wrote: > > >> Running the (potentially) outdated configure, to build a (potentially) > > >> outdated Makefile, which may very well rerun aclocal, automake, autoconf > > >> etc

Re: a saner bootstrap script

2011-09-26 Thread Stefano Lattarini
On Monday 26 September 2011, Gary V wrote: > Hi Stefano! > Hi Gary, thanks for your quick and detailed answers. > [[Items I agree with elided]] > Ditto. > On 26 Sep 2011, at 17:27, Stefano Lattarini wrote: > > Do you have a diff file to show what you've changed exactly?

Re: a saner bootstrap script

2011-09-26 Thread Stefano Lattarini
On Monday 26 September 2011, Gary V wrote: > >> > > Maybe some code like this should be enough to catch most potential > > erroneous definitions? > > > > case $po_download_command_format in > >*[^%]%s*[^%]%s*) ;; > >*) fatal "invalid format in \$po_download_command_format";; > > esac >

Re: a saner bootstrap script

2011-09-26 Thread Stefano Lattarini
On Monday 26 September 2011, Gary V wrote: > >> @cnindex gnulib_precious > >> @item gnulib_precious > >> Normally, @command{bootstrap} removes any macro-files that are not > >> included by @file{aclocal.m4} before it returns, except for files > >> listed in this variable which are always kept. > >

Re: a saner bootstrap script

2011-09-26 Thread Stefano Lattarini
On Monday 26 September 2011, Gary V wrote: > Hi Stefano, > > On 25 Sep 2011, at 22:55, Stefano Lattarini wrote: > > On Thursday 22 September 2011, Gary V wrote: > >> Anyone: > >> > >> It's beginning to look as though all this work is, once again, in

Re: a saner bootstrap script [Was Re: I fixed this once already]

2011-09-25 Thread Stefano Lattarini
And this is a quick review about the new documentation ... On Thursday 22 September 2011, Gary V wrote: > > @node Bootstrap > @chapter Bootstrap > > The process of executing the various tools required to bring all the > generated files up to date in a directory freshly checked out from > source c

Re: a saner bootstrap script [Was Re: I fixed this once already]

2011-09-25 Thread Stefano Lattarini
On Thursday 22 September 2011, Gary V wrote: > Anyone: > > It's beginning to look as though all this work is, once again, in very > real danger of just slipping quietly through the cracks. > Hi Gary. While I don't pretend to really understand the scope and purposes of your script, I might anyway

Re: Syntax checks in perl (was: Re: maint.mk syntax check problems)

2011-09-15 Thread Stefano Lattarini
0/40 against the use of python. But I'd like to hear the opinion of the most active gnulibers and autoconfers on this. > > With a good Perl-based harness, I'll certainly be glad to phase > > out (of projects I maintain) the make-based tests. > > Me, too. > Go

Re: maint.mk syntax check problems

2011-09-15 Thread Stefano Lattarini
Hi Jim. On Thursday 15 September 2011, Jim Meyering wrote: > Martin von Gagern wrote: > ... > >> It might not be worth the effort/disruption. > >> One advantage of using Makefile rules is that it's easy to override > >> the defaults, as you see in the examples above. > > > > Not so hard with shell

Re: m4 brackets question

2011-09-14 Thread Stefano Lattarini
On Tuesday 13 September 2011, Eric Blake wrote: > On 09/13/2011 03:09 PM, Bruno Haible wrote: > > Please, can you turn off these "m4 comments" for Autoconf 3.0? > > You can turn them off yourself with m4_changecom(). > Or use the `@%:@' quadrigraph instead of a literal `#'. I've found that this i

Re: autoconf + automake support for MSVC

2011-09-03 Thread Stefano Lattarini
On Saturday 03 September 2011, Peter Rosin wrote: > Hi Stefano, > > Den 2011-09-03 09:41 skrev Stefano Lattarini: > > On Saturday 03 September 2011, Peter Rosin wrote: > >> > >> [BIG SNIP] > >> > >> I don't think cccl is the future, I

Re: autoconf + automake support for MSVC

2011-09-03 Thread Stefano Lattarini
Hi Peter. On Saturday 03 September 2011, Peter Rosin wrote: > > [BIG SNIP] > > I don't think cccl is the future, I see it as the past. It's > simply not needed when the needed bits are already in 'compile'. > > It's a bit sad to see all the effort going into writing private > scripts wrapping cl

Re: errno --> errno name ?

2011-08-05 Thread Stefano Lattarini
Hi Bruce. On Friday 05 August 2011, Bruce Korb wrote: > On 08/04/11 17:39, Bruno Haible wrote: > > Hi Bruce, > > > >> I fixed up the "mk" script to be more portable > > > > Indeed, that looks like most portability problems have been eliminated. > > > >> tho I haven't tried it on Solaris' /bin/sh.

Re: [PATCH] warnings: add comments about previous patch

2011-07-26 Thread Stefano Lattarini
-header.m4: Document AS_VAR_PUSHDEF limitation. > * m4/include_next.m4: Likewise. > * m4/warn-on-use.m4: Likewise. > * m4/warnings.m4: Likewise, and simplify use. > Suggested by Stefano Lattarini. > If you haven't already pushed this, I'd like to suggest to credit Jim too here:

  1   2   >