While generally it might be safe to compare pointer against
literal 0, it may make one think that the pointer is an int.
Use explicit comparison against NULL (or !ptr).
Signed-off-by: Michal Privoznik
---
lib/alloca.c | 10 +-
lib/backup-find.c| 2 +-
lib/bitset/list.c
On 01/02/2018 08:38 AM, Paul Eggert wrote:
> Michal Privoznik wrote:
>
>> it's not a false positive either
>
> It depends on what we're looking for. I'm looking for bugs. To take an
> extreme example, if GCC warned about every character string literal
> c
On 01/01/2018 07:41 PM, Paul Eggert wrote:
> Michal Privoznik wrote:
>> I'm failing to see why this would be a
>> false positive.
>
> It's a false positive in the sense that there is no bug here. That is,
> the Gnulib patch would mean that we would be spending
On 01/01/2018 10:53 AM, Paul Eggert wrote:
> Thanks, but -Wunused-parameter issues so many false alarms that I think
> I'd rather just ask people to compile with -Wno-unused-parameter. That's
> what coreutils does, and Emacs, and so forth.
Can you elaborate on this please? I'm failing to see why t
* lib/stat-time.h (stat_time_normalize):
Mark "st" as used.
Signed-off-by: Michal Privoznik
---
lib/stat-time.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/stat-time.h b/lib/stat-time.h
index 5f8bf4e12..11acbfb1f 100644
--- a/lib/stat-time.h
+++ b/lib/stat-time.h
@@ -24
Dear list,
I've noticed some tests failing on my FreeBSD when I try to do 'make
distcheck' for libvirt project.
How to reporoduce:
1) git clone git://libvirt.org/libvirt.git libvirt.git
2) cd libvirt.git
3) ./autogen.sh --system
4) make distcheck
5) observe error in gnulib tests
BTW: test-pthrea
On 03/15/2017 12:24 AM, Paul Eggert wrote:
> I installed the attached patch to Gnulib on Savannah; please give it a try.
Yep, that works. I see you've already pushed it. Thank you.
Michal
Dear list,
I'm a libvirt developer and we rely on gnulib in our project. However, I
was reviewing a patch for bhyve driver (bhyve is a *BSD hypervisor), so
I've booted up my FreeBSD virtual machine and started the review. While
doing 'make distcheck' gnulib tests ran and I've noticed couple of the
The currently listed link does not exist anymore. For a quite
long time the libvirt's repo lives on libvirt.org server.
Signed-off-by: Michal Privoznik
---
users.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/users.txt b/users.txt
index d638a335a..4fa555331 100644
Hey guys,
I've just discovered a bug, well a hang in conftest. This is what I ran:
libvirt.git $ git clean -fxd; ./autogen.sh --system
and all looked good until this:
checking whether readlink signature is correct... yes
checking whether readlink handles trailing slash correctly... yes
checking
10 matches
Mail list logo
