Re: mingw: test-poll pipe part fails

2011-06-03 Thread Matthias Bolte
2011/5/25 Matthias Bolte : > Output from a test run on mingw > > Unconnected socket test... passed > Connected sockets test... passed > General socket test with fork... passed > Pipe test... failed (expecting POLLHUP after shutdown) > FAIL: test-poll.exe > > This

freebsd: abort usage in rpl_strerror_r

2011-05-27 Thread Matthias Bolte
Since e67e250d98e9dc0177a564f2cbfa99330902fe9e rpl_strerror_r contains an abort call in a section of code that is compiled on FreeBSD. But gcc complains about this strerror_r.c: In function 'rpl_strerror_r': strerror_r.c:503: warning: implicit declaration of function 'abort' strerror_r.c:503: warn

mingw: test-poll pipe part fails

2011-05-25 Thread Matthias Bolte
Output from a test run on mingw Unconnected socket test... passed Connected sockets test... passed General socket test with fork... passed Pipe test... failed (expecting POLLHUP after shutdown) FAIL: test-poll.exe This affects the attempt to make libvirtd working on Windows. libvirtd relies on po

mingw: test-getcwd-lgpl assertion failure

2011-05-25 Thread Matthias Bolte
ASSERT (errno == EINVAL) in line 98 fails, errno is set to ERANGE instead of EINVAL. Found via libvirt on mingw with recent gnulib version: f4c4af09bcf3f0497dc3347ecc0a0b3c9ee1ff63 Matthias

mingw: test-ftell and test-ftello assertion failures

2011-05-25 Thread Matthias Bolte
In both tests ASSERT (ftell (stdin) == -1); in line 45 fails. ftell (stdin) returns 0 in this case. Found via libvirt on mingw with recent gnulib version: f4c4af09bcf3f0497dc3347ecc0a0b3c9ee1ff63 Matthias

Re: test-getcwd-lgpl fails on FreeBSD 8.1

2011-05-14 Thread Matthias Bolte
2011/5/13 Eric Blake : > On 05/13/2011 02:26 AM, Matthias Bolte wrote: >> I found this while testing current libvirt git on FreeBSD 8.1 32bit. >> When runnig in gdb >> ./gnulib/tests/test-getcwd-lgpl in the libvirt source tree then the >> same ASSERT fails. Sometimes AS

test-getcwd-lgpl fails on FreeBSD 8.1

2011-05-13 Thread Matthias Bolte
I found this while testing current libvirt git on FreeBSD 8.1 32bit. When running gmake check in the libvirt source tree then ASSERT (getcwd (NULL, i) == NULL) in test-getcwd-lgpl.c in line 74 fails on the first iteration of the for loop. When runnig in gdb ./gnulib/tests/test-getcwd-lgpl in the l

[PATCH] pthread: Fix pthread.h creation for srcdir != builddir

2010-08-13 Thread Matthias Bolte
--- modules/pthread |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/pthread b/modules/pthread index 9b930b1..76eca90 100644 --- a/modules/pthread +++ b/modules/pthread @@ -18,7 +18,7 @@ BUILT_SOURCES += $(PTHREAD_H) # We need the following in order to create whe

Re: [PATCHv4] gethostname: fix build on mingw

2010-03-22 Thread Matthias Bolte
ts > until we are sure that winsock2.h is completely included. > > * lib/unistd.in.h (includes): Work around fact that mingw > re-includes , by avoiding any > redeclarations if we are being included by . > Reported by Matthias Bolte. > > Signed-off-by: Eric Blake > --- &

Re: [PATCH] gethostname: fix build on mingw

2010-03-21 Thread Matthias Bolte
o > fixing things if a .c includes (or even ) > prior to . > > * lib/sys_socket.in.h (includes): Set witness when including > winsock2.h. > * lib/unistd.in.h (includes): Likewise, after hoisting > inclusion.  Don't replace anything when included by winsock2.h. > Repor

Re: [PATCH] gethostname: fix build on mingw

2010-03-21 Thread Matthias Bolte
o > fixing things if a .c includes (or even ) > prior to . > > * lib/sys_socket.in.h (includes): Set witness when including > winsock2.h. > * lib/unistd.in.h (includes): Likewise, after hoisting > inclusion.  Don't replace anything when included by winsock2.h. > Repor

Re: [PATCH] gethostname: fix build on mingw

2010-03-21 Thread Matthias Bolte
2010/3/20 Eric Blake : > On 03/19/2010 05:35 PM, Matthias Bolte wrote: >>> I believe this will solve the issue, but would appreciate some testing >>> by Matthias.  I also think that this is the same issue as: >>> http://lists.gnu.org/archive/html/bug-gnulib/2010-01/ms

Re: [PATCH] gethostname: fix build on mingw

2010-03-19 Thread Matthias Bolte
mplete. > > * lib/sys_socket.in.h (includes): Set witness when including > winsock2.h. > * lib/unistd.in.h (includes): Don't replace anything when included > by winsock2.h. > Reported by Matthias Bolte. > > Signed-off-by: Eric Blake > --- > > Thanks to Matthias for doing