Re: [libvirt] [PATCH] show compiled in options in virsh --version

2010-10-28 Thread Justin Clift
On 10/29/2010 04:43 PM, Jim Meyering wrote: > Of course. Thanks for the reminder, Bruno. > That is indeed a slippery slope. I was too hasty in saying "ok". > > Eric, one option is to use the GPLv3 for programs like virsh, > then to have a second gnulib library that they would use. Cue "making

Re: [PATCH] bootstrap: work with pkg-config

2010-10-05 Thread Justin Clift
On 10/06/2010 01:22 AM, Eric Blake wrote: On 10/05/2010 08:13 AM, Eric Blake wrote: @@ -351,7 +351,7 @@ check_versions() { app=libtoolize fi # Honor $APP variables ($TAR, $AUTOCONF, etc.) - appvar=`echo $app | tr '[a-z]' '[A-Z]'` + appvar=`echo $app | tr '-a-z' '_A-Z'` Actually, 'tr -- -a-z _A

Re: bootstrap and pkg-config [was: [libvirt] OSX 10.6 build failures]

2010-10-05 Thread Justin Clift
On 10/05/2010 11:15 PM, Eric Blake wrote: Program Min_version Status - autoconf 2.59 OK - 2.61 found automake 1.9.6 OK - 1.10 found autopoint - OK gettext - OK git 1.5.5 OK - 1.73 found gzip - OK libtool - OK perl 5.5 OK - 5.10 found pkg-config - MISSING t

Re: [libvirt] [PATCH] autogen: allow aclocal to receive arguments via an environment variable

2010-09-30 Thread Justin Clift
On 10/01/2010 07:28 AM, Eric Blake wrote: Done, and pushed in Justin's name. I added (tiny change) in the ChangeLog to reflect that Justin does not have FSF copyright assignment on file for gnulib (although technically, it appears that Red Hat has blanket assignment). No stress here about doin

Re: [libvirt] [PATCH] autogen: added glibtool and pkg-config checks

2010-09-29 Thread Justin Clift
On 09/29/2010 10:13 PM, Gary V. Vaughan wrote: Just wanting to get an idea when we can drop the simple override patch for Mac OS X? :) If that was directed at me, I wasn't paying enough attention to the rest of the thread to know what that patch is... ;) Nah. With libvirt, we presently have

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Justin Clift
On 09/29/2010 12:29 AM, Eric Blake wrote: But the failed link mentions rpl_poll, not poll, which means this is most likely a gnulib bug in the poll module. Rather than skipping this test on just 32-bit MacOS in libvirt, I think the better thing to do is address why gnulib is triggering a link fa

Re: [libvirt] [PATCH] autogen: added glibtool and pkg-config checks

2010-09-27 Thread Justin Clift
On 09/16/2010 03:02 AM, Eric Blake wrote: [adding bug-gnulib] On 09/15/2010 06:36 AM, Justin Clift wrote: OSX MacPorts has libtool named as glibtool, with libtoolize named as glibtoolize. This patch adds support for this, and also adds a check for pkg-config, to warn when it is missing. So

Re: IPv6 structs on MacOS X

2010-09-15 Thread Justin Clift
lity problem. This stuff is outside my area of expertise though. :) Regards and best wishes, Justin Clift

Re: IPv6 structs on MacOS X

2010-09-15 Thread Justin Clift
On 09/16/2010 06:32 AM, Eric Blake wrote: I agree with Bruno - the portability problem stems from using a field member not specified by POSIX in the first place. It should be sufficiently easy to rewrite the offending libvirt code to use only the portable interfaces, without burdening gnulib wit

Re: [libvirt] [PATCH] virsh: change wexitstatus order to allow compilation on mac osx

2010-09-15 Thread Justin Clift
On 09/16/2010 05:49 AM, Eric Blake wrote: +MacOS 10.5. Is "10.5" the right choice for this? Wondering if maybe it should be a range indicator, as "10.6"(.4)" here has this issue, and it sounds like pretty much all of the previous versions will too. ?

Re: [libvirt] [PATCH] autogen: added glibtool and pkg-config checks

2010-09-15 Thread Justin Clift
On 09/16/2010 03:02 AM, Eric Blake wrote: [adding bug-gnulib] On 09/15/2010 06:36 AM, Justin Clift wrote: OSX MacPorts has libtool named as glibtool, with libtoolize named as glibtoolize. This patch adds support for this, and also adds a check for pkg-config, to warn when it is missing. Hmm