Re: critique of gnulib

2019-09-01 Thread Jonas 'Sortie' Termansen
Hi Bruno & Paul, Thanks for your interest in my notes on gnulib. I appreciate your desire to discuss them. Please excuse some of the resources that I'll link below for overreacting in jest ("screaming in horror", "usual gnulib infection"), they weren’t really meant for upstream consumption, but th

Re: Fix weird _SC_OPEN_MAX usage

2014-08-07 Thread Jonas 'Sortie' Termansen
On 08/07/2014 06:59 PM, Paul Eggert wrote: > That shouldn't be a problem, since the modules in question all depend on > the getdtablesize module, which should supply the getdtablesize function > on platforms that lack it. Ah. I missed that. Some background: I'm porting these modules (as found in

[PATCH] getpass: conditionalize variable declarations

2014-08-06 Thread Jonas 'Sortie' Termansen
This fixes unused variable warnings. Additionally, the struct termios may not be defined on systems without tcsetattr and no termios header. --- lib/getpass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/getpass.c b/lib/getpass.c index 43d0d59..18dc0b7 100644 --- a/lib/getpass.c +++ b

Fix weird _SC_OPEN_MAX usage

2014-08-06 Thread Jonas 'Sortie' Termansen
then: #ifdef _SC_OPEN_MAX int maxfd = sysconf (_SC_OPEN_MAX); #else int maxfd = getdtablesize (); #endif Jonas 'Sortie' Termansen

Re: parse-duration.c - TIME_MAX conflict

2014-06-17 Thread Jonas 'Sortie' Termansen
On 06/15/2014 06:53 PM, Bruce Korb wrote: > I still think that "implementations" need an unambiguously distinct > name space. *_MAX is too greedy. It actually turns out that POSIX has reserved the _MIN and _MAX suffixes for as stated in POSIX 2008 `2.2.2 The Name Space'. It has a nice table with

Re: parse-duration.c - TIME_MAX conflict

2014-06-15 Thread Jonas 'Sortie' Termansen
On 06/15/2014 06:53 PM, Bruce Korb wrote: > Actually, it occurs to me that the result still uses TIME_MAX and, if > not guarded, > still conflicts with glibc's claim to a new name. I still think that > "implementations" > need an unambiguously distinct name space. *_MAX is too greedy. Ah, don't

Re: parse-duration.c - TIME_MAX 2038 unpreparedness

2014-06-11 Thread Jonas 'Sortie' Termansen
Hi Bruce, On 06/11/2014 02:38 AM, Bruce Korb wrote: > OK, I promise to fix it within the next 24 years. It will be a while before any 2038 issues happen, yeah. Though, some operating systems vendors today are making guarantees that their current installations will be able to last past that point

parse-duration.c - TIME_MAX 2038 unpreparedness

2014-06-01 Thread Jonas 'Sortie' Termansen
a safe and portable manner. It would probably be best to not use a define named TIME_MAX, as that name would be ideal if a standard header wanted to expose the domain of time_t for use in cases like this (indeed, this came up because I am adding a TIME_MAX constant to my libc). Jonas 'S