Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2012-01-17 Thread Joel E. Denny
On Tue, 17 Jan 2012, Jim Meyering wrote: > > Below is a patch that adds a --no-cluster option, which I believe does > > what Stefano wants. I want it too. OK to push? > > Hi Joel, > > Thanks. That looks fine, but please adjust the preceding comment > to keep in sync with the new behavior. Th

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"

2012-01-17 Thread Joel E. Denny
, > I'll probably apply it here. Below is a patch that adds a --no-cluster option, which I believe does what Stefano wants. I want it too. OK to push? >From 46ea4e0437ab93956d06d414eaeb73ccf81b5b90 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Tue, 17 Jan 2012 16:23:30 -050

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-11-21 Thread Joel E. Denny
Hi Jim, On Sat, 20 Nov 2010, Jim Meyering wrote: > Personally I wouldn't worry about MSYS or even NFS/Solaris. > As far as I'm concerned, you're welcome to push your change. > If someone finds a way to make it misbehave, I'm sure > it'll be fixed promptly. I've pushed it. Thanks.

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-11-20 Thread Joel E. Denny
On Sat, 20 Nov 2010, Ralf Wildenhues wrote: > > Ok, is the following patch what you had in mind? > > I think so, yes, but let the bootstrap authors have their say please. Sure, I can wait. > Can you test this on MSYS or on an NFS mount with, say, Solaris or so? I have no experience with MSYS.

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-11-20 Thread Joel E. Denny
the following patch what you had in mind? Inspired by gnulib-tool's --no-reexec, I also added --no-bootstrap-sync on the exec just in case it might help avoid an infinite loop or fork bomb in some strange case we haven't thought of. >From 6a106df216da6fd3c8f70561903e5bc26a1f1ea4 M

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-11-19 Thread Joel E. Denny
written. If that's not the desired behavior, then I'm not sure what the right behavior is, and that project can just leave bootstrap_sync disabled. >From 17fdf63c0175e872a6f5167c03bb2a0b0dfd0582 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Fri, 19 Nov 2010 22:19:59 -0

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-11-14 Thread Joel E. Denny
Hi, > On Mon, 18 Oct 2010, Paul Eggert wrote: > > > How about another idea: have a very simple bootstrap script. All it > > does is fetch gnulib, and execute gnulib's more-complicated script. After seeing a few more bootstrap patches go through, I'm motivated to revisit this idea again. To ke

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-10-22 Thread Joel E. Denny
Hi Gary, On Mon, 18 Oct 2010, Gary V. Vaughan wrote: > Before you put too much effort into patching the incumbent bootstrap script, > please take a look at my complete rewrite. I have no other plans. > I'd be very happy for you to try it out, and let me know of your successes > and issues in ad

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-10-22 Thread Joel E. Denny
Hi Paul, On Mon, 18 Oct 2010, Paul Eggert wrote: > How about another idea: have a very simple bootstrap script. All it > does is fetch gnulib, and execute gnulib's more-complicated script. We've started down that road before, but for a different initial reason. The idea arises a few messages

Re: [PATCH] bootstrap: add bootstrap_sync option.

2010-10-17 Thread Joel E. Denny
Hi Paul, On Sun, 17 Oct 2010, Paul Eggert wrote: > On 10/17/2010 09:27 AM, Joel E. Denny wrote: > > Now that Bison's bootstrap is in sync with gnulib's, I'd like to make sure > > we keep it that way. This patch will help. Ok to push? > > I dunno,

[PATCH] bootstrap: add bootstrap_sync option.

2010-10-17 Thread Joel E. Denny
Hi, Now that Bison's bootstrap is in sync with gnulib's, I'd like to make sure we keep it that way. This patch will help. Ok to push? >From 8b8690c8758371880c85e2186b5491de1bc307b2 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Sun, 17 Oct 2010 11:54:21 -0400 Subject:

Re: [PATCH] bootstrap: anchor .gitignore entries.

2010-10-17 Thread Joel E. Denny
On Sun, 17 Oct 2010, Jim Meyering wrote: > Joel E. Denny wrote: > > * build-aux/bootstrap (insert_sorted_if_absent): Replace all uses > > with... > > (insert_vc_ignore): ... this new function, which prepends `/' to > > all .gitignore entries before passing the

[PATCH] bootstrap: anchor .gitignore entries.

2010-10-16 Thread Joel E. Denny
2.html The patch below fixes bootstrap to do the same. Ok to commit? >From 8b9b4bbba5041e107a8dea35e78d28dd3cc979f7 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Sat, 16 Oct 2010 16:54:23 -0400 Subject: [PATCH] bootstrap: anchor .gitignore entries. * build-aux/bootstrap (insert_sor

Re: gettext in bootstrap-tools

2010-08-04 Thread Joel E. Denny
Hi Bruno, Paul, On Sat, 31 Jul 2010, Bruno Haible wrote: > Regarding gettext, there is usually no functional difference between .mo > files generated by msgfmt 0.11 and those generated by msgfmt 0.18.1.1. > So it's probably not worth mentioning. For users who are trying to debug a bison build pr

Re: gettext in bootstrap-tools

2010-07-31 Thread Joel E. Denny
Hi Bruno, On Sat, 31 Jul 2010, Bruno Haible wrote: > > On the bison mailing lists, it was recently suggested that bison should > > include gettext in bootstrap-tools in cfg.mk. That sounds reasonable to > > me, but I see that coreutils and m4 don't do this. > > The gnulib 'gettext' module is

gettext in bootstrap-tools

2010-07-30 Thread Joel E. Denny
Hi, On the bison mailing lists, it was recently suggested that bison should include gettext in bootstrap-tools in cfg.mk. That sounds reasonable to me, but I see that coreutils and m4 don't do this. Is there any general rule of thumb about which tools are significant enough to be listed? Tha

Re: [GNU Bison 2.4.2] testsuite: Failing tests of bison 2.4.2 on Solaris 8+9 w/Sun Studio 11+12

2010-04-25 Thread Joel E. Denny
On Sun, 25 Apr 2010, Dagobert Michelsen wrote: > However, I had the impression you wanted to > implement different checking for cc and CC? I thought that would be the most general solution, but the consensus appears to be that gnulib should not have to handle this. On Mon, 26 Apr 2010, Bruno Ha

Re: [GNU Bison 2.4.2] testsuite: Failing tests of bison 2.4.2 on Solaris 8+9 w/Sun Studio 11+12

2010-04-22 Thread Joel E. Denny
On Wed, 21 Apr 2010, Paolo Bonzini wrote: > Having OpenCSW regenerate the libgnugetopt package with "gnulib-tool > --create-testdir --dir=libgnugetopt getopt-gnu" and dropping support > for the old package seems easiest, and does not require further > uglification of gnulib. Given the last findin

Re: [GNU Bison 2.4.2] testsuite: Failing tests of bison 2.4.2 on Solaris 8+9 w/Sun Studio 11+12

2010-04-20 Thread Joel E. Denny
On Tue, 20 Apr 2010, Eric Blake wrote: > I'm assuming that later in configure we reject -lgnugetopt's getopt_long > as broken (unless libgnugetopt has somehow picked up this month's glibc > fix), meaning that we still want to declare rpl_getopt and friends; Well, there's this: configure:8265: ch

Re: [GNU Bison 2.4.2] testsuite: Failing tests of bison 2.4.2 on Solaris 8+9 w/Sun Studio 11+12

2010-04-20 Thread Joel E. Denny
On Tue, 20 Apr 2010, Eric Blake wrote: > >>> if you use autoconf 2.64 (prior to that, if the existence and > >>> compilation checks disagree, autoconf went with the existence check). > >> > >> We are using autoconf 2.65. > > Then I'm confused how /opt/csw/include/getopt.h is getting included at >

Re: [GNU Bison 2.4.2] testsuite: Failing tests of bison 2.4.2 on Solaris 8+9 w/Sun Studio 11+12

2010-04-19 Thread Joel E. Denny
On Thu, 15 Apr 2010, Eric Blake wrote: > On 04/15/2010 03:39 PM, Joel E. Denny wrote: > > % cat > tmp.cc > > #define __EXTENSIONS__ 1 > > #include > > #include > > % CC -I/opt/csw/include tmp.cc > > "/opt/csw/include/getopt.h", line 122: Error

Re: [GNU Bison 2.4.2] testsuite: Failing tests of bison 2.4.2 on Solaris 8+9 w/Sun Studio 11+12

2010-04-15 Thread Joel E. Denny
I'm adding bug-gnulib because this portability problem is larger than bison. On Mon, 12 Apr 2010, Dagobert Michelsen wrote: > > Can you become jdenny on current9s and determine the exact commands that > > are necessary to build Bison with these failures? That would save me a > > lot of time. T

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-14 Thread Joel E. Denny
On Mon, 12 Apr 2010, Petr Machata wrote: > The instructions that you gave indeed do reproduce the problem. Thanks for confirming. > P.S. I seriously wonder whether it's worth it to hunt this esoteric bug. > (Especially given that it was confirmed that the code is written > correctly.) As I sai

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Joel E. Denny
On Sun, 11 Apr 2010, Bruno Haible wrote: > The code in bison-2.4.2/src/output.c looks fine. Thanks for confirming. > Can you help reproducing or debugging it, with just 2 executables: bison > and m4? (I.e. give a "how to reproduce" that does not involve bison's > testsuite? I'm not inclined to l

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Joel E. Denny
Hi Bruno, On Sun, 11 Apr 2010, Bruno Haible wrote: > > pid = create_pipe_bidi ("m4", m4, (char **)(void*)argv, false, true, > > true, filter_fd); > > I thought that create_pipe_bidi is supposed to make sure > > that the m4 subprocess is killed when Bison invokes exi

Re: Failing test case 67 Fatal errors but M4 continues producing output

2010-04-11 Thread Joel E. Denny
I'm adding bug-gnulib in case they have already seen this problem with create_pipe_bidi. On Fri, 9 Apr 2010, Petr Machata wrote: > I was rebasing the bison package to latest stable (2.4.2) in Fedora > distribution, and found out that the test case 67 fails. I'm attaching > testfile.log. Here's

Re: [PATCH] Fix handling of restrict keyword for newer Sun Studio C++.

2010-04-11 Thread Joel E. Denny
On Sat, 10 Apr 2010, Bruno Haible wrote: > 2010-04-10 Bruno Haible > > * m4/gnulib-common.m4 (AC_C_RESTRICT): Don't define for > autoconf >= 2.62. > Reported by Joel E. Denny . That works for me. Please push. Thanks.

[PATCH] Fix handling of restrict keyword for newer Sun Studio C++.

2010-04-10 Thread Joel E. Denny
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ok to apply this patch? >From 44e7c72451c66c1a429bfd24afeabe5b9a9cca64 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Sat, 10 Apr 2010 02:10:51 -0400 Subject: [PATCH] Fix handling of restrict keyword for newer Sun Studio C++. * m4/gnu

Re: bootstrap: allow more than one submodule

2010-03-17 Thread Joel E. Denny
Hi Eric, Bruno, On Tue, 16 Mar 2010, Eric Blake wrote: > Indeed, bison already uses multiple submodules (gnulib and autoconf), > and has done for more than a year. It may be worth getting Joel's > opinions here, as the maintainer of the only GNU package that I am aware > of that currently tracks

Re: [PATCH] mbswidth: add new functions to handle tabs

2010-01-13 Thread Joel E. Denny
Hi Bruno, Thanks for your response. On Thu, 14 Jan 2010, Bruno Haible wrote: > This functionality is not yet in gnulib. But I don't think it's general > enough: Today you want to support tabs. Tomorrow you'll want to support > line numbers and '\v' characters. Next week someone will want to supp

[PATCH] mbswidth: add new functions to handle tabs

2010-01-11 Thread Joel E. Denny
a43 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Mon, 11 Jan 2010 20:31:44 -0500 Subject: [PATCH] mbswidth: add new functions to handle tabs Generalized from code originally written by Paul Eggert for GNU Bison. * lib/mbswidth.c (add_column_width): New static inline function. (mbstwidth)

Re: [PATCH] fprintf-posix: fix memory leak

2009-12-19 Thread Joel E. Denny
Hi Bruno, On Sat, 19 Dec 2009, Bruno Haible wrote: > On 2009-12-15, we fixed a memory leak in the fprintf replacement. Since it > is quite important to not reintroduce this bug in the future, I'm adding a > unit test against it. Thanks for taking care of all this. Sorry for my slow response.

Re: [PATCH] link-warning, arg-nonnull: fix Makefile.am target

2009-12-15 Thread Joel E. Denny
On Tue, 15 Dec 2009, Joel E. Denny wrote: > Recent gnulib changes break the build of Bison's master branch, where we > have a single top-level Makefile.am that includes local.mk from each > subdirectory. There's no problem on Bison's branch-2.5, where we still >

[PATCH] link-warning, arg-nonnull: fix Makefile.am target

2009-12-15 Thread Joel E. Denny
hy, without this patch, unistd.h is rewritten to lib/unistd.h in its target rule in Makefile.in but the same does not happen for link-warning.h. What performs this rewrite? >From fd846e35bc0584a4712b4076ccb3f253f9b7834b Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Tue, 15 Dec 200

[PATCH] fprintf-posix: fix memory leak

2009-12-14 Thread Joel E. Denny
Ok to push this? Sorry, I haven't yet explored how valgrind tests are supposed to be added to gnulib. >From 165ffc9aaa9bfe41a9977a80edf80e830d765ab9 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Tue, 15 Dec 2009 02:43:07 -0500 Subject: [PATCH] fprintf-posix: fix memory lea

Re: gnulib and *printf

2009-10-11 Thread Joel E. Denny
On Sun, 11 Oct 2009, Bruno Haible wrote: > > I use snprintf like this: > > > > field_width = snprintf (NULL, 0, " %d", max_value); > > > > Later I use field_width for a "%*d" conversion on all rows of the table. > > I don't have much experience with mbswidth, but I don't think it can be > >

Re: gnulib and *printf

2009-10-11 Thread Joel E. Denny
Hi Bruno. Thanks for your response. On Fri, 9 Oct 2009, Bruno Haible wrote: > > In another case, I'm computing a column width for a table to be formatted > > to a stream. > > Note that snprintf is not suitable for this purpose, because as soon as > non-ASCII characters appear (in a UTF-8 locale

Re: gnulib and *printf

2009-10-07 Thread Joel E. Denny
sure how to fill out some of the fields. >From 351599f18e824e4cdc883156f080becc64ffeb41 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Thu, 8 Oct 2009 00:18:25 -0400 Subject: [PATCH] all-printf, all-printf-posix: new modules. * modules/all-printf: New module

gnulib and *printf

2009-10-07 Thread Joel E. Denny
Hi. I have a couple of questions about gnulib's support for the printf family. 1. Is the snprintf-posix module helpful in order to use the following portably? length = snprintf (NULL, 0, format, args); str = malloc (length + 1); snprintf (str, length + 1, format, args); The snprintf man

Re: quotearg: implement custom_quoting_style

2009-08-23 Thread Joel E. Denny
On Mon, 24 Aug 2009, Bruno Haible wrote: > > Thanks. I had never used "git rebase -i" before. At the squash step, it > > let me merge the git log entries but not the ChangeLog entries. Is there > > a way to do that? > > Yes: After the rebase is done, edit the ChangeLog, and record that chang

Re: quotearg: implement custom_quoting_style

2009-08-23 Thread Joel E. Denny
do that? For now, I stuck with what I know: git branch tmp git reset --hard HEAD^^ git reset --soft HEAD^ git cherry-pick -n tmp # Merge ChangeLog entries. git commit -a git cherry-pick tmp^ I pushed the result, shown below. >From 3293597efd0255a347b8a71890f08f605ef267b4 Mon Sep 17

Re: quotearg: implement custom_quoting_style

2009-08-23 Thread Joel E. Denny
On Sun, 23 Aug 2009, Joel E. Denny wrote: > On Sun, 23 Aug 2009, Bruno Haible wrote: > > - Can you please avoid 1-letter identifiers as function parameters? > > 'l' and 'r', in particular. At the first glance, I thought it would > > be possib

Re: quotearg: implement custom_quoting_style

2009-08-23 Thread Joel E. Denny
On Sun, 23 Aug 2009, Bruno Haible wrote: > Hi Joel, Hi Bruno. > > +2009-08-22 Joel E. Denny > > + > > + quotearg-tests: test escaping of embedded locale quotes > > + * tests/test-quotearg.c (struct result_strings): Add member for > > + new input. >

quotearg: implement custom_quoting_style

2009-08-22 Thread Joel E. Denny
rward to overcome this limitation, but I'm not sure anyone would benefit, so I didn't bother. I just documented it. >From f81fc0cf92afa6a6b3f7a87bc898b344fb73c6a8 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Sat, 22 Aug 2009 17:55:15 -0400 Subject: [PATCH] quotearg-tests: test escaping of embedded loc

Re: update-copyright local hook

2009-08-17 Thread Joel E. Denny
e .x-update-copyright, is to inline the bulk of the VC_LIST_EXCEPT > macro directly in the update-copyright rule but without the ChangeLog > exception. What about the following patch? >From f72a12d221101f03b43d7be227fcf7550d0ba0d3 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Mon, 17 Au

Re: copyright years: mass-update every January 1

2009-08-14 Thread Joel E. Denny
't know how to configure update-copyright permanently for a project. The following patch gives me a way. >From cf17e05d931eb3e7d995650eb01c354533c61886 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Fri, 14 Aug 2009 15:26:20 -0400 Subject: [PATCH] maint.mk: support update-copyright-env *

Re: copyright years: mass-update every January 1

2009-08-14 Thread Joel E. Denny
On Fri, 14 Aug 2009, Jim Meyering wrote: > > Below are some patches to implement that. > ... > > +2009-08-14 Joel E. Denny > > + > > + update-copyright: convert 2-digit to 4-digit years > > + * build-aux/update-copyright: Implement and document. > &g

Re: copyright years: mass-update every January 1

2009-08-13 Thread Joel E. Denny
nd more importantly, we should also fix the tool to allow longhand years > for maintainers that want longhand). Below are some patches to implement that. >From 75dd6c0c64ee03ebb4eb7b0b14cf8905b9ad65ad Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Thu, 13 Aug 2009 22:40:34 -0400 Subjec

Re: update-copyright local hook

2009-08-06 Thread Joel E. Denny
ches. I'm not sure where ties between modules and maint.mk should be documented, but the stale advice in update-copyright ought to updated. Here's a patch. >From 443d6ead2f277fe0bdb1adf137a3e5c9de8a62bf Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Thu, 6 Aug 2009 10:22

Re: update-copyright local hook

2009-08-06 Thread Joel E. Denny
On Thu, 6 Aug 2009, Jim Meyering wrote: > Joel E. Denny wrote: > > For Bison, update-copyright is not enough. Our backend skeletons contain > > m4 macro invocations with lists of copyright years as arguments. I've a > > written a script and a makefile target to hand

update-copyright local hook

2009-08-05 Thread Joel E. Denny
For Bison, update-copyright is not enough. Our backend skeletons contain m4 macro invocations with lists of copyright years as arguments. I've a written a script and a makefile target to handle these, but I would like it to be called by maint.mk's update-copyright target rule so we don't forg

Re: updating copyright years

2009-08-05 Thread Joel E. Denny
it's very common to have /* or just * preceding the > copyright line ... Here's a patch that offers some support for C-style comments. >From 071e76b3e8d7890f8c62881539153c0bdcb2487a Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Wed, 5 Aug 2009 23:30:14 -0400 Subject: [PATCH] update-copy

Re: updating copyright years

2009-08-05 Thread Joel E. Denny
long as Copyright is the first word on the line, and it's followed by > at least one four-digit number, a false positive doesn't seem likely to > me. But what do I know. After the recent cleanup in update-copyright, it should be safe. >From 909fbf122f97e02687e77814e5ebfb38e063f

[PATCH] update-copyright: don't trip on non-FSF copyright statements

2009-08-05 Thread Joel E. Denny
(-) diff --git a/ChangeLog b/ChangeLog index 225df2e..b0cb2cf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,15 @@ 2009-08-05 Joel E. Denny + update-copyright: clean up code a little + * build-aux/update-copyright: Append "_re" to the name of any + variable holding a

Re: updating copyright years

2009-08-05 Thread Joel E. Denny
o output > and having a 0 status should be a sufficient filter. Thanks. Here's a revised version. >From 9df97231a6824ab608751e61b05c36279719a21a Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Wed, 5 Aug 2009 10:03:10 -0400 Subject: [PATCH] update-copyright-tests: improve portability * tes

Re: updating copyright years

2009-08-05 Thread Joel E. Denny
On Tue, 4 Aug 2009, Joel E. Denny wrote: > > [BTW, it'd be good to use a "compare" function as defined in > > test-vc-list-files-cvs.sh, in case diff is not available or > > does not honor the -u option. ] > > Ok. The following patch implements tha

Re: ChangeLog patches

2009-08-04 Thread Joel E. Denny
On Tue, 4 Aug 2009, Bruno Haible wrote: > > > The only change I made was to move your new ChangeLog to the > > > beginning of the file. > > > > Hmm. Sorry. Not sure how that happened. > > It should not happen if you are using the 'git-merge-changelog' driver > (see installation instructions in

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
On Tue, 4 Aug 2009, Karl Berry wrote: > > Given that (IIRC) "(C)" has no legal meaning, isn't this ("Copyright" > with no > > "(C)") the preferred form? > > It's recommended by the GNU coding standards and GNU maintainers > documentation. > > The (C) is neither recommended nor

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
On Tue, 4 Aug 2009, Jim Meyering wrote: > > diff --git a/ChangeLog b/ChangeLog > > index ba72930..9591fdb 100644 > > --- a/ChangeLog > > +++ b/ChangeLog > > @@ -23,6 +23,12 @@ > > > > 2009-08-03 Joel E. Denny > > > > + update-copyright:

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
On Tue, 4 Aug 2009, Matthew Woehlke wrote: > Joel E. Denny wrote: > > I just ran update-copyright on gnulib. It warns about a long list of files. > > There are various problems: > > > > 2. No "(C)" after "Copyright". > > Given that (IIR

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
im Meyering > Date: Tue, 4 Aug 2009 16:25:12 +0200 > Subject: [PATCH] update-copyright-tests: correctly test EOL=\r\n handling > > * tests/test-update-copyright.sh: Put \r at the end of some lines > for the dos-eol tests. Based on a patch by Joel E. Denny. That one works for me. Thanks.

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
On Tue, 4 Aug 2009, Jim Meyering wrote: > > From f7aecbdf27eea1a0a6eb0960dbb34627ff56ccb6 Mon Sep 17 00:00:00 2001 > > From: Joel E. Denny > > Date: Tue, 4 Aug 2009 09:37:54 -0400 > > Subject: [PATCH] update-copyright-tests: correctly test EOL=\r\n handling >

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
On Mon, 3 Aug 2009, Joel E. Denny wrote: > I just ran update-copyright on gnulib. It warns about a long list of > files. There are various problems: > > 1. "@copyright{}" or "©" instead of "(C)". > In my opinion, update-copyright should be

Re: updating copyright years

2009-08-04 Thread Joel E. Denny
them back.From f7aecbdf27eea1a0a6eb0960dbb34627ff56ccb6 Mon Sep 17 00:00:00 2001 From: Joel E. Denny Date: Tue, 4 Aug 2009 09:37:54 -0400 Subject: [PATCH] update-copyright-tests: correctly test EOL=\r\n handling * tests/test-update-copyright.sh: Add back the \r on each line, and add a comment saying i

Re: updating copyright years

2009-08-03 Thread Joel E. Denny
On Mon, 3 Aug 2009, Joel E. Denny wrote: > > Also, I posted some major changes to update-copyright here: > > > > http://lists.gnu.org/archive/html/bug-gnulib/2009-07/msg00135.html > > I found a bug in that code, which the following

Re: update-copyright make rule?

2009-08-03 Thread Joel E. Denny
On Mon, 3 Aug 2009, Simon Josefsson wrote: > # You may wish to place a target like the following in your top-level > # makefile in your project: > # > # .PHONY: update-copyright > # update-copyright: > # if test -d .git; then \ > # git grep -l -w

Re: updating copyright years

2009-08-03 Thread Joel E. Denny
On Sat, 1 Aug 2009, Joel E. Denny wrote: > > No objection on principle, from me. The 'update-copyright' module > > works fine for me in most cases. But it has no testsuite, therefore it > > may surprise us. > > My test suite has mostly been coreutils and biso

Re: updating copyright years

2009-08-01 Thread Joel E. Denny
Hi Bruno. On Sat, 1 Aug 2009, Bruno Haible wrote: > > Would anyone object to my mass-updating all > > FSF-copyright year lists in gnulib to include 2009? > > (of course, I'd exclude files that are still > > in sync with originals elsewhere) > > No objection on principle, from me. The 'update-cop

Re: new module: update-copyright [Re: copyright years: mass-update every January 1

2009-07-31 Thread Joel E. Denny
On Thu, 30 Jul 2009, Joel E. Denny wrote: > On Thu, 30 Jul 2009, Jim Meyering wrote: > > There remains at least one infelicity: if someone discusses > > the Copyright (C) notation (e.g., as on this line), and later > > has the copyright-with-dates line, the prefixes may no

Re: new module: update-copyright [Re: copyright years: mass-update every January 1

2009-07-30 Thread Joel E. Denny
On Thu, 30 Jul 2009, Jim Meyering wrote: > Thank you! Thank you. :) > Here's an incremental change I'm about to fold into yours. > It changes "comment" to "prefix" and adjusts syntax. Makes sense. > There remains at least one infelicity: if someone discusses > the Copyright (C) notation (e.g.

Re: new module: update-copyright [Re: copyright years: mass-update every January 1

2009-07-29 Thread Joel E. Denny
On Wed, 29 Jul 2009, Jim Meyering wrote: > Joel E. Denny wrote: > > > On Wed, 29 Jul 2009, Jim Meyering wrote: > > > >> Joel E. Denny wrote: > > > >> > I'd like to use this in Bison. Would you consider contributing > >> > buil

Re: [PATCH] Accept Bison's NEWS format.

2008-11-05 Thread Joel E. Denny
On Wed, 5 Nov 2008, Paolo Bonzini wrote: > Joel E. Denny wrote: > > On Tue, 4 Nov 2008, Paolo Bonzini wrote: > > > >>> - my $re_prefix = qr/\* (?:Noteworthy|Major) change/; > >>> + my $re_prefix = qr/\* (?:Noteworthy|Major) change|Changes/; > >>

Re: [PATCH] Accept Bison's NEWS format.

2008-11-04 Thread Joel E. Denny
On Tue, 4 Nov 2008, Jim Meyering wrote: > In addition to this, you might want to adjust Bison's NEWS format. > Adding one more level of "*" will make it so that it can be navigated > via emacs' outline mode. I.e., you can make it so that each "* Changes > ..." line is a major heading, and where c

Re: [PATCH] Accept Bison's NEWS format.

2008-11-04 Thread Joel E. Denny
On Tue, 4 Nov 2008, Paolo Bonzini wrote: > > - my $re_prefix = qr/\* (?:Noteworthy|Major) change/; > > + my $re_prefix = qr/\* (?:Noteworthy|Major) change|Changes/; > > What about > qr/(?:\* )?(?:Noteworthy c|Major c|C)(?i:hanges)/ I assume the trailing "s" isn't important. Anything that work

[PATCH] Accept Bison's NEWS format.

2008-11-02 Thread Joel E. Denny
announce-gen doesn't like Bison's NEWS format. The following patch fixes it. Or should we consider reformatting Bison's NEWS file? Thanks. >From f289ed88ea6513e18709b6b65ea3875bbd375998 Mon Sep 17 00:00:00 2001 From: Joel E. Denny <[EMAIL PROTECTED]> Date: Sun, 2

Re: GNUmakefile: git-version-gen, maintainer-check, install

2008-08-26 Thread Joel E. Denny
On Sat, 9 Aug 2008, Joel E. Denny wrote: > Also, I noticed that the stale version warning for make install always > scrolls out of the terminal window. I never notice it unless I'm looking > for it, so it's not doing me much good. Is there any way to print it > la

Re: GNUmakefile: git-version-gen, maintainer-check, install

2008-08-26 Thread Joel E. Denny
On Sat, 9 Aug 2008, Joel E. Denny wrote: > I frequently run make maintainer-check during Bison development. I don't > see a need to update VERSION every time. Is the following patch > acceptable, or would it be better to rename maintainer-check* to something > else in Biso

GNUmakefile: git-version-gen, maintainer-check, install

2008-08-09 Thread Joel E. Denny
Hi, I frequently run make maintainer-check during Bison development. I don't see a need to update VERSION every time. Is the following patch acceptable, or would it be better to rename maintainer-check* to something else in Bison? --- ../../gnulib/top/GNUmakefile2008-08-06 18:31:57.0

Re: --anchor-vc-ignore

2008-08-02 Thread Joel E. Denny
On Sat, 2 Aug 2008, Bruno Haible wrote: > * gnulib-tool (func_import): When updating or creating a .gitignore > file, prepend each added line with a slash, and ignore leading slashes > from the existing lines. Thanks Bruno. It works for me.

Re: [PATCH] Fix dependence on computed configure variables.

2008-08-02 Thread Joel E. Denny
On Sun, 27 Jul 2008, Joel E. Denny wrote: > Maybe the top-level Makefile.am should declare .version to depend on > configure so they don't get out of sync. I'm considering pushing the following patch to Bison. I'll wait a little for comments because this area seems a litt

--anchor-vc-ignore

2008-08-01 Thread Joel E. Denny
Hi, Would you consider adding a --anchor-vc-ignore option to gnulib-tool? This option would tell gnulib-tool to precede every .gitignore entry it creates with "/" so that, as with .cvsignore, the entry would not apply recursively to subdirectories. In Bison, we're anchoring all .gitignore en

Re: [PATCH] Fix dependence on computed configure variables.

2008-07-27 Thread Joel E. Denny
On Sun, 27 Jul 2008, Eric Blake wrote: > The better way to handle this is to replace any previous dependence on > configure.ac with a dependence on .version rather than configure; this is > already documented in git-version-gen. For an example, that is how > autoconf does it in man/Makefile.am.

Re: inttypes.h error for Bison

2007-07-02 Thread Joel E. Denny
ion 1.1707 diff -p -u -r1.1707 ChangeLog --- ChangeLog 2 Jul 2007 02:07:19 - 1.1707 +++ ChangeLog 3 Jul 2007 02:46:44 - @@ -1,3 +1,13 @@ +2007-07-02 Joel E. Denny <[EMAIL PROTECTED]> + + Fix C++ test cases after recent Gnulib changes. Discussed starting at +

Re: inttypes.h error for Bison

2007-07-02 Thread Joel E. Denny
On Mon, 2 Jul 2007, Bruno Haible wrote: > But even with your patch, and even with the addition of this code to > config.h, Joel's test case still fails. Sorry if I'm beating a dead horse, but the patch I had in mind does work for me. I put __STDC_LIMIT_MACROS in the stdint.h wrapper: Index: gn

Re: inttypes.h error for Bison

2007-07-01 Thread Joel E. Denny
On Mon, 2 Jul 2007, Bruno Haible wrote: > The problem is that gnulib's > inttypes_.h heavily relies on the INT*_MAX, INT*_MIN, UINT*_MAX macros > from , but does not define these macros in C++ mode if > __STDC_LIMIT_MACROS is not defined. > > It is not clear to me how we can fix this. In the mea

Re: inttypes.h error for Bison

2007-07-01 Thread Joel E. Denny
On Mon, 2 Jul 2007, Bruno Haible wrote: > OK, then can you please - as always in a bug report - tell how to > reproduce the problem? > - Which platform? > - Which version of gcc? You must have missed the first message in this thread: http://lists.gnu.org/archive/html/bug-gnulib/2007-07/msg

Re: inttypes.h error for Bison

2007-07-01 Thread Joel E. Denny
On Mon, 2 Jul 2007, Bruno Haible wrote: > Joel E. Denny wrote: > > Using the same compiler options as for building Bison: > > > > --- > > % gcc -std=gnu99 -I. -I. -I../lib -I../lib \ > > -Wall -Wextra -Wno-sign-compare -Wcast-align -Wc

Re: inttypes.h error for Bison

2007-07-01 Thread Joel E. Denny
On Sun, 1 Jul 2007, James Youngman wrote: > Thanks for the detailed bug report; what are the values of these C > proprocessor macros on your system when you use the same set of > compiler options as you were using to build Bison? > > INT_MIN > INT_MAX > INT32_MIN > INT32_MAX I created tmp.c: --

inttypes.h error for Bison

2007-07-01 Thread Joel E. Denny
I get this error for C++ test cases in Bison from CVS: --- In file included from /home/jdenny/bison/lib/stdint.h:71, from /usr/local/lib/gcc/i686-pc-linux-gnu/4.1.0/../../../../include/c++/4.1.0/bits/postypes.h:49, from /usr/local

Re: javacomp.m4 usage [Fwd: Re: Java-related Bison tests all fail]

2007-02-11 Thread Joel E. Denny
On Sun, 11 Feb 2007, Paolo Bonzini wrote: > > > With Bruno's recent Gnulib patch (working around the old tr bug), the above > > fixes Java support in Bison for me. Paolo, is this fine with you? > > Sure it is. Thanks. Committed.

Re: javacomp.m4 usage [Fwd: Re: Java-related Bison tests all fail]

2007-02-11 Thread Joel E. Denny
On Sat, 10 Feb 2007, Bruno Haible wrote: > 2007-02-10 Bruno Haible <[EMAIL PROTECTED]> > > Enable the Java related testsuite tests when the only Java compiler > found is a gcj < 4.3. > * configure.ac (gt_JAVACOMP): Don't specify a target_version. > > --- configure.ac2

Re: Java-related Bison tests all fail

2007-02-11 Thread Joel E. Denny
On Sun, 11 Feb 2007, Bruno Haible wrote: > Joel E. Denny wrote: > > I am able to reproduce the problem with coreutils 5.2.1 on both an x86 > > Linux and an x86 Solaris. I've attached the erroneous output. > > > > The trouble is the last tr. The following

Re: lib/gettext.h breaks --enable-gcc-warnings

2006-11-09 Thread Joel E. Denny
extdomain) [! ENABLE_NLS]: > (bind_textdomain_codeset) [! ENABLE_NLS]: > Evaluate all the arguments. That way, callers get compatible > behavior if the arguments have side effects. Also, it avoids > some GCC diagnostics in some cases; Joel E. Denny repo

Re: Valgrind and Bison memory leaks

2006-11-08 Thread Joel E. Denny
On Wed, 8 Nov 2006, Paul Eggert wrote: > "Joel E. Denny" <[EMAIL PROTECTED]> writes: > > > Most importantly, the end of the patch includes a small change to > > lib/quotearg.*, which I see are part of gnulib. I'll need some guidance > > on whether