Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-03-18 Thread Grégoire Sutre
Eric Blake wrote: On 03/17/2010 06:58 PM, Grégoire Sutre wrote: Just out of curiosity: is there a reason for this behavior of AC_CHECK_DECLS, which, quoting the manual, is unlike the other ‘AC_CHECK_*S’ macros? Yes - it looks cleaner to write code like: if (CONDITION) do_something

Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-03-17 Thread Grégoire Sutre
Eric Blake wrote: Then you contrast it with AC_CHECK_DECL, which defines HAVE_FUNC_DECL to either 0 or 1, but always defines it. If you use #ifdef in those situations, you lose (you typed 3 more bytes, and you get the wrong result). Ok. Just out of curiosity: is there a reason for this beh

Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-03-17 Thread Grégoire Sutre
Hi Eric, > AC_CHECK_FUNCS leaves HAVE_FUNC undefined if it is missing, but defines > HAVE_FUNC to 1 if it is present. It is much easier to write: > > #if HAVE_FUNC In that case you only need to write: #ifdef HAVE_FUNC which is just as simple, and is compliant with -Wundef. Moreover, the docu

Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-03-16 Thread Grégoire Sutre
n #if directives. In fact, any package which makes good use of Autoconf cannot support -Wundef. I don't see why. Could you please elaborate? Best regards, Grégoire Sutre [1] http://lists.gnu.org/archive/html/bug-gnulib/2010-01/msg00316.html [2] http://lists.gnu.org/archive/html/bug-gnul

[PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-01-25 Thread Grégoire Sutre
Hi, This message concerns both gnulib and grub. As discussed on irc and on the list [1], ENABLE_NLS is not used correctly, which leads to a build failure when gettext is not detected (or with configure option --disable-nls). ENABLE_NLS is defined in AM_GNU_GETTEXT and the documentation of t