Re: should asprintf and friends guarantee sane pointer on failure?

On Mon, Jul 29, 2024 at 09:58:57AM -0500, Eric Blake wrote: > On Mon, Jul 29, 2024 at 04:35:57PM GMT, Bruno Haible wrote: > > Hi Eric, > > > > I see two — mostly unrelated — topics in your mail and the referenced > > threads. > > > > 1) The coding paradigm. > > > > >The only reasonable chan

Re: license: comma or semicolon?

On Tue, Jan 04, 2022 at 12:28:34AM +0100, Bernhard Voelker wrote: > On 1/3/22 01:17, Mike Frysinger wrote: > > according to gnu.org, it should be a comma. > > https://www.gnu.org/licenses/gpl-3.0.html#howto > > The attached would change it, and shows how the change was done: > > Subject: [PATCH

Re: [PATCH] regex: fix backreference matching

On Tue, Jun 29, 2021 at 11:51:13AM +0300, Egor Ignatov wrote: > Well, then I have a few questions about matching and capturing > groups. > > 1. "ab" -> "^(a*)*(.)" > So, from your test case I can assume that: > regs[0] = (0, 2] > regs[1] = (0, 1] > regs[2] = (1, 2] > > But if we add backref at th

Re: Seeking input from developers: glibc copyright assignment policy.

On Mon, Jun 14, 2021 at 01:39:26PM -0700, Paul Eggert wrote: > A proposal to change the glibc copyright assignment policy is being > circulated on libc-alpha. The email thread starts at > , and > the text of the email seeking inp

Re: [PATCH] regex: fix match with possessive quantifier

On Mon, Jun 07, 2021 at 04:10:27AM +0300, Dmitry V. Levin wrote: > On Mon, Jun 07, 2021 at 12:45:02AM +0300, Dmitry V. Levin wrote: > > On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > > > Fix behaviour introduced in 70b673e, where regexps with > >

Re: [PATCH] regex: fix backreference matching

On Wed, Jun 16, 2021 at 12:46:15PM +0300, Egor Ignatov wrote: > This fixes a bug described in 70b673eb7. [...] > - { "^(a*)*(.)", "ab", REG_EXTENDED, 3, { { 0, 2 }, { 0, 1 }, { 1, 2 } } }, > + { "^(a*)*(.)", "ab", REG_EXTENDED, 3, { { 0, 2 }, { 1, 1 }, { 1, 2 } } }, Sorry, but how this could be

Re: warnings in unit tests

On Tue, Jun 08, 2021 at 09:42:55AM -0700, Paul Eggert wrote: > For what it's worth I'm more with Bruno on this. For the tests, the cost > of these warnings outweighs the benefit. > > It'd be OK with me to disable the troublesome warnings globally for the > tests subdirectory, using -Wno-missing-

Re: warnings in unit tests

On Tue, Jun 08, 2021 at 10:56:33AM +0200, Bruno Haible wrote: > Jim Meyering wrote: > > I can live without -Wmissing-prototypes in gnulib tests, but I still > > remember times where using that option exposed a real bug. > > -Wmissing-prototypes typically exposes real bugs when a program is compose

Re: new module 'sigsegv'

Hi, On Mon, Jun 07, 2021 at 02:49:35AM +0200, Bruno Haible wrote: [...] > > -volatile int * > > +static volatile int * > > recurse_1 (int n, volatile int *p) > > { > >if (n < INT_MAX) > > @@ -80,7 +80,7 @@ recurse_1 (int n, volatile int *p) > >return p; > > } > > > > -int > > +static

Re: new module 'sigsegv'

On Sun, May 16, 2021 at 07:01:45PM +0200, Bruno Haible wrote: [...] > To fix this problem, I'm adding a module 'sigsegv'. I've tried to rebuild the latest GNU grep with the latest gnulib and got a few build issues: sigsegv.c: In function 'sigsegv_handler': sigsegv.c:1059:36: error: declaration of

Re: [PATCH] regex: fix match with possessive quantifier

On Mon, Jun 07, 2021 at 12:45:02AM +0300, Dmitry V. Levin wrote: > On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > > Fix behaviour introduced in 70b673e, where regexps with > > possessive quantifier("*+") didn't match. > > * lib/regexec.c > &g

Re: [PATCH] regex: fix match with possessive quantifier

On Wed, May 26, 2021 at 12:08:19PM +0300, Egor Ignatov wrote: > Fix behaviour introduced in 70b673e, where regexps with > possessive quantifier("*+") didn't match. > * lib/regexec.c > (set_regs): Pop if CUR_NODE has already been checked only when > we have a fail stack. > > Signed-off-by: Egor Ign

Re: Probably bug in lib/regexec.c with possessive quantifier

Hi, On Tue, May 25, 2021 at 12:33:06PM +0300, Egor Ignatov wrote: > Hi, > > So, after updating gnulib, some test cases in > augeas(https://github.com/hercules-team/augeas) related to regex started > to fail. > I found a commit in gnulib that introduced this behavior: > > 70b673eb768eb7288639cb

Re: current gnulib regex breaks in gawk

On Sat, Apr 17, 2021 at 01:43:58PM -0600, arn...@skeeve.com wrote: > "Dmitry V. Levin" wrote: > > > I've just tried to build the latest commit gawk-5.1.0-260-gde598391 from > > gawk-5.1-stable branch. Unfortunately, the result executable uses a > > priva

Re: current gnulib regex breaks in gawk

Hi Arnold, On Sun, Feb 07, 2021 at 11:36:29PM -0700, arn...@skeeve.com wrote: > arn...@skeeve.com wrote: > > > I still have to have the following change, otherwise I get a linkage > > error on the gl_dyanarray_* routines. :-( > > > > So, at least for the nonce, my copy and Gnulib's will be out of

Re: [PATCH 07/10] regex: fix longstanding backref match bug

On Fri, Feb 05, 2021 at 05:25:59PM -0800, Paul Eggert wrote: > This fixes a longstanding glibc bug concerning backreferences > (2009-12-04). Nit: this short URL doesn't work, while the longer one does: https://sourceware.org/bugzilla/show_bug.cgi?id=11053 > * lib/re

Re: [PATCH] tests: fix test-execute with GNU make jobserver

On Thu, Apr 08, 2021 at 01:44:35AM +0200, Bruno Haible wrote: [...] > I'm applying this fix: > > > 2021-04-07 Bruno Haible > > execute tests: Avoid test failure in certain environments. > Reported by Dmitry V. Levin in > <https://lists.gnu.

Re: [PATCH] tests: fix test-execute with GNU make jobserver

Hi Bruno, On Wed, Apr 07, 2021 at 11:30:47PM +0200, Bruno Haible wrote: > Hi Dmitry, > > Thanks for the proposed patch. > > > On POSIX systems the GNU make jobserver is implemented as a pipe, > > and these two unexpected descriptors make test-execute-child fail. > > This problem description is

[PATCH] tests: fix test-execute with GNU make jobserver

@@ +2021-04-07 Dmitry V. Levin + + tests: fix test-execute with GNU make jobserver. + * tests/test-execute-main.c (cloexec_fds): New function. + (main): Use it. + 2021-04-06 Paul Eggert group-member: minor tweak to omit a * diff --git a/tests/test-execute-main.c b

Re: removing permissions for long unused accounts?

Hi, On Tue, Feb 23, 2021 at 01:19:42AM +0100, Bruno Haible wrote: > Hi Paul, > > > Also, by "active" do we mean "authored a patch", "committed a patch", or > > "pushed a commit to Savannah"? I assume pushing is what counts. Dunno if > > that's easily measured, though. > > Pushing is what count

Re: Hidden files in autoconf 2.70 distribution?

On Wed, Dec 09, 2020 at 04:06:20PM -0800, Jim Meyering wrote: > On Wed, Dec 9, 2020 at 3:49 PM Paul Eggert wrote: > > On 12/9/20 7:46 AM, Bruno Haible wrote: > > > It comes from Gnulib's git-version-gen and GNUmakefile. > > > > > > I'm not defending it. In fact, it annoys me. But I didn't spend the

Re: [PATCH] Update savannah URLs of gnulib.git files

Hi Bruno, On Sat, Nov 21, 2020 at 03:18:15PM +0100, Bruno Haible wrote: > Hi Dmitry, > > > * MODULES.html.sh: Prefer cgit URLs over gitweb. > > I don't think this is a good idea. > > For a particular file, the result of both wget commands is the same. I vaguely remember we had different points

[PATCH] Update savannah URLs of gnulib.git files

MODULES.html.sh | 2 +- doc/gnulib.texi | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 64be77149..2e7744c2b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2020-11-20 Dmitry V. Levin + + Update savannah URLs

[PATCH] git-version-gen: update scriptversion

scriptversion in git-version-gen should be kept up-to-date because this script is used by projects that update it from gnulib when its scriptversion changes. * build-aux/git-version-gen (scriptversion): Update. Fixes: 8f41f1918 ("git-version-gen: Allow 'snapshot' as .tarball-version contents.")

Re: git-version-gen: allow 'snapshot' as .tarball-version contents

Hi, On Sun, Oct 13, 2019 at 06:30:47PM +0200, Bruno Haible wrote: > Hi, > > git-version-gen currently rejects some forms of .tarball-version: > > $ cat > .tarball-version > 20191011 > $ build-aux/git-version-gen .tarball-version; echo > 20191011 > $ cat > .tarball-version > snapshot > $ build-au

Re: git-version-gen: add support for empty release commits

Hi, On Sat, May 11, 2019 at 12:31:16AM +0200, Bruno Haible wrote: > Hi, > > I'm using git-version-gen in GNU gettext. For the 0.20 release, I > created an empty commit, like this: > > CURRENT_VERSION=0.20 > git commit --allow-empty -m "Release $CURRENT_VERSION" > git tag v$CURRENT_VE

Re: test-rwlock1 failing on latest Fedora Rawhide

On Wed, Jan 23, 2019 at 10:24:26PM +, Richard W.M. Jones wrote: > On Thu, Jan 24, 2019 at 01:09:52AM +0300, Dmitry V. Levin wrote: > > On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > > > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin

Re: test-rwlock1 failing on latest Fedora Rawhide

On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > Hi, > > > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > > On Wed, Jan 23, 2019 at 09:01:

Re: test-rwlock1 failing on latest Fedora Rawhide

Hi, On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: [...] > I checked the history of the Fedora package which adds these flags, and > it seems like --as-needed was added for: > > https://fedoraproject.org/wiki/Cha

Re: Fix more typos

On Sat, Jan 12, 2019 at 12:00:47PM +0100, Tim Rühsen wrote: > Used a spell checker (codespell) to wipe out several typos. [...] > diff --git a/build-aux/texinfo.tex b/build-aux/texinfo.tex > index 48d532bc6..74bea4134 100644 > --- a/build-aux/texinfo.tex > +++ b/build-aux/texinfo.tex > @@ -4688,7 +

Re: [RFC PATCH] test-c-stack2.sh: skip if the platform sent SIGILL on an invalid address.

On Sat, Dec 29, 2018 at 06:03:42PM +0300, Ivan Zakharyaschev wrote: [...] > BTW, saving and forgetting the type of the original fault doesn't seem > to be something expensive to implement (after some thought): when a > register is marked as invalid, it shouldn't matter anymore what value > it holds

Re: [RFC PATCH] test-c-stack2.sh: skip if the platform sent SIGILL on an invalid address.

On Sat, Dec 29, 2018 at 02:31:11PM +0300, Andrey Savchenko wrote: > On Sat, 29 Dec 2018 12:17:32 +0100 Bruno Haible wrote: > > > As for the SIGILL peculiarity, it has a reason in the Elbrus > > > architecture. > > > ... > > > And it's not a segmentation fault. > > > > I believe you should make i

Re: [RFC PATCH] test-c-stack2.sh: skip if the platform sent SIGILL on an invalid address.

On Fri, Dec 28, 2018 at 05:23:09PM +0300, Ivan Zakharyaschev wrote: > Hi Bruno, > > On Thu, 20 Dec 2018, Bruno Haible wrote: > > > > +# E2K (elbrus) systems send SIGILL on an access to an invalid > > > address. > > > > This is a bug in the system. Access of an invalid address ought to produ

Re: [PATCH v2 1/4] sha1sum: use AF_ALG when available

On Wed, Apr 25, 2018 at 01:26:08PM +0200, Matteo Croce wrote: [...] > +#include > + > +#include > + > +#ifdef AF_ALG > + > +#include > +#include > +#include > +#include > +#include > + > +#include "af_alg.h" > + > +/* from linux/include/linux/fs.h: (INT_MAX & PAGE_MASK) */ > +#define MAX_RW_

Re: [PATCH 0/4] Use AF_ALG in checksum utilities

On Tue, Apr 24, 2018 at 03:28:51PM +0200, Bruno Haible wrote: > Hi Matteo, > > > > * As you already noticed, we need to avoid build failures and runtime > > > failures > > > on platforms where this is not supported. > > > > > > > I see "#ifdef __linux__" already in use in gnulibs, I assume

Re: [PATCH] users.txt: convert savannah gitweb links to cgit

Hi Bruno, On Mon, Mar 27, 2017 at 12:53:03AM +0200, Bruno Haible wrote: > Hi Dmitry, > > > Also, convert git.sv.gnu.org cgit links to use git.savannah.gnu.org > > as the former redirects to the latter. > > Replace gitweb links with cgit links? Nah. Some users (including me) > prefer gitweb over

[PATCH] users.txt: convert savannah gitweb links to cgit

Also, convert git.sv.gnu.org cgit links to use git.savannah.gnu.org as the former redirects to the latter. The conversion is made automatically by the following sed expression: sed -ri \ -e 's#(https://git)\.(sv|savannah)\.(gnu\.org)/gitweb/\?p=([^.]+\.git)(;.*)?$#\1.savannah.\3/cgit/\4#' \

Re: [PATCH] users.txt: add grub link

Hi, On Thu, Mar 23, 2017 at 07:20:41PM +0300, Andrei Borzenkov wrote: > --- a/users.txt > +++ b/users.txt > @@ -29,6 +29,7 @@ The following packages appear to be using gnulib and > gnulib-tool: >https://gitlab.com/gnutls/gnutls.git >gpg https://gnupg.org/ >

Re: [PATCH] mountlist/ptsname_r: leverage AC_HEADER_MAJOR

On Sat, Apr 16, 2016 at 01:20:32PM +0100, Pádraig Brady wrote: > On 16/04/16 11:51, Bruno Haible wrote: > >Hi Mike, > > > >>These two modules use makedev/major/minor but don't have explicit > >>checks for the functions. Use the existing autoconf macro which > >>will probe some headers for use and

Re: [PATCH] tests: getaddrinfo: skip if no network

On Sat, Mar 08, 2014 at 10:15:52PM +0200, Alon Bar-Lev wrote: > When running tests under network sandbox, there is no connectivity to > the DNS, in this case function returns system error and ECONNREFUSED > this should result in skipping test. Interesting. Have you seen the thread started at http

Re: test-getaddrinfo failures in Fedora Rawhide

On Wed, Apr 24, 2013 at 01:18:52PM +0100, Pádraig Brady wrote: > On 04/23/2013 11:16 AM, Dmitry V. Levin wrote: > > On Tue, Apr 23, 2013 at 10:54:03AM +0100, Pádraig Brady wrote: > >> I'm still thinking the gnulib patch should be applied though, > > > > Since t

Re: test-getaddrinfo failures in Fedora Rawhide

On Tue, Apr 23, 2013 at 10:54:03AM +0100, Pádraig Brady wrote: > On 04/23/2013 10:44 AM, Dmitry V. Levin wrote: > > On Tue, Apr 23, 2013 at 10:11:46AM +0100, Pádraig Brady wrote: > >> On 04/23/2013 08:32 AM, Richard W.M. Jones wrote: > >>> > >>> Not look

Re: test-getaddrinfo failures in Fedora Rawhide

On Tue, Apr 23, 2013 at 10:11:46AM +0100, Pádraig Brady wrote: > On 04/23/2013 08:32 AM, Richard W.M. Jones wrote: > > > > Not looked into this in any detail yet, but just a note that the > > getaddrinfo test is now failing in Fedora Rawhide. This failure > > started to happen within the last wee

Re: [PATCH] regex-tests, regex: allow glibc re_search behavior

On Thu, Apr 11, 2013 at 09:42:29AM -0700, Paul Eggert wrote: > Thanks, can you please install that? I've added you to > the gnulib group. Done. -- ldv pgpf7z2DNU77C.pgp Description: PGP signature

[PATCH] regex-tests, regex: allow glibc re_search behavior

.m4| 23 +-- tests/test-regex.c | 23 +-- 3 files changed, 42 insertions(+), 12 deletions(-) diff --git a/ChangeLog b/ChangeLog index 348e091..f49e881 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2013-04-11 Dmitry V. Levin + + reg

Re: [PATCH 2/2] regex: test for buffer overrun

On Wed, Apr 10, 2013 at 10:07:09PM -0700, Paul Eggert wrote: > On 04/10/2013 09:48 PM, Dmitry V. Levin wrote: > > I think gnulib's tests/test-regex.c should allow glibc's re_search() > > behavior so that various utilities built --without-included-regex > > woul

Re: [PATCH 2/2] regex: test for buffer overrun

On Sun, Mar 31, 2013 at 04:11:41PM +0100, Nix wrote: > On 30 Jan 2013, Paul Eggert spake thusly: > > > + /* This test is from glibc bug 15078. > > + The test case is from Andreas Schwab in > > + > > .

Re: [PATCH] fts: introduce FTS_VERBATIM

On Sun, Nov 18, 2012 at 02:05:43AM +0100, Jim Meyering wrote: > Dmitry V. Levin wrote: > > This gives clients the option to disable stripping of trailing slashes > > from input path names during fts_open initialization. > > > > The recent change v0.0-7611-g3a9002d that m

[PATCH] fts: introduce FTS_VERBATIM

e0342..f5d89c6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-11-17 Dmitry V. Levin + + fts: introduce FTS_VERBATIM + * lib/fts_.h (FTS_NOATIME): New bit flag. + (FTS_OPTIONMASK, FTS_NAMEONLY, FTS_STOP): Adjust. + * lib/fts.c (fts_open): Honor it. + 2012-11-09 Pá

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Fri, Nov 16, 2012 at 09:52:06PM +, James Youngman wrote: > Did anybody do any further work on whether it worked best to fix this > in gnulib or in findutils? As I said, my proposal is to introduce a new FTS_ flag that would make fts_open behave as before that change, and use this flag in fi

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Thu, Nov 01, 2012 at 06:22:32AM -0600, Eric Blake wrote: > On 10/31/2012 05:28 PM, Dmitry V. Levin wrote: > > On Tue, Sep 04, 2012 at 01:09:24PM +0200, Jim Meyering wrote: > > [...] > >> Here's the revised commit: > >> > >> Subject: [PATCH] fts:

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Tue, Sep 04, 2012 at 01:09:24PM +0200, Jim Meyering wrote: [...] > Here's the revised commit: > > >From 3a9002d3cc63da7110f133b1040d2d2b0aad8305 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Tue, 4 Sep 2012 11:36:38 +0200 > Subject: [PATCH] fts: reduce two or more trailing slashes to j

Re: [PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted

Ping? - Forwarded message from "Dmitry V. Levin" - Date: Sun, 24 Apr 2011 13:44:38 +0400 From: "Dmitry V. Levin" To: bug-gnulib@gnu.org Subject: [PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted GNU libc implements getloadavg(3) on Li

Re: [PATCH] gitlog-to-changelog: fix git-log invocation

On Tue, Nov 01, 2011 at 03:19:43PM +0100, Jim Meyering wrote: > Running it on coreutils, I got this, ad infinitum: > > Use of uninitialized value $line[0] in pattern match (m//) at > build-aux/gitlog-to-changelog line 163, line 34755. Ouch. > >From bc2f20935ff445f1e55b9c7f7e90cd77ef4eb007

Re: [PATCH] gitlog-to-changelog: fix git-log invocation

On Mon, Oct 31, 2011 at 05:11:28PM +0100, Jim Meyering wrote: > Dmitry V. Levin wrote: > > git-log mishandles date strings before 1970-01-01 UTC, and there is > > no use to specify --since=1970-01-01 by default anyway. > > * build-aux/gitlog-to-changelog: By default, when no -

[PATCH] gitlog-to-changelog: fix git-log invocation

build-aux/gitlog-to-changelog |9 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 76d1c64..beae627 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2011-10-31 Dmitry V. Levin + + gitlog-to-changelog: fix git-log

Re: [PATCH 0/2] gitlog-to-changelog output adjustments

On Mon, Oct 31, 2011 at 08:56:44AM +0100, Jim Meyering wrote: [...] > Here's the result. > I'll wait for an ACK from you in case there's anything > you'd like to adjust. The result is OK, thanks. -- ldv pgpl9QybPcS0I.pgp Description: PGP signature

Re: [PATCH 0/2] gitlog-to-changelog output adjustments

th the ChangeLog's leading TAB, > it might make it wrap. Indeed. Here is a second edition of the patch; it adds a new option. From 32298efaa0a9647002d372e54a9391aa89172219 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Sun, 30 Oct 2011 22:00:00 + Subject: [PATCH] gitlo

[PATCH 2/2] gitlog-to-changelog: terminate the 1st line of commit message with a dot

--git a/ChangeLog b/ChangeLog index 088d239..80862fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2011-10-29 Dmitry V. Levin + gitlog-to-changelog: terminate the 1st line of commit message with a dot. + * build-aux/gitlog-to-changelog: If the first non-blank line of a

[PATCH 1/2] gitlog-to-changelog: treat messages without non-blank lines as empty

deletions(-) diff --git a/ChangeLog b/ChangeLog index f4711dc..088d239 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-10-29 Dmitry V. Levin + + gitlog-to-changelog: treat messages without non-blank lines as empty. + * build-aux/gitlog-to-changelog: Move the code that

[PATCH 0/2] gitlog-to-changelog output adjustments

After migrating several projects from GNU-Style ChangeLogs to git with autogenerated ChangeLog files, I found a minor discrepancy in style between the old and generated ChangeLog files. The git commit message convention is that the first line of a commit message is a summary which is usually not t

[PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted

/test-getloadavg.c |2 +- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 82c8468..0569fe0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2011-04-24 Dmitry V. Levin + + getloadavg test: skip the test on GNU/Linux without /proc mounted

[PATCH] mbsstr: fix warnings reported by gcc -Wcast-align on ARM

* lib/mbsstr.c (knuth_morris_pratt_multibyte): Assign a raw memory pointer returned by nmalloca() right to the variable of type "mbchar_t *" thus removing redundant proxy variable of type "char *". Signed-off-by: Dmitry V. Levin --- The issue originally arose during build of

Re: [PATCH] Fix exit status of signal handlers in shell scripts

On Mon, Feb 01, 2010 at 08:58:19AM +0100, Jim Meyering wrote: > Bruno Haible wrote: > > Jim Meyering wrote: > >> Imagine that the first 10 tests pass, then each of the remaining ones is > >> killed via e.g., SIGHUP. ... > >> a naive search for "FAIL:" in the build output would find nothing. > > > >

Re: gnulib bootstrap and git submodules

Hi, On Mon, Feb 22, 2010 at 03:58:19PM -0700, Eric Blake wrote: [...] > Here's the next three patches I had to add on top of the previously posted > one. With this series, I was able to copy the new bootstrap to libvirt > and still get everything there to work correctly (patch to libvirt list to

Re: [PATCH] Fix exit status of signal handlers in shell scripts

On Sun, Jan 31, 2010 at 08:05:20AM +0100, Ralf Wildenhues wrote: > * Dmitry V. Levin wrote on Sat, Jan 30, 2010 at 08:12:01PM CET: > > There is a comment about shell signal handlers in gnulib-tool saying that > > "The value of $? is 128 + signal number and is set before the

Re: [PATCH] Fix exit status of signal handlers in shell scripts

On Sun, Jan 31, 2010 at 01:51:59AM +0100, Bruno Haible wrote: > Additionally, another proposed change prompted by Dmitry's patch. > > The Autoconf manual > > says: > "the state of ‘$?’ is not reliable when entering a sh

Re: [PATCH] Fix exit status of signal handlers in shell scripts

On Sun, Jan 31, 2010 at 01:41:33AM +0100, Bruno Haible wrote: [...] > TMP_BASE=update-copyright.test > -trap 'rm -f $TMP_BASE*' 0 1 2 3 15 > +trap 'status=$?; rm -f $TMP_BASE*; exit $status' 0 > +trap 'rm -f $TMP_BASE*; (exit 77); exit 77' 1 2 3 15 The signal trap is a bit redundant, it could be

Re: [PATCH] Fix exit status of signal handlers in shell scripts

On Sun, Jan 31, 2010 at 01:22:34AM +0100, Bruno Haible wrote: > Here is part 2 of the proposed fixes. [...] > -trap 'rm -fr $tmpfiles' 1 2 3 15 > +trap 'rm -fr $tmpfiles; exit 77' 1 2 3 15 According to "Limitations of Builtins" chapter in the autoconf manual, plain "exit 77" is not portable; it ha

Re: [PATCH] Fix exit status of signal handlers in shell scripts

On Sun, Jan 31, 2010 at 01:04:09AM +0100, Bruno Haible wrote: [...] > > Proposed patch is attached. > > Sorry, but I don't understand why you chose 143 as exit code, making it look > like the process died from SIGTERM when in fact in may have been SIGINT. > There seem to be two conventions for the

[PATCH] Fix exit status of signal handlers in shell scripts

#x27;trap "exit \$?" TERM; while /bin/true; do /bin/false; done' [1] 5376 [1]+ Donesh -c 'trap "exit \$?" TERM; while /bin/true; do /bin/false; done' [1] 5411 [1]+ Done sh -c 'trap "exit \$?" TERM; while /b

Re: I: coreutils tests/misc/nproc-avail fails on GNU/Linux without /proc and /sys mounted

On Sun, Jan 10, 2010 at 11:32:50AM +0100, Bruno Haible wrote: [...] > I like this workaround, but would prefer to have it in the nproc module > in gnulib. coreutils/src/nproc.c is purely the command-line program. > > Here's a proposed patch. It looks good, thank you. -- ldv pgpyzrOibAKXP.pgp

I: coreutils tests/misc/nproc-avail fails on GNU/Linux without /proc and /sys mounted

Hi, The recently introduced nproc utility outputs wrong result when run in --all mode inside a /proc-less /sys-less GNU/Linux chroot on a system with several CPUs. In this environment, "nproc --all" always outputs 1 while plain "nproc" outputs correct number of available CPUs. The underlying num_

Re: [Bug 552320] Handling AT_FDCWD as EBADF in glibc's utimens() causes tar failures

On Wed, Jan 06, 2010 at 06:20:51AM -0700, Eric Blake wrote: > According to Jim Meyering on 1/5/2010 2:07 PM: > >> --- Comment #5 from Ondrej Vasik 2010-01-05 14:29:13 > >> EDT --- > >> Ah - even the latest gnulib doesn't handle this new recent change - so > >> touch > >> from coreutils might be

Re: [PATCH] non-null declarations

Hi, On Thu, Dec 10, 2009 at 03:36:18PM +0100, Bruno Haible wrote: > > Here's a proposed patch for introducing some __nonnull__ declarations. For > a start, I'm focusing on gnulib's replacement files lib/*.in.h, because these > declare the most often used functions. Potential drawback of this app

Re: readlink(1) behavior

On Fri, Sep 18, 2009 at 02:27:32PM +0200, Jim Meyering wrote: > Eric Blake wrote: > > According to Jim Meyering on 9/18/2009 4:47 AM: > >> Assuming ln -s /nowhere dangling-symlink, > >> New behavior: > >> > >> $ ./readlink -fv dangling-symlink/ > >> /nowhere > >> > >> Previous: > >> > >>

Re: FYI: new inter-release version strings, e.g., 6.9-219-g58ddd,

On Thu, Aug 30, 2007 at 05:50:31PM +0200, Jim Meyering wrote: > For example, now when I run "make dist", rather than getting the always > identically-named coreutils-6.9+.tar.gz, I get tarballs with more > meaningful names: > > coreutils-6.9.220.gdd469.tar.gz > coreutils-6.9.223.g624d1.tar

Re: xnanosleep range with 64 bit time_t

Hi, On Thu, Aug 31, 2006 at 12:13:35AM -0700, Paul Eggert wrote: > I have installed the following patch to gnulib [...] > 2006-08-30 Paul Eggert <[EMAIL PROTECTED]> > > Work around a bug in both the Linux and SunOS 64-bit kernels: > nanosleep mishandles sleeps for longer than 2**31

Re: [Bug-tar] Error "Cannot allocate memory" incorrectly reported in some cases.

On Fri, Oct 28, 2005 at 04:07:53PM -0700, Paul Eggert wrote: > I installed this patch instead, both in gnulib and coreutils. [...] > @@ -70,7 +70,6 @@ char * > savedir (const char *dir) > { >DIR *dirp; > - struct dirent *dp; >char *name_space; >size_t allocated = NAME_SIZE_DEFAULT; >