Re: lib/malloca.c, different signs of integers; with clang and groff

The cause is an error in "Makefile.in" (lines folded): lib/libgnu_a-malloca.o: lib/malloca.c $(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(lib_libgnu_a_CFLAGS) $(CFLAGS) -MT lib/libgnu_a-malloca.o -MD -MP -MF lib/$(DEPDIR)/libgnu_a-malloca.Tpo -c -o

lib/unictype/bitmap.h, different signs of integers; with clang and groff

CC lib/uniwidth/libgnu_a-width.o In file included from ../lib/uniwidth/width.c:51: ../lib/unictype/bitmap.h:31:14: warning: comparison of integers of different signs: 'unsigned int' and 'const int' [-Wsign-compare] if (index1 < ((const int *) table)[0]) ~~ ^

lib/malloca.c, different signs of integers; with clang and groff

CC lib/libgnu_a-malloca.o ../lib/malloca.c:61:38: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'idx_t' (aka 'long') [-Wsign-compare] if (!ckd_add (&nplus, n, plus) && !xalloc_oversized (nplus, 1)) ^

lib/time.in.h, ctime has portability problems; with clang and groff

The gnulib module "ctime" declares "ctime" to be deprecated. "ctime" is not used in "groff". CC lib/libgnu_a-openat-proc.o In file included from ../lib/openat-proc.c:25: In file included from ./lib/sys/stat.h:51: ./lib/time.h:1094:18: warning: ctime has portability problems - use gnul

"mbsspn" and "mbschr" missing in some files in /lib/

While experimenting using the module "posixcheck" included in "groff" I got these warnings: N.B. Some lines are folded. CC lib/libgnu_a-chdir-long.o ../lib/chdir-long.c: In function 'chdir_long': ../lib/chdir-long.c:129:23: warning: call to 'strspn' declared with attribute warning: str

./lib/error.h:410:8: warning: ISO C forbids braced-groups within expressions [-Wpedantic]

While compiling "groff" with gcc (Debian 13.2.0-2) 13.2.0) and "-std=gnu2x": ../lib/openat-die.c: In function 'openat_save_fail': ./lib/error.h:410:8: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 410 | : ({ \ |^ ./lib/error.h:470:7: note: in expansion

(lib/error.h.in) New warnings when compiling "groff" [-Wredundant-decls]

Debian GNU/Linux 12 (bookworm) Linux 6.1.27-1 x86_64 GNU/Linux gcc (Debian 12.2.0-14) 12.2.0 [...] CC lib/libgnu_a-openat-die.o In file included from ../lib/openat-die.c:25: ./lib/error.h:28:3: warning: #include_next is a GCC extension 28 | # include_next | ^~~~ In file

Re: lib/dirfd.c: compiler warning: unused parameter

On Thu, May 04, 2023 at 11:30:30AM +0200, Bruno Haible wrote: > Paul Eggert wrote: > > That being said, I see a path through lib/dirfd.c where dirfd's arg is > > ignored. > > Yes, that may happen in systems that don't have d_fd nor dd_fd in 'DIR' > and are not Windows. But such systems are of the

Re: lib/dirfd.c: compiler warning: unused parameter

On Thu, May 04, 2023 at 01:59:07AM +0200, Bruno Haible wrote: > Bjarni Ingi Gislason wrote: > > The compiler reports: > > > > CC lib/libgnu_a-dirfd.o > > ../lib/dirfd.c: In function 'rpl_dirfd': > > ../lib/dirfd.c:83:13: warning: unuse

lib/dirfd.c: compiler warning: unused parameter

Software: groff, private repository that is updated regulary with GNU gnulib. with gnulib_modules=" git-version-gen havelib wcwidth fprintf-posix snprintf vsnprintf stdint setlocale vsnprintf-posix warnings gen-header manywarnings mkstemp fmod getcwd

Re: adding gnulib's sys_wait module to groff made Automake angry

This is groff bug #61832 (from 16th January 2022). N.B. The subject line was changed.

groff with "nullptr" and (without) gnulib module causes error

Debian testing (bookworm/sid) Linux 6.1.7-1 x86_64 GNU/Linux gcc (Debian 12.2.0-14) 12.2.0 GNU Make 4.4.0.90 Built for x86_64-pc-linux-gnu cd git/groff/src grep -r -l nullptr * > $afrit echo 's%0 /\* nullptr \*/%nullptr%' > ~/tmp/nullptr.sed sed -i -f ~/tmp/nullptr.sed $(cat $afrit)

Re: FAIL in diffutils/gnulib-tests

On Mon, Feb 06, 2023 at 01:17:29AM +, Bjarni Ingi Gislason wrote: [...] > > FAIL: test-c-stack2.sh > == > > FAIL test-c-stack2.sh (exit status: 1) > > FAIL: test-localeconv > = > > ../../gnulib-tests/test-localeconv.c

Re: [g.branden.robin...@gmail.com: macOS 12.6.3 and vasnprintf compilation failure]

See https://savannah.gnu.org/bugs/index.php?63078 I renamed the file "groff/src/include/assert.h" in my privat branch of groff to ".../assert.h.original".

Differences between "module license" and "file license"

Debian testing (bookworm/sid) Compiling in the "build" directory: /usr/local/bin/make GNU Make 4.4.0.90 Built for x86_64-pc-linux-gnu Copyright (C) 1988-2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you

Re: FAIL in diffutils/gnulib-tests

On Mon, Feb 06, 2023 at 02:28:03AM +0100, Bruno Haible wrote: > Bjarni Ingi Gislason wrote: > >GNU diffutils 3.9.12-c05c: gnulib-tests/test-suite.log > > Please try again with the tarball that you can download from > https://gitlab.com/gnu-diffutils/ci-distcheck >

FAIL in diffutils/gnulib-tests

Latest master locale is in /usr/share/i18n/locales/is_IS % *_frac_* must be checked int_frac_digits 0 frac_digits 0 GNU diffutils 3.9.12-c05c: gnulib-tests/test-suite.log =

module c-nullptr: error compiling groff

Debian testing (bookworm/sid) gcc (Debian 12.2.0-14) 12.2.0 GNU Make 4.4.0.90 [...] CXX src/roff/troff/env.o In file included from /usr/include/c++/12/bits/stl_bvector.h:61, from /usr/include/c++/12/vector:65, from ../src/roff/troff/charinfo.h:20,

Re: groff: error after update of gnulib, 13th January 2023

Thanks for this. I renamed "error.h" in groff to "groff_error.h".

Re: groff: error after update of gnulib, 13th January 2023

Thanks for some insights. I reverted the commit to get the compilation error-free. Some observations with the commit added 1) /lib/error.h is not compiled from /lib/error.in.h It is there when the commit is abset. 2) with the commit, the config.log contains GL_GENERATE_ERROR_H_FALSE=

groff: error after update of gnulib, 13th January 2023

Software: groff I got these warnings in directory "groff/build" after an update of gnulib (13th January), commit 2886cca8398f4c5a4d68368a19c0e6d0ff97c739 CC lib/libgnu_a-openat-die.o In file included from ../lib/openat-die.c:25: ../src/include/error.h:22:44: warning: type defaults to '

Re: "git-version-gen" prints "Print a version string." three times

This is invalid as I did add "set -x" to the script.

"git-version-gen" prints "Print a version string." three times

"sh -x build-aux/get-version-gen" outputs: + scriptversion=2022-07-09.08 + me=build-aux/git-version-gen + expr 2022-07-09.08 : \([^-]*\) + year=2022 + version=git-version-gen 2022-07-09.08 Copyright (C) 2022 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

Re: lib/malloca.c: warning about [-Wsign-compare]

On Wed, Sep 21, 2022 at 05:15:50PM -0700, Paul Eggert wrote: > On 9/21/22 14:42, Bjarni Ingi Gislason wrote: > > > you do not say for what you want (need) all this data. > > We need a reproducer to figure out what is causing the problem. Perhaps the > problem involves some

Re: lib/malloca.c: warning about [-Wsign-compare]

On Mon, Sep 19, 2022 at 02:39:35AM +0200, Bruno Haible wrote: > Bjarni, > > Please use the bug report template from > . > Hi, you do not say for what you want (need) all this data. If your are seeking a reproducer this wor

lib/malloca.c: warning about [-Wsign-compare]

Compilation with Debian clang version 14.0.6-2 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin Software: groff (git HEAD) CC lib/libgnu_a-malloca.o ../lib/malloca.c:54:38: warning: comparison of integers of different signs: 'unsigned long' and 'idx_t' (aka 'long'

Re: lib/malloca.c: error when compiling "groff"

The source of the compilation error was the file "src/include/assert.h" in "groff". Removing it fixes the compilation.

Re: lib/malloca.c: error when compiling "groff"

Here are some missing files to reproduce my case 1) bootstrap.conf in an attachment 2) bootstrap.out -- " -- Other information gnulib: commit e441260eab816e9b6d202fe7ac288ec2a7b72f34 Date: Thu Sep 15 00:50:41 2022 +0200 autoconf (GNU Autoconf) 2.71 automake (GNU automake) 1.16.5 GNU

Re: lib/malloca.c: error when compiling "groff"

I get the same error with "gcc-11 (Debian 11.3.0-5) 11.3.0" and gcc-10 In "config.log" I see: configure:21128: checking for static_assert configure:21162: /usr/bin/gcc-10 -c -Walloc-zero -Walloca -Wall -Wextra -Wformat=2 -Wattribute-warning -Wdate-time -Wformat-security -Wfree-nonheap-objec

Re: lib/malloca.c: error when compiling "groff"

On Wed, Sep 14, 2022 at 04:45:20PM -0500, Paul Eggert wrote: > Can you reproduce the problem with my recipe? > > One possibility is that you have an old malloca.c left over from an old > build, and it won't compile with the new Gnulib. So it may help to bootstrap > from scratch. > (all times in U

Re: lib/malloca.c: error when compiling "groff"

/usr/bin/gcc-12 -DHAVE_CONFIG_H -I. -I.. -I./src/include -I../src/include -I../lib -I./src/include -I./lib -D_FORTIFY_SOURCE=2 -DGCC_LINT -DGNULIB_NO_VLA -Wno-cast-qual -Wno-conversion -Wno-float-equal -Wno-sign-compare -Wno-undef -Wno-unused-function -Wno-unused-parameter -Wno-float-conversion

lib/malloca.c: error when compiling "groff"

CC = gcc (Debian 12.2.0-1) 12.2.0 CC lib/libgnu_a-malloca.o ../lib/malloca.c:42:16: error: expected declaration specifiers or '...' before numeric constant 42 | static_assert (2 * sa_alignment_max - 1 <= (small_t) -1); |^ make[1]: *** [Makefile:8629: lib/libgnu_a-

Re: vasnprintf.c: "out_of_memory", -Wanalyzer-free-of-non-heap, -Wanalyzer-malloc-leak

On Sat, Apr 30, 2022 at 01:27:28PM -0700, Paul Eggert wrote: > On 4/30/22 07:13, Bjarni Ingi Gislason wrote: > >With latest gnulib version: > > I'm not seeing this problem with the current > (84863a1c4dc8cca8fb0f6f670f67779cdd2d543b) gnulib version on Fedora 35 > x8

vasnprintf.c: "out_of_memory", -Wanalyzer-free-of-non-heap, -Wanalyzer-malloc-leak

With latest gnulib version: commit d6a07b4dc21b3118727743142c678858df442853 (origin/master, origin/HEAD) Author: Simon Marchi Date: Fri Apr 29 01:47:55 2022 +0200 While compiling "groff" (for exampe while creating "grodvi") with gcc-11.3 options "-fanalyzer -Wanalyzer-mismatching-dealloca

"bootstrap" changed without adjusting version string

File: git/gnulib/build-aux/bootstrap scriptversion=2021-04-11.09; According to "git blame bootstrap", material has been added at dates "2021-12-12" and "2022-01-05" without updating the announced string "scriptversion" in the output of "bootstrap --version". This also affects the string "cop

gnulib-tool: warnings of type "module --automake-subdir doesn't exist"

Command: gnulib-tool --add-import Output with a warning: gnulib-tool: warning: module --automake-subdir doesn't exist gnulib-tool: warning: module --aux-dir=build-aux doesn't exist gnulib-tool: warning: module --doc-base=doc doesn't exist gnulib-tool: warning: module --lib=libgnu doesn't exis

Re: undefined references to "rpl_fclose" and "rpl_fflush"

On Tue, Jan 18, 2022 at 12:20:46AM +0100, Bruno Haible wrote: [...] Thanks for the tips. The "fclose.c" and "fflush.c" files do not get compiled as they are included in a different make variable am__lib_libgroff_a_SOURCES_DIST which is part of a target "distfile". For the default targe

undefined references to "rpl_fclose" and "rpl_fflush"

Software: groff Adding some gnulib modules to "bootstrap.conf" after checking with module "posixcheck": close dup execvp fclose fdopen fflush fopen freopen malloc-posix nl_langinfo pclose perror pipe-posix popen realloc-posix strer

gnulib-tool with "--makefile-name=gnulib.mk" creates a file with 'lib/' inserted to first line of "SED_HEADER_... ="

Software: groff; latest in my repository with fixes for latest gnulib. gnulib: latest in repository Produced file "groff/lib/gnulib.mk" contains: --- start piece of code --- ## begin gnulib module gen-header # In 'sed', prepend a "DO NOT EDIT" comment to the pattern space. SED_HEADER_NOE

gnulib-tool: possibly a misleading reminder about "ACLOCAL_AMFLAGS"

In the output of "bootstrap" there is a reminder: [...] Don't forget to [...] - mention "-I gnulib_m4" in ACLOCAL_AMFLAGS in Makefile.am, [...] End of quotation. "ACLOCAL_AMFLAGS" in "Makefile.am" is going to be replaced by "AC_CONFIG_MARCO_DIRS" (in configure.ac) according to file "NEWS-2

Re: lib/string.h: "gcc-11" reports an error when compiling "groff"

On Sat, Oct 09, 2021 at 12:53:41AM -0700, Paul Eggert wrote: > On 10/8/21 6:43 PM, Bjarni Ingi Gislason wrote: > >CC src/devices/xditview/gxditview-Dvi.o > > In file included from /usr/include/X11/Intrinsic.h:61, > > from /usr/includ

lib/string.h: "gcc-11" reports an error when compiling "groff"

[...] CC src/devices/xditview/gxditview-device.o CC src/devices/xditview/gxditview-draw.o CC src/devices/xditview/gxditview-Dvi.o In file included from /usr/include/X11/Intrinsic.h:61, from /usr/include/X11/IntrinsicP.h:51, from ../src/devic

Re: "rpl_fprintf" not found if compiled with options "-ggdb -Og"

On Sat, Jul 31, 2021 at 01:31:55AM -0700, Paul Eggert wrote: > On 7/30/21 6:43 PM, Bjarni Ingi Gislason wrote: > >Actually I am using the current repository of both "groff" and > > "gnulib". > > I can't reproduce the problem that way, either

Re: "rpl_fprintf" not found if compiled with options "-ggdb -Og"

On Wed, Jul 28, 2021 at 02:37:00PM -0700, Paul Eggert wrote: > I'm not seeing this problem when building groff 1.22.4 (the latest version) > on Ubuntu 21.04, which has GCC Ubuntu 10.3.0-1ubuntu1. I built by doing > this: > > wget https://ftp.gnu.org/pub/gnu/groff/groff-1.22.4.tar.gz > cd groff-1.2

"rpl_fprintf" not found if compiled with options "-ggdb -Og"

Software: groff and gcc (Debian 10.2.1-6) 10.2.1 20210110 Copyright (C) 2020 Free Software Foundation, Inc. Error: CCLD gxditview /usr/bin/ld: src/devices/xditview/gxditview-device.o: in function `open_device_file': /home/bg/git/groff/build/../src/devices/xditview/device.c:535: undefine

doc/gnulib-intro.texi: A "to" is missing in a sentence.

The text is: All patches should be posted the list, ... It is also in the files "doc/gnulib.html" and "doc/gnulib.info". -- Bjarni I. Gislason

users.txt: "groff" uses gnulib//

[PATCH] lib/vasnprintf.c: Add information to make integer comparison logical

if (count < maxlen ^ The value of "count" is tested to be non-negative, so a cast to "size_t" is valid. Signed-off-by: Bjarni Ingi Gislason --- lib/vasnprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vasnprintf.c b/lib/vas

[PATCH] Remove repeated words

Signed-off-by: Bjarni Ingi Gislason --- ChangeLog | 16 build-aux/texinfo.tex | 2 +- lib/fd-hook.c | 2 +- lib/fd-hook.h | 2 +- lib/savewd.c | 2 +- lib/uninorm/decomposition