Collin Funk wrote:
> This patch fixes the uses of __GNUC_MINOR which should instead be
> __GNUC_MINOR__:
We had similar mistakes with __clang_major__ already. Sounds like
a general syntax-check rule would help.
Bruno
Hi Paul,
While looking into @STDDEF_NOT_IDEMPOTENT@ for Emacs I noticed a minor
typo in a recent commit of yours.
This patch fixes the uses of __GNUC_MINOR which should instead be
__GNUC_MINOR__:
$ echo | gcc -dM -E - | grep __GNUC_MINOR
#define __GNUC_MINOR__ 1
Collin
[1] https://list
Bruno Haible writes:
> Po Lu wrote:
>> > - Is NEED_TIMEZONE_NULL_SUPPORT defined in config.h ?
>> > - Is time_rz.c among the source code, after the gnulib import?
>> > - Is time_rz.o among the compiled files?
>>
>> Sure. Yes to all of the above.
>>
>> > - What symbols are shown as defi
Paul Eggert wrote:
> As I'm still a bit concerned that glibc reviewers will object to
> removing the "ifndef __obstack_free" I installed the attached further
> patch.
Looks good to me. But the CIs will tell whether it really works fine.
> This further patch affects only people not using Gnulib
On 5/6/25 11:08, Bruno Haible wrote:
obstack: Fix library namespacing (regression yesterday).
Thanks for finding and fixing that.
As I'm still a bit concerned that glibc reviewers will object to
removing the "ifndef __obstack_free" I installed the attached further
patch. This further
Thanks, I installed the attached.From 10f5798abc5e8ac8c4be0c8339e37bca14fd5957 Mon Sep 17 00:00:00 2001
From: Paul Eggert
Date: Tue, 6 May 2025 15:14:50 -0700
Subject: [PATCH] obstack: fix comment
* lib/obstack.c: Fix comment along the lines suggested
by Bruno Haible in:
https://lists.gnu.org/r/
This for clarity and to document the overflow checking better;
I think no current Gnulib or glibc targets have SIZE_MAX <= INTMAX,
so it shouldn’t change behavior on current targets.
* lib/obstack.c: Include stdckdint.h, not limits.h.
Remove no-longer needed ! (SIZE_MAX <= INT_MAX) check.
(align_ch
I wrote:
> This #undef breaks library namespacing.
And by breaking the library namespacing, it caused build failures of
GNU gettext on several platforms. Reported through the CI.
On Alpine Linux and macOS 15:
./obstack.h:470:10: warning: 'obstack_free' macro redefined [-Wmacro-redefined]
470 |
Paul Eggert wrote:
> diff --git a/lib/obstack.c b/lib/obstack.c
> index b5cf0d514b..9877207cb1 100644
> --- a/lib/obstack.c
> +++ b/lib/obstack.c
> @@ -250,8 +250,10 @@ _obstack_allocated_p (struct obstack *h, void *obj)
> /* Free objects in obstack H, including OBJ and everything allocate
> m
Paul Eggert wrote:
> --- a/lib/obstack.c
> +++ b/lib/obstack.c
> @@ -31,8 +31,7 @@
> use the already-supplied __alignof__. Otherwise, this must be Gnulib
> (as glibc assumes GCC); defer to Gnulib's alignof_type. */
> #if !defined __GNUC__ && !defined __alignof__
> -# include
> -# define
Po Lu wrote:
> > - Is NEED_TIMEZONE_NULL_SUPPORT defined in config.h ?
> > - Is time_rz.c among the source code, after the gnulib import?
> > - Is time_rz.o among the compiled files?
>
> Sure. Yes to all of the above.
>
> > - What symbols are shown as defined ('T') in "nm time_rz.o"?
>
Po Lu writes:
>> - Is HAVE_NATIVE_TIME_Z defined in config.h ?
Actually, this is defined in strftime.c (and evaluates to 0). Nowhere
does it appear in the generated config.h.in or config.h.
Bruno Haible writes:
> Hi Po Lu,
>
>> Emacs shared libraries fail to link at runtime when compiled with
>> __ANDROID_API__ == 35 and the NDK r28a:
>
> OK, that is a supported configuration.
>
>> E AndroidRuntime: FATAL EXCEPTION: main
>> E AndroidRuntime: Process: org.gnu.emacs, PID: 21651
>> E A
Hi Po Lu,
> Emacs shared libraries fail to link at runtime when compiled with
> __ANDROID_API__ == 35 and the NDK r28a:
OK, that is a supported configuration.
> E AndroidRuntime: FATAL EXCEPTION: main
> E AndroidRuntime: Process: org.gnu.emacs, PID: 21651
> E AndroidRuntime: java.lang.Unsatisfie
Emacs shared libraries fail to link at runtime when compiled with
__ANDROID_API__ == 35 and the NDK r28a:
E AndroidRuntime: FATAL EXCEPTION: main
E AndroidRuntime: Process: org.gnu.emacs, PID: 21651
E AndroidRuntime: java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate
symbol "set_tz" ref
15 matches
Mail list logo
