Re: bug#73928: Bug#1080330: coreutils: who no longer works

2025-02-16 Thread Paul Eggert
On 2025-02-16 23:03, Thorsten Kukuk wrote: The problems were already all solved with the first coreutils versions having systemd-logind support. Even with all the bug reports I don't see a need for changes in Coreutils, only in distributions not enabling systemd-logind support in all packages.

Re: directory separator

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Mitch Capper wrote: > I did implement most of the shared path code in lib/filename.h but for > windows I do need strpbrk. Am I ok to just add that as a dependency for > the filename module? You don't even need this dependency, since native Windows has strpbrk and since the doc (doc/posix-functio

Re: new modules strcasecmp_l, strncasecmp_l

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Oops, the strncasecmp_l test fails on NetBSD, Solaris, Cygwin. This patch fixes it. 2025-02-17 Bruno Haible strncasecmp_l: Fix replacement implementation. * lib/strncasecmp_l.c (strncasecmp_l): Use tolower_l, not tolower. diff --git a/lib/strncasecmp_l.c b/lib/strncasecmp_l.c

Re: work around bugs in strcasecmp and strncasecmp

2025-02-16 Thread Bruno Haible via Gnulib discussion list
The CI reports a compilation error on MSVC: D:\a\ci-testdir-check\ci-testdir-check\testdir-all\gltests\test-strcasecmp.c(22): error C2065: 'strcasecmp': undeclared identifier This patch fixes it. 2025-02-17 Bruno Haible strcasecmp, strncasecmp: Fix compilation error on MSVC.

Re: directory separator

2025-02-16 Thread Mitch Capper
> If I have understood it correctly, the best way to handle file names on native > Windows is to > - use '\\' as a directory separator when composing file names, > - allow both '/' and '\\' when inspecting file names. Yes, that is largely what I implemented. There is a platform specific DIR_SEPA

Re: [PATCH 0/2] getaddrinfo: Add AI_NUMERICSERV and AI_NUMERICHOST flag support

2025-02-16 Thread Bruno Haible via Gnulib discussion list
> @@ -187,9 +192,13 @@ int main (void) >(void) gl_sockets_startup (SOCKETS_1_1); > >return ( simple (1, HOST1, SERV1) > + + simple (1, HOST1, "80") >+ simple (1, HOST2, SERV2) > + + simple (1, HOST2, "443") >+ simple (1, HOST3, SERV3) > +

Re: unistd-h: Make sure O_CLOEXEC is defined.

2025-02-16 Thread Collin Funk
Bruno Haible writes: > Since no version of MSVC has , it is redundant to list MSVC > here. Ah, okay I see. That makes sense. > And you can also add > macOS > and > AIX 7.3 > to the list of platforms. I just checked the result of your test program > on these platform (using the compilefarm m

new modules strcasecmp_l, strncasecmp_l

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Now that we have a unit test and workarounds for strcasecmp, it's relatively easy to implement strcasecmp_l. Done through these patches: 2025-02-16 Bruno Haible strncasecmp_l: Add tests. * tests/test-strncasecmp_l.c: New file. * modules/strncasecmp_l-tests: New file.

Re: unistd-h: Make sure O_CLOEXEC is defined.

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Hi Collin, > I have applied the following two patches to define O_CLOEXEC in unistd.h > and add a test for it. I also documented the platforms that don't behave > like POSIX 2024 using the GitHub CI. Thanks for these patches, and thanks for the glibc bug report. Looks all good, except the platfor

unistd-h: Make sure O_CLOEXEC is defined.

2025-02-16 Thread Collin Funk
Hi, I found the following two changes in POSIX 2024 that were not very well documented in the CHANGE HISTORY section of [1] [2]: The header shall define the symbolic constants O_CLOEXEC and O_CLOFORK as described in . Inclusion of the header may make visible all symbols from t

Re: Windows security model

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Mitch Capper wrote: > For requests to get the actual username I don't know if it is better to: > 1) Try the official API GetUserName but it requires an additional windows > library if it is not already included (which most of the time it is not) > https://learn.microsoft.com/en-us/windows/win32/api

Re: Windows security model

2025-02-16 Thread Mitch Capper
> The current state is an attempt to make code compile if it doesn't use > or . I don't know whether this state can be significantly > improved. But if you have reasonable suggestions, please show them! For requests to get the actual username I don't know if it is better to: 1) Try the official A

work around bugs in strcasecmp and strncasecmp

2025-02-16 Thread Bruno Haible via Gnulib discussion list
I don't believe it. I just don't believe it. Solaris, with its fame of being seminal regarding internationalization, ships a buggy strcasecmp() function. The bug is reproducible in Solaris 10, Solaris 11.4, Solaris 11 OpenIndiana, Solaris 11 OmniOS. = foo.c

realloc: Fix link error in C++ mode on CentOS 5

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Building a testdir for 'isalnum_l' on CentOS 5, I see this link error: g++ -Wno-error -g -O2 -o test-stdlib-h-c++ test-stdlib-h-c++.o test-stdlib-h-c++2.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a libtests.a test-stdlib-h-c++.o: In function `__static_initialization_and_d

new modules strcasecmp, strncasecmp, c-strcasecmp, c-strncasecmp

2025-02-16 Thread Bruno Haible via Gnulib discussion list
The functions strcasecmp, strncasecmp are provided by a single module: 'strcase'. Similarly, the functions c_strcasecmp, c_strncasecmp are provided by a single module: 'c-strcase'. While this saves a little bit of module description and *.m4 code, it has two drawbacks: - It blurs the usual corr

Re: new module 'isalnum_l'

2025-02-16 Thread Bruno Haible via Gnulib discussion list
A small correction to the ctype.in.h patch from two days ago: 2025-02-16 Bruno Haible ctype-h: Make ctype.h self-contained again (regr. 2025-02-14). * lib/ctype.in.h: Add comments re _GL_ARG_NONNULL. * modules/ctype-h (Depends-on): Add snippet/arg-nonnull. (Mak

Re: `git clone -h` does not contain "--depth"

2025-02-16 Thread Bruno Haible via Gnulib discussion list
Hi Benno, > In build-aux/bootstrap there is this fragment of code: > > if git clone -h 2>&1 | grep -- --depth > /dev/null; then > shallow='--depth 2' > fi > > But the output of `git clone -h` nowadays (version 2.48.1) does > not contain the option --depth. It instead contains

`git clone -h` does not contain "--depth"

2025-02-16 Thread Benno Schulenberg
Hi, In build-aux/bootstrap there is this fragment of code: if git clone -h 2>&1 | grep -- --depth > /dev/null; then shallow='--depth 2' fi But the output of `git clone -h` nowadays (version 2.48.1) does not contain the option --depth. It instead contains this: --[no-]dept