Re: pty: Define 'struct winsize' on all platforms.

Collin Funk wrote: > Since termios.h defines 'struct winsize' on all platforms I think that > pty.h should also do the same. Yes, given the description of in https://www.gnu.org/software/libc/manual/html_node/Pseudo_002dTerminal-Pairs.html this seems reasonable. > I've committed a patch doing th

Re: Possible UNINIT bug within man-db gl sources

On 2024-08-16 07:30, Bruno Haible wrote: Copying and then discarding an uninitialized value of integer or pointer type (i.e. not a signalling NaN (*)) is not undefined behaviour. Although that's how typical implementations behave, the C standard says that copying from a source variable has und

pty: Define 'struct winsize' on all platforms.

Since termios.h defines 'struct winsize' on all platforms I think that pty.h should also do the same. I've committed a patch doing that and adding a basic C check program for types. BTW, I think this fixes a very minor bug. Since the 'pty' module does not directly depend on 'termios' but pty.in.h

Re: gitsub.sh hardcodes origin/master

Hi Bruno, Bruno Haible writes: > It would still be wrong when a package is using one of the "stable" branches > of gnulib. [...] > Here's what I'm committing. Let me know if it does not work in your case. Right, this solution looks better. I haven't tested it but it looks like good behavior to

Re: gitsub.sh hardcodes origin/master

Collin Funk wrote: > > It would be nice to cover both "master" and "main". I think that would > > cover 99% percent of cases. It would still be wrong when a package is using one of the "stable" branches of gnulib. Marc Nieper-Wißkirchen wrote: > I am not an expert in git, but here is some informa

Re: gitsub.sh hardcodes origin/master

Am Fr., 16. Aug. 2024 um 20:51 Uhr schrieb Collin Funk < collin.fu...@gmail.com>: > Hi Marc, > > Marc Nieper-Wißkirchen writes: > > > ./gitsub.sh upgrade > > > > fails when submodules are present where the master branch is not called > > "master" but something else, e.g. "main", which becomes inc

Re: gitsub.sh hardcodes origin/master

Hi Marc, Marc Nieper-Wißkirchen writes: > ./gitsub.sh upgrade > > fails when submodules are present where the master branch is not called > "master" but something else, e.g. "main", which becomes increasingly common. > > The branch name "origin/master" is currently hardcoded in gitsub.sh. It wo

Re: gnulib creates tests/ directory

Hi Bruno, Am Fr., 16. Aug. 2024 um 18:03 Uhr schrieb Bruno Haible : > Hi Marc, > > Please keep the mailing list in CC. > This was due to my inability to use my email program properly. > > > Does it still do so if you remove the 'valgrind-tests' modules from the > > > list? > > > > > > > It doe

gitsub.sh hardcodes origin/master

Hi! Running ./gitsub.sh upgrade fails when submodules are present where the master branch is not called "master" but something else, e.g. "main", which becomes increasingly common. The branch name "origin/master" is currently hardcoded in gitsub.sh. Thanks, Marc

Re: gnulib-tool-tests: Add tests for --extract-dependents.

Collin Funk wrote: > I pushed two test cases for 'gnulib-tool --extract-dependents' to > gnulib/maint-tools.git so I can validate any changes I make [1]. Thanks. I added them to the 'test-all.sh' script. Bruno

gnulib-tool.py: Correct the result of --extract-dependents

As mentioned in , $ ./gnulib-tool --extract-dependents hamt should return hamt-tests This patch does it. 2024-08-16 Bruno Haible gnulib-tool.py: Correct the result of --extract-dependents. * pygnulib/GLModul

Re: gnulib creates tests/ directory

Hi Marc, Please keep the mailing list in CC. > > Does it still do so if you remove the 'valgrind-tests' modules from the > > list? > > > > It does not. OK, then the problem is that gnulib-tool does not know that 'valgrind-tests' is special. Fixed like this. We could have noticed the problem be

Re: Possible UNINIT bug within man-db gl sources

Hi, Lukas Javorsky wrote: > From my analysis, I believe that if the `GCC_LINT` or `lint` macros > are not defined, the elements `i`, `j`, and `count` from the > `gl_map_iterator_t` struct are not initialized Correct. They are not initialized because they are not used. Look at the gl_tree_iterato

Re: gnulib creates tests/ directory

Hi Marc, > Although I don't use gnulib with '--with-tests', it does create a tests/ > directory during bootstrap and fills it with a few files. I attached my > gnulib-cache.m4. Does it still do so if you remove the 'valgrind-tests' modules from the list? Bruno

Possible UNINIT bug within man-db gl sources

Hi, I'm analyzing the results of SAST reports (combination of coverity,snyk,cppcheck,gcc,clang,shellcheck,unicontrol), and from 20 findings I identified a few that might be a true positive. However, I would like to ask you for the help to resolve it, as I'm not 100% aware of the code internals.

Re: [PATCH 2/2] error: merge from glibc and with verror

On 15/08/2024 23:13, Paul Eggert wrote: Thanks, I installed the attached. Oh it required a change in downstream projects. I assumed it was gnulib specific. Thanks for fixing it in coreutils. Pádraig