doc: Update list of headers to use #include <...>.

2024-07-26 Thread Collin Funk
Now that sys/un.h might be replaced by Gnulib we have to keep in mind the #include <...> vs. #include "..." issue. I also noticed some other files in lib/*.in.h were missing from the lists so I added them too. First patch is adding them to the docs and second is adding them to maint.mk. Separate

Re: sys_time, sys_types: Remove sys directory at 'make mostlyclean'.

2024-07-26 Thread Bruno Haible
Hi Collin, > I didn't know/forgot MOSTLYCLEANDIRS existed. While MOSTLYCLEANFILES is handled by Automake, MOSTLYCLEANDIRS is a Gnulib invention. > I noticed it also missing > in sys_types and sys_time module. I've pushed this so it gets cleaned > even if no other sys_* modules are in use. Thank

sys_time, sys_types: Remove sys directory at 'make mostlyclean'.

2024-07-26 Thread Collin Funk
Hi Bruno, In your fix for the sys_un module you added this to the module description: MOSTLYCLEANFILES += sys/un.h sys/un.h-t +MOSTLYCLEANDIRS += sys I didn't know/forgot MOSTLYCLEANDIRS existed. I noticed it also missing in sys_types and sys_time module. I've pushed this so it gets cleaned eve

Re: sys_un: New module.

2024-07-26 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > It was never resolved, correct. Alexandre's mail from 2021 is still unresolved > on my side. But when I try the testdir4 recipe from that thread today, > with all versions from clang 18 down to clang 11, it all compiles fine. > I therefore believe that Alexandre'

Re: git-version-gen doc: writing to intermediate file

2024-07-26 Thread Basil L. Contovounesios
Bruno Haible [2024-07-26 16:27 +0200] wrote: > Basil L. Contovounesios wrote: > >> $(top_srcdir)/.version: >> echo '$(VERSION)' > $@-t >> mv $@-t $@ >> ... >> I'm curious why one recipe writes a temporary file first > The real reason is that if the disk is full, the rule would l

Re: git-version-gen doc: writing to intermediate file

2024-07-26 Thread Bruno Haible
Basil L. Contovounesios wrote: > The commentary in build-aux/git-version-gen illustrates how the files > .version and .tarball-version could be generated: > > $(top_srcdir)/.version: > echo '$(VERSION)' > $@-t > mv $@-t $@ > ... > I'm curious why one recipe writes a temporary fil

git-version-gen doc: writing to intermediate file

2024-07-26 Thread Basil L. Contovounesios
The commentary in build-aux/git-version-gen illustrates how the files .version and .tarball-version could be generated: $(top_srcdir)/.version: echo '$(VERSION)' > $@-t mv $@-t $@ dist-hook: echo '$(VERSION)' > $(distdir)/.tarball-version I'm curious why one recipe wri

Re: sys_un: New module.

2024-07-26 Thread Bruno Haible
I wrote: > What I see is that if I move the '#include ' from inside to > outside the __BEGIN_DECLS / __END_DECLS block in , the errors > go away. Reported at .

Re: sys_un: New module.

2024-07-26 Thread Bruno Haible
Hi Collin, > The warnings say: > > > ../gllib/string.h:809:20: error: declaration of 'memchr' has a > > different language linkage > > 809 | _GL_CXXALIASWARN1 (memchr, void *, > > |^ > > /usr/include/string.h:94:1: note: previous definition is here > >

Re: [PATCH] lib/xstrtol.c: Fix xstrtol() on EINVAL (invalid base)

2024-07-26 Thread Bruno Haible
Paul Eggert wrote: > I installed the attached patch Thanks. Stating which conditions produce undefined behaviour goes a long way at avoiding programmer pitfalls. > It's OK for > behavior to be undefined when the base is bad, just as it's OK for it to > be undefined if the string is bad (e.g., w

Re: sys_un: New module.

2024-07-26 Thread Bruno Haible
Hi Collin, > I had assumed GNULIB_NAMESPACE was supposed to be defined in C++ tests. > Is that incorrect? I don't know C++ namespaces much. The GNULIB_NAMESPACE is an optional setting, see https://www.gnu.org/software/gnulib/manual/html_node/A-C_002b_002b-namespace-for-gnulib.html Since it is op