Re: configure output from largefile.m4

2024-06-17 Thread Paul Eggert
Thanks, I installed the attached which I hope is good enough. It's also in Autoconf master now.From 247f06bd6f6a3a637442060d4ad20907778e88cd Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 17 Jun 2024 21:08:29 -0700 Subject: [PATCH] Improve wording for Y2038 and largefile probes This chang

Re: [PATCH 6/7] nstrftime, time_rz: don’t depend on tzname

2024-06-17 Thread Paul Eggert
On 2024-06-17 07:51, Bruno Haible wrote: After the Solaris crash fix, the nstrftime tests still fail, due to this output: <-00>0: expected "1970-01-01 00:00:00 - (-00)", got "1970-01-01 00:00:00 + (-00)" <-00>0: expected "1985-11-05 00:53:21 - (-00)", got "1985-11-05 00:53:21 +

Re: [PATCH 6/7] nstrftime, time_rz: don’t depend on tzname

2024-06-17 Thread Bruno Haible
Paul Eggert wrote: > Thanks for reporting and fixing that. For NetBSD, a better fix is to use > the native timezone_t, so that Gnulib doesn't need to set and later > restore TZ. Interesting. So, we have at least one platform now, where nstrftime is multithread-safe. Only an indentation nit: 2

Re: [PATCH 6/7] nstrftime, time_rz: don’t depend on tzname

2024-06-17 Thread Paul Eggert
Thanks for reporting and fixing that. For NetBSD, a better fix is to use the native timezone_t, so that Gnulib doesn't need to set and later restore TZ. I attempted to do by installing the attached.From 17432773bb157fe9bd11137edd42cd7be35e1dea Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon

Re: vasnprintf: Reject a width > INT_MAX

2024-06-17 Thread Bruno Haible
I did: > vasnprintf: Reject a width > INT_MAX. > * lib/vasnprintf.c (VASNPRINTF): If a width is > INT_MAX, fail with > EOVERFLOW. This causes a test failure on Cygwin. Namely, Cygwin has vasnprintf, but with this argument list "x%030dy\n", -17 it returns "x-17y\n", of

Re: new module 'tzname'

2024-06-17 Thread Paul Eggert
On 2024-06-17 06:47, Bruno Haible wrote: @item This variable's contents are unreliable if you use a geographical @env{TZ} setting like @code{TZ="America/Los_Angeles"}. What do you mean by "unreliable"? You'll get different results on different platforms, the tzname values may not be

Re: new module 'tzname', tm_zone and tm_gmtoff

2024-06-17 Thread Paul Eggert
On 2024-06-17 08:32, Bruno Haible wrote: NetBSD has a tzgetname() function: https://man.netbsd.org/tzset.3 tzgetname (tz, i) is equivalent to tzname[i]. This is the style of API I like better. That API can't work in general. Some time zones have multiple abbreviations for standard time. A cl

Re: new module 'tzname', tm_zone and tm_gmtoff

2024-06-17 Thread Bruno Haible
Paul Eggert wrote: > >>> tzname is used in three places: > >>> - time_rz, > >> > >> This should be fixed to use strftime instead. > > > > This seems wrong for two reasons: > > > >* time_rz is a small module, without textual I/O. > > Fair enough, and the changes I recently installed into

Re: [PATCH 6/7] nstrftime, time_rz: don’t depend on tzname

2024-06-17 Thread Bruno Haible
After the Solaris crash fix, the nstrftime tests still fail, due to this output: <-00>0: expected "1970-01-01 00:00:00 - (-00)", got "1970-01-01 00:00:00 + (-00)" <-00>0: expected "1985-11-05 00:53:21 - (-00)", got "1985-11-05 00:53:21 + (-00)" <-00>0: expected "2001-09-09 01:46:

Re: [PATCH 6/7] nstrftime, time_rz: don’t depend on tzname

2024-06-17 Thread Bruno Haible
Paul Eggert did: > (__strftime_internal): Simplify calculation of zone to be closer > to what glibc does. This causes 4 test suite failures on Solaris 11.4, from a null pointer reference: FAIL: test-c-nstrftime-1.sh === ../../gltests/test-c-nstrftime-1.sh: line 3: 9936: M

Re: [PATCH 6/7] nstrftime, time_rz: don’t depend on tzname

2024-06-17 Thread Bruno Haible
Paul Eggert did: > (set_tz, revert_tz): Declare, as they’re now extern. This causes link errors on NetBSD 10 (caught by the CI): gcc -Wno-error -g -O2 -L/home/bruno/lib -L/usr/pkg/lib -o test-c-nstrftime test-c-nstrftime.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a libtests.a

Re: new module 'tzname'

2024-06-17 Thread Bruno Haible
Hi Paul, In tzname.texi you added: @item This variable's contents are unreliable if you use a geographical @env{TZ} setting like @code{TZ="America/Los_Angeles"}. What do you mean by "unreliable"? I tested the values for this TZ and for my local one, and tzname is reasonable — the same valu

doc: Update for macOS 12, 13, 14

2024-06-17 Thread Bruno Haible
The Gnulib documentation regarding macOS has not been updated for 3 years. This patch does it. To do so, I first augmented the symbols and headers database in https://git.savannah.gnu.org/gitweb/?p=gnulib/maint-tools.git;a=tree;f=platforms Then, I used the config.cache and config.log files from t

Re: [PATCH] useless-if-before-free: Check for nullptr.

2024-06-17 Thread Collin Funk
Hi Bruno, Bruno Haible wrote: > The point is to produce a reasonable 'useless-if-before-free --version' > output. > > This is where this thread started. [1] Ah, I see. I figured the typical 'git log' or 'sed ... ChangeLog' would be used like gnulib-tool.sh, all-modules, etc. But those are only

Re: [PATCH] useless-if-before-free: Check for nullptr.

2024-06-17 Thread Bruno Haible
Collin Funk asked: > > -my $VERSION = '2022-01-27 18:51'; # UTC > > +my $VERSION = '2024-06-17 03:44'; # UTC > > What is the point of time stamping the file? The point is to produce a reasonable 'useless-if-before-free --version' output. This is where this thread started. [1] Bruno [1] https:/