Re: gnulib-tool.py: Handle absolute path checks consistently.

2024-06-09 Thread Bruno Haible
Collin Funk wrote: > Lets just use os.path.isabs() and let it deal with > platform related stuff. OK. I assume that if someone uses gnulib-tool with Cygwin, and has a native Windows Python installation, they will report problems. Then we can decide what to do. (Probably there are few people who d

gnulib-tool.py: Handle absolute path checks consistently.

2024-06-09 Thread Collin Funk
A few functions in constants.py check for drive prefixes where other code does not. Lets just use os.path.isabs() and let it deal with platform related stuff. I suppose path.startswith('/') would probably work too but it is less clear and would make Windows (without Cygwin) support harder in the fu

Re: c32ispunct tests: Avoid a test failure on Solaris 11 OmniOS

2024-06-09 Thread Collin Funk
Bruno Haible writes: >> Would it make sense to use __illumos__ here? > > No, it is too new. [1] Makes sense. Feel free to change the ones I added previously to __sun if you would like. Collin

c32width tests: Avoid a test failure on Solaris 11 OpenIndiana, OmniOS

2024-06-09 Thread Bruno Haible
On Solaris 11 OpenIndiana and Solaris 11 OmniOS, I now (after the c32rtomb sanity check addition) see a test failure: FAIL: test-c32width === ../../tests/test-c32width.c:98: assertion 'c32width (0x20369) == 2' failed ../../build-aux/test-driver: line 114: 15481: Abort(coredump) FA

Re: c32ispunct tests: Avoid a test failure on Solaris 11 OmniOS

2024-06-09 Thread Bruno Haible
Hi Collin, > > -#if !(defined __FreeBSD__ || defined __DragonFly__) > > +#if !(defined __FreeBSD__ || defined __DragonFly__ || defined > > __sun) > > Would it make sense to use __illumos__ here? No, it is too new. [1] Bruno [1] https://lists.gnu.org/archive/html/bug-gnulib/202

Re: c32ispunct tests: Avoid a test failure on Solaris 11 OmniOS

2024-06-09 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > -#if !(defined __FreeBSD__ || defined __DragonFly__) > +#if !(defined __FreeBSD__ || defined __DragonFly__ || defined __sun) Would it make sense to use __illumos__ here? Not sure if you tested this on regular Oracle Solaris. Collin

c32ispunct tests: Avoid a test failure on Solaris 11 OmniOS

2024-06-09 Thread Bruno Haible
On a Solaris 11 OmniOS machine with a zh_CN.GB18030 locale, libunistring (or a testdir without module 'uchar-c23') also shows this test failure: FAIL: test-c32ispunct.sh ../../gltests/test-c32ispunct.c:283: assertion 'is != 0' failed ../../gltests/test-c32ispunct.c:302: a

c32rtomb: Add a sanity check, working around Solaris 11 OmniOS

2024-06-09 Thread Bruno Haible
On a Solaris 11 OmniOS machine with a zh_CN.GB18030 locale, libunistring (or a testdir without module 'uchar-c23') shows 8 test failures: FAIL: test-c32isalnum.sh ../../gltests/test-c32isalnum.c:224: assertion 'is == 0' failed Stack trace: 0x4048fc main ../../glt