call_once tests: Fix link error on mingw

2024-05-29 Thread Bruno Haible
Compiling a testdir for 'call_once' on mingw, I get link errors due to 'mtx_lock' and 'mtx_unlock'. This patch fixes it. 2024-05-29 Bruno Haible call_once tests: Fix link error on mingw. * modules/call_once-tests (Depends-on): Add mtx. diff --git a/modules/call_once-tests b/

mbfile tests: Avoid test failure on mingw

2024-05-29 Thread Bruno Haible
On mingw, I see this test failure: FAIL: test-mbfile.sh ../../gltests/test-mbfile.c:49: assertion 'mb_len (next) == 2' failed Stack trace: 0xbd502c13 main ../../gltests/test-mbfile.c:49 The cause is that setlocale has not installed an UTF-8 locale, but a CP1252 local

pthread-once tests: Fix crash on mingw

2024-05-29 Thread Bruno Haible
In a mingw build of a testdir of 'asyncsafe-spin' and some other modules, I see a crash of test-pthread-once2. The cause is that this test program uses the pthread_rwlock_* functions from the winpthreads library, which is known to be broken. This patch fixes it. 2024-05-29 Bruno Haible

Re: pthread-once: Work around Cygwin 3.5.3 bug

2024-05-29 Thread Bruno Haible
I wrote: > On Cygwin 3.5.3, programs that use pthread_once or call_once may hang > indefinitely. This is visible also in a testdir for module 'file-has-acl': test-lock hangs (and fails through timeout). This patch fixes it. 2024-05-29 Bruno Haible lock: Work around Cygwin 3.5.3 bug.

Re: [PATCH] gnulib-tool.py: Simplify creation of module shell ids.

2024-05-29 Thread Bruno Haible
Collin Funk wrote: > I've committed this patch adding the ASCII flag. Thanks.

Re: [PATCH] gnulib-tool.py: Simplify creation of module shell ids.

2024-05-29 Thread Collin Funk
Collin Funk writes: > In the documentation for \w it states [2]: > > Matches [a-zA-Z0-9_] if the ASCII flag is used. I've committed this patch adding the ASCII flag. I noticed some other duplicated regular expressions that could probably be simplified. I'll take a look at seeing if re.ASCII

Re: [PATCH] gnulib-tool.py: Simplify creation of module shell ids.

2024-05-29 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > But that's not the same thing: The previous code made sure that > module names with non-ASCII characters use the MD5 hash code. > The new code does not: > re.match(re.compile(r'^[abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_]*$'),'abcäöü') >

Re: [PATCH] gnulib-tool.py: Simplify creation of module shell ids.

2024-05-29 Thread Bruno Haible
Hi Collin, > -# List of characters allowed in shell identifiers. > -shell_id_chars: ClassVar[str] = > 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_' > +# Regular expression matching module names that can be used as shell ids. > +shell_id_pattern: ClassVar[re.Pat