fenv-exceptions-state-c99: Fix test failures with Oracle cc 12.6

2024-03-28 Thread Bruno Haible
With Oracle Developer Studio 12.6 cc, on Linux/glibc, I see these two test failures: FAIL: test-fenv-except-state-2 == ../../gltests/test-fenv-except-state-2.c:57: assertion 'fesetexceptflag (&saved_flags_1, FE_INVALID | FE_DIVBYZERO | FE_OVERFLOW | FE_UNDERFLOW) == 0

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-28 Thread Collin Funk
Hi Bruno, On 3/28/24 4:05 PM, Bruno Haible wrote: > Since the program uses a mix between OOP and functional style, it is > reasonable to think about whether a certain data path is better implemented > through OOP (with an object holding a private sub-object) or better done > in a functional style

mcel tests: Fix test failure with Oracle cc 12.6

2024-03-28 Thread Bruno Haible
With cc from Oracle Developer Studio 12.6 on Linux, I see a test failure: FAIL: test-mcel === FAIL test-mcel (exit status: 1) This compiler does not implement the rule (from ISO C 99 ยง 5.1.2.2.3) that the implicit return value from main() is 0. How to reproduce: ===

Re: gnulib-tool.py and gnulib-tool.sh disagree on AC_REQUIRE([AM_PROG_CC_C_O])

2024-03-28 Thread Bruno Haible
Collin Funk wrote: > I didn't realize Automake 1.14 was released in 2013. > Should be safe I assume. :) Well, CentOS 7 still uses Automake 1.13.x [1][2] and it not yet end-of-life (see maint-tools/end-of-life.txt). But it will be EOL in 3 months, and therefore we are estimating that there are _few

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-28 Thread Bruno Haible
Hi Collin, > This patch fixes the extra line printed by gnulib-tool.py: > > $ diff -u test-oath-toolkit-4.out tmp758920-out > --- test-oath-toolkit-4.out 2024-03-28 13:17:54.441485990 -0700 > +++ tmp758920-out 2024-03-28 14:36:28.290120583 -0700 > @@ -194,5 +194,6 @@ >- mention "gl" in

Re: gnulib-tool.py and gnulib-tool.sh disagree on AC_REQUIRE([AM_PROG_CC_C_O])

2024-03-28 Thread Collin Funk
On 3/28/24 3:40 PM, Bruno Haible wrote: > Basically: > - With --gnu-make, func_emit_lib_Makefile_am invokes autoconf, in order to > get the list of AC_SUBSTed variables, and that requires gnulib-comp.m4 to > be present. > - Without --gnu-make, it's the other way around: we need > fu

Re: gnulib-tool.py and gnulib-tool.sh disagree on AC_REQUIRE([AM_PROG_CC_C_O])

2024-03-28 Thread Bruno Haible
Hi Collin, > Could you please help me find the correct solution to this issue? > > In a few of the test cases there is the following diff in > gnulib-comp.m4: > > $ diff -u ./test-oath-toolkit-2.result/liboath/gl/m4/gnulib-comp.m4 > tmp72-result/liboath/gl/m4/gnulib-comp.m4 > --- ./test-oat

gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-28 Thread Collin Funk
This patch fixes the extra line printed by gnulib-tool.py: $ diff -u test-oath-toolkit-4.out tmp758920-out --- test-oath-toolkit-4.out 2024-03-28 13:17:54.441485990 -0700 +++ tmp758920-out 2024-03-28 14:36:28.290120583 -0700 @@ -194,5 +194,6 @@ - mention "gl" in SUBDIRS in Makefile.a

pthread-h: Fix override of pthread_spinlock_t with non-GNU compilers

2024-03-28 Thread Bruno Haible
Compiling a testdir with Oracle Developer Studio 12.6 (SunPRO C) on Linux, I get this compilation error: CC -m64 -O -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -I. -I../../gltests -I.. -DGNULIB_STRICT_CHECKING=1 -DIN_GNULIB_TESTS=1 -I. -I../../gltests -I.. -I../../gltests/.. -I../gllib -I../../

gnulib-tool.py and gnulib-tool.sh disagree on AC_REQUIRE([AM_PROG_CC_C_O])

2024-03-28 Thread Collin Funk
Hi Bruno, Could you please help me find the correct solution to this issue? In a few of the test cases there is the following diff in gnulib-comp.m4: $ diff -u ./test-oath-toolkit-2.result/liboath/gl/m4/gnulib-comp.m4 tmp72-result/liboath/gl/m4/gnulib-comp.m4 --- ./test-oath-toolkit-2.resul

havelib: Recognize ELF platform despite SunPRO C on Linux

2024-03-28 Thread Bruno Haible
Building a testdir on Linux with Oracle Developer Studio 12.6 (which includes the SunPRO C compiler), I see this configure finding: checking for ELF binary format... no This patch fixes it. 2024-03-28 Bruno Haible havelib: Recognize ELF platform despite SunPRO C on Linux. *

Re: [PATCH] gnulib-tool.py: Fix missing 'gnulib-cache.m4' in EXTRA_DIST.

2024-03-28 Thread Bruno Haible
Collin Funk wrote: > This loop in the Python version was written incorrectly. Missing the > 'not' and 'isfile': Thanks. Applied, with corrected indentation. Bruno

[PATCH] gnulib-tool.py: Fix missing 'gnulib-cache.m4' in EXTRA_DIST.

2024-03-28 Thread Collin Funk
This patch fixes this diff in a few of the import tests: $ diff -u ./test-oath-toolkit-4.result/libpskc/gl/Makefile.am tmp529642-result/libpskc/gl/Makefile.am --- ./test-oath-toolkit-4.result/libpskc/gl/Makefile.am 2024-03-28 02:51:26.031078064 -0700 +++ tmp529642-result/libpskc/gl/Makefile.am

Re: [PATCH] gnulib-tool.py: Fix whitespace in gnulib-comp.m4.

2024-03-28 Thread Bruno Haible
Hi Collin, > In the the ./import-tests/test-wget2-1.sh output of gnulib-comp.m4 > there is this whitespace diff: > > $ diff -u ./test-wget2-1.result/m4/gnulib-comp.m4 > tmp115629-result/m4/gnulib-comp.m4 > --- ./test-wget2-1.result/m4/gnulib-comp.m4 2024-03-27 03:05:35.527866182 > -0700 > +++