Re: [PATCH] gnulib-tool.py: Improve output of testdir Makefile.am.

2024-02-21 Thread Collin Funk
On 2/21/24 5:55 PM, Bruno Haible wrote: > Yes, please. But for long-time storage I'm not a fan of commit ids > (I've seen too many packages move from one VCS to another VCS in the past...), > but rather like in > https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=948345cceab85ab699910

Re: [PATCH] gnulib-tool.py: Improve output of testdir Makefile.am.

2024-02-21 Thread Bruno Haible
Hi Collin, > Should I mention the > commit being removed from the gnulib-tool.py.TODO file in the ChangeLog > and commit message? I think it might help tracking down any issues that > might come up later. Yes, please. But for long-time storage I'm not a fan of commit ids (I've seen too many packa

Re: [PATCH] gnulib-tool.py: Improve output of testdir Makefile.am.

2024-02-21 Thread Collin Funk
On 2/21/24 4:10 PM, Bruno Haible wrote: > I'm a bit unhappy with this way of working. Your patches surely > go into the right direction, but I would prefer to receive them > 1) one by one, > 2) with the corresponding gnulib-tool.py.TODO entry removal. > Because if we don't keep track of which e

new module 'c-strtof'

2024-02-21 Thread Bruno Haible
This patch adds a module 'c-strtof', similar to 'c-strtod' and 'c-strtold'. GNU poke needs this. 2024-02-21 Bruno Haible c-strtof: New module. * lib/c-strtod.h (c_strtof): New declaration. * lib/c-strtod.c: Support FLOAT. * lib/c-strtof.c: New file. * m

c-strtold: Use strtold_l when available

2024-02-21 Thread Bruno Haible
This patch fixes a typo that had the effect that the function strtold_l was not used, even if available. 2024-02-21 Bruno Haible c-strtold: Use strtold_l when available (regr. 2019-01-31). * lib/c-strtod.c: Fix typo: HAVE_GOOD_STRTOLD_L was never defined. diff --git a/lib/c-s

new module 'strtof'

2024-02-21 Thread Bruno Haible
These two patches add a module 'strtof', similar to 'strtod' and 'strtold'. 2024-02-21 Bruno Haible strtof: Add tests. * tests/test-strtof.c: New file, based on tests/test-strtod.c. * tests/test-strtof1.sh: New file, based on tests/test-strtod1.sh. * tests/test

strtod, strtold tests: Avoid a test failure on native Windows

2024-02-21 Thread Bruno Haible
In a testdir of strtod and strtold, I see test failures on native Windows (mingw, MSVC 14). The reason appears to be that the native setlocale() function there ignores the environment variables that the shell script sets; it looks only at the system settings. This patch fixes it. 2024-02-21 Bru

Re: [PATCH] gnulib-tool.py: Improve output of testdir Makefile.am.

2024-02-21 Thread Bruno Haible
Hi Collin, > I am hesitant to change the TODO file until we can better testing > everything. My main test case is as written at the top of gnulib-tool.py.TODO: A particular checkout of wget2, with a particular gnulib-tool invocation. Make 20 or 50 copies of this directory; then run each gnulib-to

[PATCH v2] libtextstyle: Add --with-libtextstyle option

2024-02-21 Thread Raul E Rangel
libtextstyle is currently treated as an automagic dependency. It gets linked if it is present, and doesn't if it's not. This change adds a --with-libtextstyle option so that the dependency can be explicitly enabled or disabled. See: https://bugs.gentoo.org/925100 Signed-off-by: Raul E Rangel ---

[PATCH] libtextstyle: Add --with-libtextstyle option

2024-02-21 Thread Raul E Rangel
libtextstyle is currently treated as an automagic dependency. It gets linked if it is present, and doesn't if it's not. This change adds a --with-libtextstyle option so that the dependency can be explicitly enabled or disabled. See: https://bugs.gentoo.org/925100 Signed-off-by: Raul E Rangel ---

[PATCH] gnulib-tool.py: Improve output of testdir Makefile.am.

2024-02-21 Thread Collin Funk
Slowly trying to sync the output of gnulibtool.py. I am hesitant to change the TODO file until we can better testing everything. This patch should (hopefully) fix the following commit entries: 16c3e1868a15a5946c0f0f7df6e107e9b3c6389d d465dd70e1ec5fe332160780eb66511028f5897b 39d08c09b444db57f45804b

Re: [PATCH] gnulib-tool.py: Comment out undefined variable.

2024-02-21 Thread Bruno Haible
Collin Funk wrote: > It seems that your commit 01cd78f9d682ff75cc5ab1c2d21b911bdd9215b8 > accidentally caused this. While cleaning up the handling of paths, I > think you accidentally removed this variable. Yep. Thanks for the fix! Applied. Bruno

Re: [PATCH] gnulib-tool.py: Comment out undefined variable.

2024-02-21 Thread Collin Funk
On 2/21/24 8:08 AM, Bruno Haible wrote: > I suppose it is not much more work to fix this line for real? > Hints: > - If there is no variable 'saved_auxdir' in this function, maybe there > is a variable 'auxdir'? > - What do the comments hint at? > - What does the history of the file ('git

Re: [PATCH] gnulib-tool.py: Comment out undefined variable.

2024-02-21 Thread Bruno Haible
Collin Funk wrote: > self.config.setAuxDir(saved_auxdir) > > NameError: name 'saved_auxdir' is not defined > > I commented out the offending line instead of removing it just in case > it is useful in the future. I suppose it is not much more work to fix

Re: printf with %n directives

2024-02-21 Thread Bruno Haible
Yesterday I wrote: > The way I propose to do it: > - Remove the support for the %n directives from all *printf* modules > by default. > - Add a new module 'printf-with-n-directive' that re-enables this support > in all these modules. > - Add a NEWS entry to notify the packages. > > T

Re: *printf-posix: Avoid crash in a configure test

2024-02-21 Thread Bruno Haible
> 2024-02-20 Bruno Haible > > *printf-posix: Avoid crash in a configure test. > * m4/printf.m4 (gl_PRINTF_DIRECTIVE_N): In the test program, catch the > SIGABRT signal, so that the program does not dump core. There's another configure test that also exercises %n. 2024-02-21

[PATCH] gnulib-tool.py: Comment out undefined variable.

2024-02-21 Thread Collin Funk
I started to look at the Python gnulib-tool and ran into this error that should be easily reproducible: [collin@debian src]$ gnulib-tool.py --create-testdir --dir test dummy Module list with included dependencies (indented): dummy File list: lib/dummy.c m4/00gnulib.m4 m4/gnulib-common.m4