Re: [PATCH] syntax-check rules to check for links in README

2023-06-05 Thread Pierre Labastie
On Mon, 2023-06-05 at 22:38 +0200, Jose E. Marchesi wrote: > > The GNU Coding Standards says: > > The 'README' file should refer to the file 'INSTALL', which should >   contain an explanation of the installation procedure. > > The 'README' file should also refer to the file which conta

[PATCH] syntax-check rules to check for links in README

2023-06-05 Thread Jose E. Marchesi
The GNU Coding Standards says: The 'README' file should refer to the file 'INSTALL', which should contain an explanation of the installation procedure. The 'README' file should also refer to the file which contains the copying conditions. The GNU GPL, if used, should be in a file

Re: manywarnings: Overhaul documentation

2023-06-05 Thread Paul Eggert
On 2023-06-04 15:18, Bruno Haible wrote: +Do this once with optimizations (@code{CPPFLAGS=-O2}) and once with no +optimizations (@code{CPPFLAGS=-O0} or @code{CPPFLAGS=-ggdb}). -ggdb shouldn't affect warnings, no? More generally, the advice shouldn't recommend -O0 specifically; it should reco

Re: gcc -Wall vs. manywarnings

2023-06-05 Thread Paul Eggert
On 2023-06-04 11:38, Bruno Haible wrote: * Evaluating warnings is one possible way to improve the quality of a package. Alternatively, I could have spent the several days on a more elaborate fuzzing approach, or on writing more unit tests, or on improving the valgrind integration etc. —

posix_spawn-internal: Fix a warning

2023-06-05 Thread Bruno Haible
Compiling GNU gettext on CentOS 5 (gcc 4.1.2), I see this warning: gettext-tools/gnulib-lib/spawni.c:861: warning: ignoring #pragma GCC diagnostic [-Wunknown-pragmas] This particular pragma is only supported without warning for gcc ≥ 4.2. 2023-06-05 Bruno Haible posix_spawn-interna

file-has-acl: Fix compilation error on Slackware 13

2023-06-05 Thread Bruno Haible
Testing GNU gettext's portability on Slackware 13, I get a compilation error: file-has-acl.c: In function 'file_has_acl': file-has-acl.c:216:30: error: 'XATTR_NAME_POSIX_ACL_ACCESS' undeclared (first use in this function) file-has-acl.c:216:30: note: each undeclared identifier is reported only on

Fix bugs on mingw when module dirfd is in use

2023-06-05 Thread Bruno Haible
Building gettext on mingw, I see these warnings: gettext-tools/gnulib-lib/getcwd.c:293:36: warning: passing argument 1 of 'closedir' from incompatible pointer type [-Wincompatible-pointer-types] gettext-tools/gnulib-lib/getcwd.c:311:17: warning: assignment from incompatible pointer type [-Wincom