Re: [PATCH] time: strftime_l: Use malloc rather than an unbounded alloca.

2023-05-22 Thread Joe Simmons-Talbott
On Wed, May 17, 2023 at 10:40:05AM -0700, Paul Eggert wrote: > On 2023-05-17 04:04, Adhemerval Zanella Netto wrote: > > do you think it would be feasible to assume > > _POSIX_TZNAME_MAX or 48 (for Factory zone) to avoid the malloc call on > > strftime_l? > > ALthough it's technically feasible, it'

Re: [PATCH 3/4] git-merge-changelog: prefer idx_t

2023-05-22 Thread Bruno Haible
Thanks for the many improvements, Paul. Nevertheless, I feel that a few code style changes are in order: * I don't much like side effects inside parenthesized expressions, if the side effect and the expression are not semantically related: if (mapping->index_mapping_reverse[--