Re: bug#63632: diffutils 3.10: test suite is failing in test-strtoll unit

2023-05-21 Thread Bruno Haible
Paul Eggert wrote: > > test-strtoll.c:290: assertion 'ptr == input + 1' failed > > I don't have that problem when I run the tests on Fedora 38 x86-64. What > platform are you using, and how did you configure it? Possibly the reporter is using a glibc git checkout, and is encountering https://sou

Re: bug#63632: diffutils 3.10: test suite is failing in test-strtoll unit

2023-05-21 Thread Paul Eggert
On 2023-05-21 14:50, Tomasz Kłoczko wrote: test-strtoll.c:290: assertion 'ptr == input + 1' failed I don't have that problem when I run the tests on Fedora 38 x86-64. What platform are you using, and how did you configure it? I do see a potential on the Gnulib side, which I attempted to fix

[PATCH 4/4] git-merge-changelog: port to size_t padding

2023-05-21 Thread Paul Eggert
* lib/git-merge-changelog (entry_hashcode): As a nicety, Prefer SIZE_WIDTH to computing it ourselves. --- ChangeLog | 4 lib/git-merge-changelog.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index eb6066b42c..8b29eed568 100644 --

[PATCH 2/4] git-merge-changelog: ssize_t → ptrdiff_t

2023-05-21 Thread Paul Eggert
Prefer ptrdiff_t to ssize_t, as per . * lib/git-merge-changelog.c (struct entries_mapping) (entries_mapping_get, entries_mapping_reverse_get) (compute_mapping, struct edit, struct differences, OFFSET) (OFFSET_MAX, EXTRA_CONTEXT_F

[PATCH 3/4] git-merge-changelog: prefer idx_t

2023-05-21 Thread Paul Eggert
* lib/git-merge-changelog.c: Include idx.h. (struct entry, entry_create, entry_hashcode) (struct changelog_file, read_changelog_file) (entries_mapping_get, entries_mapping_reverse_get) (compute_mapping, struct edit, struct differences) (compute_differences, find_paragraph_end) (try_split_merged_ent

[PATCH 1/4] git-merge-changelog: port to ssize_t padding

2023-05-21 Thread Paul Eggert
* lib/git-merge-changelog.c (OFFSET_MAX): New macro, as a nicety. --- ChangeLog | 5 + lib/git-merge-changelog.c | 1 + 2 files changed, 6 insertions(+) diff --git a/ChangeLog b/ChangeLog index 9cdb603b9b..bed79ab76b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2023

Re: [PATCH 1/7] limits-h: define SSIZE_MAX

2023-05-21 Thread Bruno Haible
Paul Eggert wrote: > * doc/posix-headers/limits.texi (limits.h): Document this. > * lib/limits.in.h (SSIZE_MAX): Define if not already defined. When I add a unit test for this, I see that the assertion static_assert (TYPE_MAXIMUM (ssize_t) == SSIZE_MAX); fails on 64-bit MSVC 14. That's because