On 5/9/23 20:57, Bruno Haible wrote:
Bernhard Voelker wrote:
I noticed the issue because the following "very-expensive" tests failed
(which succeeded with coreutils-9.3):
FAIL: tests/rm/ext3-perf
FAIL: tests/rm/many-dir-entries-vs-OOM
Did you notice these failures by chance, or do you
KO Myung-Hun wrote:
> > dirfd is specified at
> > https://pubs.opengroup.org/onlinepubs/9699919799/functions/dirfd.html
> > Which says that if "The dirp argument does not refer to a valid directory
> > stream"
> > the function may fail with error EINVAL. It may alternatively simply crash
> > ("the
Bruno Haible wrote:
> KO Myung-Hun wrote:
>>> @@ -78,11 +82,17 @@ _gl_unregister_dirp_fd (int fd)
>>> int
>>> dirfd (DIR *dir_p)
>>> {
>>> +#if GNULIB_defined_DIR
>>> + int fd = dir_p->fd_to_close;
>>
>> dirfd() allows to take an invalid `dir_p' ?
>
> No; this must be a misunderstanding.
>
