RE: [PATCH] fix NFSv4 acl detection on F39

2023-05-03 Thread Ondrej Valousek
Well, what if we try to create a decently sized stack buffer (say 256 chars) - in 99% we fit into that buffer (actually I can't image we would ever need more), and if we do not fit into that buffer we just return 1 (most likely some sort of acl is likely there). That would allow for a nice and s

Re: lib/dirfd.c: compiler warning: unused parameter

2023-05-03 Thread Bruno Haible
Bjarni, Paul Eggert wrote: > Please look into config.log for that. To make things clear and quick for us, please attach the generated files - config.status, - config.log. Bruno

Re: lib/dirfd.c: compiler warning: unused parameter

2023-05-03 Thread Paul Eggert
On 5/3/23 17:24, Bjarni Ingi Gislason wrote: File "/etc/os-release" shows PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" Why did 'configure' decide to replace dirfd? Please look into config.log for that. As things stand, it's likely that groff doesn't act correctly on your platform. That be

Re: lib/dirfd.c: compiler warning: unused parameter

2023-05-03 Thread Bjarni Ingi Gislason
On Thu, May 04, 2023 at 01:59:07AM +0200, Bruno Haible wrote: > Bjarni Ingi Gislason wrote: > > The compiler reports: > > > > CC lib/libgnu_a-dirfd.o > > ../lib/dirfd.c: In function 'rpl_dirfd': > > ../lib/dirfd.c:83:13: warning: unused parameter 'dir_p' > > [-Wunused-parameter] > >8

Re: lib/dirfd.c: compiler warning: unused parameter

2023-05-03 Thread Bruno Haible
Bjarni Ingi Gislason wrote: > The compiler reports: > > CC lib/libgnu_a-dirfd.o > ../lib/dirfd.c: In function 'rpl_dirfd': > ../lib/dirfd.c:83:13: warning: unused parameter 'dir_p' > [-Wunused-parameter] >83 | dirfd (DIR *dir_p) > |~^ On which platform? Bruno

Re: [PATCH] fix NFSv4 acl detection on F39

2023-05-03 Thread Paul Eggert
On 5/2/23 22:44, Ondrej Valousek wrote: What's the reason for doing that? I wanted to save syscalls, not to create more. Yes, and the approach I suggested will save a syscall in 99.99% of the cases, as there will be just one llistxattr syscall where your approach has two. In a very few (pract

lib/dirfd.c: compiler warning: unused parameter

2023-05-03 Thread Bjarni Ingi Gislason
Software: groff, private repository that is updated regulary with GNU gnulib. with gnulib_modules=" git-version-gen havelib wcwidth fprintf-posix snprintf vsnprintf stdint setlocale vsnprintf-posix warnings gen-header manywarnings mkstemp fmod getcwd

vasnprintf, vasnwprintf: Make '0' flag handling more ISO C compliant

2023-05-03 Thread Bruno Haible
I had thought that the result of sprintf(..., "%015.10x", ...) was unspecified by POSIX and ISO C. But in fact ISO C 99 § 7.19.6.1.(6) ISO C 11 § 7.21.6.1.(6) ISO C 23 § 7.23.6.1.(6) all say: "For d, i, o, u, x, and X conversions, if a precision is specified, the 0 flag is ignored." And likew