Re: [PATCH 3/3] fclose: pacify gcc -Wanalyzer-file-leak

Paul Eggert wrote: > diff --git a/m4/fclose.m4 b/m4/fclose.m4 > index dc021dd9f3..74b7df0a77 100644 > --- a/m4/fclose.m4 > +++ b/m4/fclose.m4 > @@ -31,6 +31,10 @@ AC_DEFUN([gl_FUNC_FCLOSE], >*) REPLACE_FCLOSE=1 ;; > esac >fi > + > + if test $REPLACE_FCLOSE = 1; then > +REPLACE

Re: Portability problem

Bruno Haible writes: > Hi Po Lu, > >> Gnulib generates non-portable shell constructs, which interferes with >> configuring Emacs on Solaris 10 using /bin/sh. >> >> See >> >> https://lists.gnu.org/archive/html/bug-gnu-emacs/2023-04/msg01590.html > > Indeed, the Autoconf manual >

Re: Portability problem

Thanks for doing that patch, Bruno. I also replied at in the perhaps vain hope that we needn't worry about using Solaris 10 /bin/sh to run 'configure' or Makefile snippets.

Re: Portability problem

Hi Po Lu, > Gnulib generates non-portable shell constructs, which interferes with > configuring Emacs on Solaris 10 using /bin/sh. > > See > > https://lists.gnu.org/archive/html/bug-gnu-emacs/2023-04/msg01590.html Indeed, the Autoconf manual

Portability problem

Gnulib generates non-portable shell constructs, which interferes with configuring Emacs on Solaris 10 using /bin/sh. See https://lists.gnu.org/archive/html/bug-gnu-emacs/2023-04/msg01590.html Would this be a sufficient solution? I've not had a chance to test it yet. 2023-04-26 Po Lu

expm1 tests: Avoid test failure on 32-bit mingw

On 32-bit mingw I see this test failure: FAIL: test-expm1 ../../gltests/test-expm1.h:49: assertion 'y >= - x' failed FAIL test-expm1.exe (exit status: 3) The failure disappears when compiling without -O2. This is a hint that, again, it's an issue w.r.t. the 64-bit 'double' and t

poll tests: Avoid test failure on native Windows

On native Windows, I see the 'test-poll' test fail always: FAIL: test-poll === Unconnected socket test... passed Connected sockets test... passed General socket test with fork... passed Pipe test... failed (expecting POLLHUP after shutdown) FAIL test-poll.exe (exit status: 1) Since o

Re: dfa tests: Fix test failure on mingw

I did: > + set_binary_mode (STDOUT_FILENO, O_BINARY); Oops, that produces a compilation error (reported by the 'grep' CI and the 'sed' CI): ../../gltests/test-dfa-match-aux.c: In function ‘main’: ../../gltests/test-dfa-match-aux.c:61:20: error: ‘STDOUT_FILENO’ undeclared (first use in this func