Re: AC_SYS_LARGEFILE_REQUIRED vs. AC_SYS_YEAR2038_REQUIRED on MSVC

2023-04-14 Thread Paul Eggert
On 4/14/23 09:02, Bruno Haible wrote: On the other hand, when I create a gnulib testdir with an AC_SYS_YEAR2038_REQUIRED invocation: ./gnulib-tool --create-testdir --dir=... --single-configure year2038-required stat it fails during the configure stage on MSVC (both 64-bit and 32-bit): It so

Re: Some more reminders

2023-04-14 Thread Paul Eggert
This patch doesn't look right, since it causes year2038 to depend on a bunch of modules like sys_shm that most programs don't need. I don't know why year2038 should depend on sys_shm etc. But whatever the reason, let's remove those dependencies as they're more likely to cause problems than cur

Re: [PATCH 2/4] year2038: configure earlier

2023-04-14 Thread Paul Eggert
On 4/14/23 03:02, Bruno Haible wrote: * modules/year2038: Put AC_SYS_YEAR2038 in configure.ac-early since it can affect CPPFLAGS with _TIME_BITS=64. I find this commit message misleading. AC_SYS_YEAR2038 does not affect CPPFLAGS Thanks, I reworded that in the ChangeLog file.

Re: year 2038 support: fix for mingw

2023-04-14 Thread Paul Eggert
Thanks, I installed those into Gnulib and into Autoconf.

isnan: Fix compilation error in C++ mode on FreeBSD 13.2

2023-04-14 Thread Bruno Haible
Building a testdir of all of Gnulib on FreeBSD 13.2, I see a compilation error: depbase=`echo test-nullptr-c++.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; c++ -ferror-limit=0 -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -I. -I../../gltests -I.. -DGNULIB_STRICT_CHECKING=1 -DIN_GNULIB_TESTS=1 -I. -I

filemode: Fix double-inclusion guard

2023-04-14 Thread Bruno Haible
The macro FILEMODE_H_ is not defined anywhere. The purpose of testing it in filemode.h was therefore most probably a double-inclusion guard. 2023-04-14 Bruno Haible filemode: Fix double-inclusion guard. * lib/filemode.h: Make the double-inclusion guard actually work. diff --g

AC_SYS_LARGEFILE_REQUIRED vs. AC_SYS_YEAR2038_REQUIRED on MSVC

2023-04-14 Thread Bruno Haible
When I create a gnulib testdir with the an AC_SYS_LARGEFILE_REQUIRED invocation: ./gnulib-tool --create-testdir --dir=... --single-configure largefile-required stat it configures and builds fine on MSVC (both 64-bit and 32-bit). That is OK because the AC_SYS_LARGEFILE[_REQUIRED] macro sets the

year 2038 support: fix for mingw

2023-04-14 Thread Bruno Haible
When running a gnulib testdir of module 'year2038' on 32-bit mingw, I see a 'configure' failure: ... checking for i686-w64-mingw32-gcc option to enable large file support... -D_FILE_OFFSET_BITS=64 checking for i686-w64-mingw32-gcc option to enable timestamps after Jan 2038... -D__MINGW_USE_VC200

Re: Some more reminders

2023-04-14 Thread Bruno Haible
I wrote: > In POSIX:2008, the application can > get the time_t type defined by including one of the following files: Likewise in POSIX:2018. > Gnulib should therefore override each of these include files and > make sure (with the possible _TIME_BITS definition) is > included first. Done as foll

Re: [PATCH 2/4] year2038: configure earlier

2023-04-14 Thread Bruno Haible
Paul Eggert wrote: > * modules/year2038: Put AC_SYS_YEAR2038 in configure.ac-early > since it can affect CPPFLAGS with _TIME_BITS=64. I find this commit message misleading. AC_SYS_YEAR2038 does not affect CPPFLAGS; it puts the _TIME_BITS definition into config.h instead. But I agree that it needs