Re: functions with empty parameter lists

On 2/6/23 14:48, Bruno Haible wrote: * In the long term, assuming ISO C 23 and newer, writing (void) is just clutter in those places where one can just as well write (). The keyword 'void' here only tells that the programmer has accomplished the migration from K&R C to ISO C 23,

Re: Gnulib and nullptr

On 2/6/23 15:16, Bruno Haible wrote: Ignoring or underestimating the "barrier to entry" issue was my biggest mistake in GNU clisp development so far. Fair enough, but surely there are differences between the clisp and Gnulib cases. In C++ there are more advantages to nullptr (so more of a pr

Re: [g.branden.robin...@gmail.com: macOS 12.6.3 and vasnprintf compilation failure]

See https://savannah.gnu.org/bugs/index.php?63078 I renamed the file "groff/src/include/assert.h" in my privat branch of groff to ".../assert.h.original".

Re: Differences between "module license" and "file license"

Paul, Did you intend to put the 'alignalloc' module under GPL or LGPLv2+, when adding it on 2022-01-23? Bjarni Ingi Gislason wrote: > Module LicenseFile License File name > = == = > LGPLv2+ GPLlib/alignall

Re: [g.branden.robin...@gmail.com: macOS 12.6.3 and vasnprintf compilation failure]

Hi Branden, > A problem immediately arose on macOS 12.6.3. It's our good friend > vasnprintf again. Logs are available on Savannah[2]. > > lib/vasnprintf.c:411:16: error: expected parameter declarator > static_assert (sizeof (mp_limb_t) * CHAR_BIT == GMP_LIMB_BITS); >^ > lib/vas

Differences between "module license" and "file license"

Debian testing (bookworm/sid) Compiling in the "build" directory: /usr/local/bin/make GNU Make 4.4.0.90 Built for x86_64-pc-linux-gnu Copyright (C) 1988-2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you

Re: Gnulib and nullptr

Paul Eggert wrote: > > The diffutils patch shows that the possible bugs had already been caught > > Sure, but the idea is to make such bugs less likely in the future, by > encouraging the use of nullptr now. The gain here is small (it's only varargs and contrived cases), whereas ... > > 2) We

Re: functions with empty parameter lists

Paul Eggert wrote: > static void > -init_sh_quoting_options () > +init_sh_quoting_options (void) > { Your change prompted me to wonder whether this patch should be generalized, that is, whether all function definitions with empty parameter lists should be changed to use this style. Like in the a

Re: Gnulib and nullptr

On Mon, Feb 06, 2023 at 04:22:46PM -0500, Jeffrey Walton wrote: > On Sun, Feb 5, 2023 at 9:45 PM Paul Eggert wrote: > > > > On 2023-02-05 18:00, Bruno Haible wrote: > > > Why call it 'c-nullptr', not 'nullptr'? > > > > I was worried about C++, not that I know much about it, and operated by > > ana

Re: Gnulib and nullptr

On Sun, Feb 5, 2023 at 9:45 PM Paul Eggert wrote: > > On 2023-02-05 18:00, Bruno Haible wrote: > > Why call it 'c-nullptr', not 'nullptr'? > > I was worried about C++, not that I know much about it, and operated by > analogy with the name of m4/c-bool.m4. If 'nullptr' is a better name > then let's

Re: Gnulib and nullptr

On 2/5/23 16:57, Bruno Haible wrote: The diffutils patch shows that the possible bugs had already been caught Sure, but the idea is to make such bugs less likely in the future, by encouraging the use of nullptr now. The last platform in which pointers and integers were passed different

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

On Mon, 6 Feb 2023 at 20:38, Bruno Haible wrote: > 1. 'recode' is updated to a current gnulib and publish a corresponding > tarball. (Hi Reuben :) ) > I've updated gnulib in recode git; I'd be grateful if I could have a report that it's doing what's needed here before I make a release, if

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

On Feb 6 21:38, Bruno Haible wrote: > Corinna Vinschen wrote: > > I just ran the setlocale_null-mt-* tests with gnulib from git master > > under Cygwin with my newlib patch, and the tests succeeded. I checked > > that configure is doing the right thing and config.h contains the right > > settings

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

Corinna Vinschen wrote: > I just ran the setlocale_null-mt-* tests with gnulib from git master > under Cygwin with my newlib patch, and the tests succeeded. I checked > that configure is doing the right thing and config.h contains the right > settings: > > $ ./configure > [...] > checking w

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

On Feb 6 18:37, Bruno Haible wrote: > Corinna Vinschen wrote: > > This patch will be in the next Cygwin release 3.4.6. > > Thanks! > > > I'm just a bit fuzzy what patches will be required for gnulib now... > > With this patch, the setlocale_null lock should be gone in Cygwin >= 3.4.6. > I can't

Re: FAIL in diffutils/gnulib-tests

Bjarni Ingi Gislason wrote: > On Mon, Feb 06, 2023 at 02:28:03AM +0100, Bruno Haible wrote: > > Bjarni Ingi Gislason wrote: > > >GNU diffutils 3.9.12-c05c: gnulib-tests/test-suite.log > > > > Please try again with the tarball that you can download from > > https://gitlab.com/gnu-diffutils/ci-d

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

Corinna Vinschen wrote: > This patch will be in the next Cygwin release 3.4.6. Thanks! > I'm just a bit fuzzy what patches will be required for gnulib now... With this patch, the setlocale_null lock should be gone in Cygwin >= 3.4.6. I can't really test it, but I hope the patch is correct. 202

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

Hi Corinna, Sorry, I wanted to reply sooner. > > May I ask what's the idea to provide a thread-safe setlocale? It was > > never defined as thread-safe and POSIX explicitely mentions that. Any > > application expecting to call setlocale thread-safe is broken by design. The 'recode' package incl

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

Hi Bruno, On Feb 5 22:22, Corinna Vinschen wrote: > On Feb 5 21:41, Bruno Haible wrote: > > Another option — since we are talking about a single symbol and a single > > platform — would be if the locking for setlocale_null were not necessary > > on Cygwin in the first place. I determined that it

Re: Gnulib and nullptr

Paul Eggert wrote: > > Why call it 'c-nullptr', not 'nullptr'? > > I was worried about C++, not that I know much about it, and operated by > analogy with the name of m4/c-bool.m4. OK, I see. So the prefix 'c-' in 'c-bool' and 'c-nullptr' means something like "ISO C standard compliant". We could

Re: module c-nullptr: error compiling groff

Paul Eggert wrote: > > +# ifdef __cplusplus > > +/* For the C++ compiler the result of the configure test is irrelevant. > > + We know that at least g++ and clang with option -std=c++11 or higher, > > as well > > + as MSVC 14 or newer, already have nullptr. */ > > +# if !(((defined __GNUC__

Re: Gnulib and nullptr

Bruno Haible writes: > Therefore, I would be in favour of EITHER > * doing this when the community as a whole has adopted 'nullptr' in C, i.e. > this keyword is no longer something that is new to an average newcomer, > (even if that's only 10 years from now), > OR > * doing the change only in

[g.branden.robin...@gmail.com: macOS 12.6.3 and vasnprintf compilation failure]

[re-sending to correct mailing list] - Forwarded message from "G. Branden Robinson" - Date: Mon, 6 Feb 2023 02:28:10 -0600 From: "G. Branden Robinson" To: gnu...@gnu.org Cc: gr...@gnu.org Subject: macOS 12.6.3 and vasnprintf compilation failure [please CC groff@ on replies] Hi folks,