Re: Improve support for ACLs in coreutils (ls & chmod) following the Solaris way

On 1/16/23 07:03, Ondrej Valousek wrote: Is this something I would find support in both coreutils and Gnulib? Works for me. Though I have to wonder: why isn't this stuff in a library that Gnulib and/or coreutils can use? It seems a bit odd to introduce a reasonably major security feature lik

[PATCH] qcopy-acl: port to Fedora 9

It has libattr-2.4.41, which is too old for our code. Problem reported by Po Lu . * m4/xattr.m4 (gl_FUNC_XATTR): Check that we can use ATTR_ACTION_PERMISSIONS, too. Refactor so that there’s a single test program that we compile and link, rather than doing the tests in d

Re: nstrftime test failure on Android

On 1/17/23 06:43, Bruno Haible wrote: On Android 11, within Termux, I see this test failure: FAIL: test-nstrftime PST8PDT,M3.2.0,M11.1.0: expected "1969-12-31 16:00:00 -0800 (PST)", got "1969-12-31 17:00:00 -0700 (PDT)" CET-1CEST,M3.5.0,M10.5.0/3: expected "1970-01-01 01:0

Re: execute tests: Avoid test failure on Android

Eric Blake wrote: > > Apparently the SIGPIPE handler gets set to SIG_IGN, either by 'make' or > > by the test-driver. > > Known regression in make 4.4: > https://savannah.gnu.org/bugs/index.php?63307 Thanks. Indeed, I can reproduce the test failure also on a glibc system, with make 4.4 in $PATH.

Re: execute tests: Avoid test failure on Android

On Tue, Jan 17, 2023 at 03:21:52PM +0100, Bruno Haible wrote: > On Android 11, I'm seeing a test failure: > > > Apparently the SIGPIPE handler gets set to SIG_IGN, either by 'make' or > by the test-driver. Known regression in make 4.4: https://savannah.gnu.org/bugs/index.php?63307 and being fix

Re: [PATCH] Improve comments for [q]set-acl.c

[Adding bug-gnulib to CC] Ondrej Valousek wrote: > Hi Bruno, ok, I must have overlooked (it did not show in red in my case) Maybe it's because you have set 'git config color.ui never' or 'git config color.ui false'? > anyhow, last try. > > --- > lib/qset-acl.c | 14 +++--- > lib/set-ac

fflush: Fix a buffer overrun on 32-bit Android

On Android, I see a test failure: FAIL: test-yesno.sh === test-yesno: write error: Bad address test-yesno: write error: Bad address xout.tmp out.tmp differ: char 1, line 1 test-yesno: write error: Bad address test-yesno: write error: Bad address xout.tmp out.tmp differ: char 1, li

Re: fpending Android bug

I wrote: > When they moved 'struct __sFILE' out of > into , they also removed its named fields. And the Termux environment, that I'm using for testing, contains a that contains all the 20 real fields. This file does not come from any Android NDK. This explains why I was confused about this 'stru

nstrftime test failure on Android

Hi Paul, On Android 11, within Termux, I see this test failure: FAIL: test-nstrftime PST8PDT,M3.2.0,M11.1.0: expected "1969-12-31 16:00:00 -0800 (PST)", got "1969-12-31 17:00:00 -0700 (PDT)" CET-1CEST,M3.5.0,M10.5.0/3: expected "1970-01-01 01:00:00 +0100 (CET)", got "1970-

Re: [PATCH] Improve comments for [q]set-acl.c

Hi Ondrej, > Hi Bruno, sorry, this patch should be fine now. The patch applies, but it still introduces trailing spaces: When I apply it I get Applying: Improve comments for [q]set-acl.c .git/rebase-apply/patch:23: trailing whitespace. ACLs. If DESC is a valid file descriptor, use file descri

execute tests: Avoid test failure on Android

On Android 11, I'm seeing a test failure: FAIL: test-execute.sh = test-execute-main: test-execute-child subprocess failed ../../gltests/test-execute-main.c:138: assertion 'ret == 127' failed Aborted test-execute.sh: test case 3 failed ../../gltests/test-execute-main.c:151: ass

[PATCH] Improve comments for [q]set-acl.c

Hi Bruno, sorry, this patch should be fine now. It improve comments for both functions --- lib/qset-acl.c | 14 +++--- lib/set-acl.c | 18 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/qset-acl.c b/lib/qset-acl.c index c3442d060f..aecab8ead3 1006

hard_locale on Android

Given the strange behaviour of the "C" locale on Android, it is no wonder that I see a test failure: FAIL: test-hard-locale == The initial locale should not be hard! FAIL test-hard-locale (exit status: 1) This patch adjusts the function hard_locale in a conservative way (i.e