doc: Update regarding Android

2023-01-03 Thread Bruno Haible
On an Android (Termux) system, I see $ nm --dynamic /system/lib/libc.so | grep LIBC_PRIVATE 0002be8e T bcopy@@LIBC_PRIVATE 0002be9c T bzero@@LIBC_PRIVATE 0002bf08 T ftime@@LIBC_PRIVATE 0002bec4 T getdtablesize@@LIBC_PRIVATE 0002bf80 T index@@LIBC_PRIVATE 0002bc1e T pthread_attr_getstackaddr@@LIBC_

Re: [PATCH] Use xattr (Linux) in copy-acl.c

2023-01-03 Thread Bruno Haible
Paul Eggert wrote: > > +static int > > +copy_attr_permissions (const char *name, struct error_context *ctx) > > +{ > > + int action = attr_copy_action (name, ctx); > > + return action == ATTR_ACTION_PERMISSIONS; > > +} > > > This returns bool not int, so it should be declared to return bool.

Re: [PATCH] Use xattr (Linux) in copy-acl.c

2023-01-03 Thread Paul Eggert
Thanks again for looking into this. On 2023-01-03 06:08, Ondrej Valousek wrote: +static int +copy_attr_permissions (const char *name, struct error_context *ctx) +{ + int action = attr_copy_action (name, ctx); + return action == ATTR_ACTION_PERMISSIONS; +} This returns bool not in

ffs, ffsl, ffsll workarounds for Android

2023-01-03 Thread Bruno Haible
Building a Gnulib testdir on Android (via Termux), I see these errors: clang -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC -DEXEEXT=\"\" -I. -I../../gllib -I.. -DGNULIB_STRICT_CHECKING=1 -I/data/data/com.termux/files/home/local/include -Wall -fvisibility=hidden -g -O2 -c -o ffsl.o

stdio: Fix errors in C++ mode on Android, due to getw and putw

2023-01-03 Thread Bruno Haible
Building a gnulib testdir on Android (with the Termux development environment) I see these errors: ../gllib/stdio.h:1461:19: error: no member named 'getw' in the global namespace; did you mean 'getc'? _GL_CXXALIAS_SYS (getw, int, (FILE *restrict stream)); ~~^~~

Re: [PATCH] Use xattr (Linux) in copy-acl.c

2023-01-03 Thread Bruno Haible
Hi Ondrej, > diff --git a/lib/copy-acl.c b/lib/copy-acl.c > index 5fc42b7f6..341d1f605 100644 > --- a/lib/copy-acl.c > +++ b/lib/copy-acl.c > @@ -29,6 +29,20 @@ > #define _(msgid) gettext (msgid) > > > +#if USE_XATTR > + > +# include > + > +static int > +copy_attr_permissions (const char *na

[PATCH] Use xattr (Linux) in copy-acl.c

2023-01-03 Thread Ondrej Valousek
The following patch is aiming to improve & simplify ACL handling in copy-acl.c Changes/Benefits: * we no longer try to decode ACLs, instead we just copy the whole xattr with ACLs making the code simpler and faster * side effect is support for NFSv4 acls Disadvantages: * it pulls in dependency on l