Re: [PATCH] argmatch: add variants that only match full argument

2022-01-30 Thread Pádraig Brady
On 30/01/2022 18:58, Bruno Haible wrote: Pádraig Brady wrote: * lib/argmatch.h (argmatch_exact, [X]ARGMATCH_EXACT): New interfaces that don't support abbreviations. * lib/argmatch.c (argmatch_exact, __xargmatch_exact_internal): Likewise. * tests/test-argmatch.c: Add tests. The code looks corre

Re: [PATCH] argmatch: add variants that only match full argument

2022-01-30 Thread Bruno Haible
Pádraig Brady wrote: > * lib/argmatch.h (argmatch_exact, [X]ARGMATCH_EXACT): New interfaces > that don't support abbreviations. > * lib/argmatch.c (argmatch_exact, __xargmatch_exact_internal): Likewise. > * tests/test-argmatch.c: Add tests. The code looks correct. But I see some code duplication:

argmatch: add variants that only match full argument

2022-01-30 Thread Pádraig Brady
I would like a more constrained argument matching to improve forward compatibility and robustness. For example I would like `cksum -a sha3` to _not_ be equivalent to `cksum -a sha386`, so that a user specifying `-a sha3` on an older cksum would not be surprised. Also argmatch() is used when parsin

[PATCH] argmatch: add variants that only match full argument

2022-01-30 Thread Pádraig Brady
* lib/argmatch.h (argmatch_exact, [X]ARGMATCH_EXACT): New interfaces that don't support abbreviations. * lib/argmatch.c (argmatch_exact, __xargmatch_exact_internal): Likewise. * tests/test-argmatch.c: Add tests. --- ChangeLog | 8 lib/argmatch.c| 37 ++

new modules terminfo, terminfo-h

2022-01-30 Thread Bruno Haible
The module 'termcap' implements the old-style approach to terminal capabilities. Since ca. 1997, the preferred approach is 'terminfo', because: - 'termcap' has a buffer overflow problem in the API. See section "Pitfalls of Long Entr

new modules termcap, termcap-h

2022-01-30 Thread Bruno Haible
Another GNU package starts to make use of libtermcap [1][2]. By doing so, it exhibits the usual portability problems: - It assumes that exists. But these platforms don't have it: AIX, HP-UX, IRIX, Solaris, Android, Cygwin (opt.), mingw, MSVC. - It recognizes libtermcap and libcurses on

Re: snippets/unused-parameter

2022-01-30 Thread Bruno Haible
Paul Eggert wrote: > > My question is: What should i do w/ this module? > > (a) Leave it alone -- "obsolete" is not "broken". > > That's OK in the short term but in the long run I suggest using > _GL_UNUSED instead. I would advise against that. Identifiers that begin with _GL are Gnulib-private.

Re: [PATCH] gendocs: update copyright footer year

2022-01-30 Thread Bruno Haible
> * doc/gendocs_template: Change 2020 to 2022. Thanks. Applied.

[PATCH] gendocs: update copyright footer year

2022-01-30 Thread Mike Frysinger
* doc/gendocs_template: Change 2020 to 2022. --- doc/gendocs_template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/gendocs_template b/doc/gendocs_template index c8c8fc610010..0415d947be65 100644 --- a/doc/gendocs_template +++ b/doc/gendocs_template @@ -87,7 +87,7 @@ the