Re: linkedhash-list: Relicense under LGPLv2+

2021-03-21 Thread Paul Eggert
On 3/21/21 7:17 PM, Bruno Haible wrote: Paul, can I have your approval to relicense this change under LGPLv2+ ? So that I can then change this module's license. Yes, that's fine.

linkedhash-list: Relicense under LGPLv2+

2021-03-21 Thread Bruno Haible
I need to use the module 'clean-temp' in a library under GPLv2+ (namely, GNU libffcall). One of the dependencies is the module 'linkedhash-list'. I am the main contributor of the files of this module lib/gl_linkedhash_list.h lib/gl_linkedhash_list.c lib/gl_anyhash1.h lib/gl_anyhash2.h li

fatal-signal: Relicense under LGPLv2+

2021-03-21 Thread Bruno Haible
I need to use the module 'clean-temp' and, with it, the module 'fatal-signal' in a library under GPLv2+ (namely, GNU libffcall). To this effect, I would like to put this module (fatal-signal) under LGPLv2+. Aside from my contributions and a few mechanical changes (not copyrightable), there is this

fatal-signal: Remove dependency upon xalloc

2021-03-21 Thread Bruno Haible
I need to use the module 'clean-temp' and, with it, the module 'fatal-signal' in a library under GPLv2+ (namely, GNU libffcall). To this effect, functions in this module should not call xalloc_die() (since that is under GPLv3+) but instead return an error indicator. This patch is the first part of

Re: Is the 'diacrit' module still needed?

2021-03-21 Thread Paul Eggert
On 3/21/21 5:22 PM, Bruno Haible wrote: I don't think it is used elsewhere; 'diacrit' is a very specialized module. It is deprecated for more than 1.5 years. It can be removed now. Thanks, done by installing the attached. I'll miss that comment dated 1988 saying "All this file is a temporary

Re: [PATCH] tests: fix signed overflow issues

2021-03-21 Thread Bruno Haible
> * tests/test-dynarray.c (value_at): Avoid undefined behavior > in signed integer multiplication. Thanks. Indeed with N=10 the multiplication would overflow. If I had used CC="gcc -ftrapv", I would have noticed. Bruno

Re: Is the 'diacrit' module still needed?

2021-03-21 Thread Bruno Haible
Hi Paul, > Today I updated Coreutils to current Gnulib, and noticed that > gnulib-tool warned that Gnulib's 'diacrit' module is obsolete. So I > removed Coreutils's use of 'diacrit', as the only use was something > obsolete in 'ptx'[1]. Nice. This fixes the warning that Berny reported [1]. >

[PATCH] tests: fix signed overflow issues

2021-03-21 Thread Paul Eggert
* tests/test-dynarray.c (value_at): Avoid undefined behavior in signed integer multiplication. * tests/test-scratch-buffer.c (byte_at): Likewise, for the theoretically-possible case where size_t is narrower than int. --- ChangeLog | 8 tests/test-dynarray.c | 2 +-

Is the 'diacrit' module still needed?

2021-03-21 Thread Paul Eggert
Today I updated Coreutils to current Gnulib, and noticed that gnulib-tool warned that Gnulib's 'diacrit' module is obsolete. So I removed Coreutils's use of 'diacrit', as the only use was something obsolete in 'ptx'[1]. Does anyone else use 'diacrit'? If not, I suppose we can remove it from G

Re: [PATCH] mbrtowc: remove a redundant condition

2021-03-21 Thread Bruno Haible
Hi Benno, > * lib/mbrtowc-impl-utf8.h: There is no need to check for c == 0xf4 > when !(c < 0xf4), as ten lines earlier c <= 0xf4 was established. Your patch is correct. But we generally don't need to do micro- optimizations that a compiler easily can do for us. Just curious: Did you get a compil

[PATCH] mbrtowc: remove a redundant condition

2021-03-21 Thread Benno Schulenberg
* lib/mbrtowc-impl-utf8.h: There is no need to check for c == 0xf4 when !(c < 0xf4), as ten lines earlier c <= 0xf4 was established. --- ChangeLog | 6 ++ lib/mbrtowc-impl-utf8.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 76e

doc: Update for macOS 11.1

2021-03-21 Thread Bruno Haible
This patch updates the documentation regarding macOS 11.1 (or 11.2 — the libc sources and header files are the same for both versions). The interesting parts are: * It now has the functions timespec_get preadv, pwritev rpmatch posix_spawn_file_actions_addchdir_np, posix

Re: Issues with posix functions on modern macOS/Xcode

2021-03-21 Thread Bruno Haible
> * doc/posix-functions/ftello.texi: Mention the macOS bug. The ftello bug is, of course, also reflected as an ftell bug. 2021-03-21 Bruno Haible ftell: Document bug in macOS >= 10.15. * doc/posix-functions/ftell.texi: Mention the macOS bug. diff --git a/doc/posix-func