Re: [PATCH] gc-random: Replace implementation with call to getrandom.

Hi Simon, > Hi. I re-read the discussion around getrandom vs gc-random and didn't > see any point in keeping the duplicated code. I believe the > getrandom-approach is better than what was in gc-gnulib.c today, so this > patch make it use that function. I have pushed the patch below. The chang

Re: Portability issues with scractch_buffer

Hi Paul, > Le 20 janv. 2021 à 02:50, Paul Eggert a écrit : > > On 1/19/21 10:22 AM, Akim Demaille wrote: > >> Clang 3.3 and 3.4 cannot compile the new scratch-buffer module. On Bison's >> CI (Clang 3.4: https://api.travis-ci.org/v3/job/755133481/log.txt), there is: >>> ... >>> CC lib/

Re: [PATCH 1/5] posix: Sync regex code with gnulib

On 1/20/21 3:27 AM, Adhemerval Zanella wrote: #if defined __STDC_VERSION__ && 201710L < __STDC_VERSION__ # define __attribute_fallthrough__ [[__fallthrough__]] #elif __GNUC_PREREQ (7, 0) || __glibc_has_attribute (__fallthrough__) # define __attribute_fallthrough__ __attribute__ ((__fallthrough__)

Re: [PATCH 1/5] posix: Sync regex code with gnulib

Right, this did not showed up on build-many-glibc.py. My plan is to touch as little code as possible since we are in slush freeze and sync again with gnulib once we set development for 2.34. I will fix this as well. On 20/01/2021 12:32, Vaseeharan Vinayagamoorthy wrote: > Thanks for the fix, Adh

Re: [PATCH 1/5] posix: Sync regex code with gnulib

Thanks for the fix, Adhemerval Zanella. I assume you would fix this in other files too, for example I think a similar patch is needed for posix/fnmatch.c. fnmatch.c:67:26: error: "__clang_major__" is not defined [-Werror=undef] # if (__GNUC__ >= 7) || (__clang_major__ >= 10)

Re: [PATCH v3 6/6] stdlib: Add testcase fro BZ #26241

Adhemerval Zanella via Libc-alpha writes: > -tst-setcontext9 tst-bz20544 > +tst-setcontext9 tst-bz20544 tst-canon-bz26341 New test, ok. > +LDLIBS-tst-canon-bz26341 = $(shared-thread-library) Ok. > diff --git a/stdlib/tst-canon-bz26341.c b/stdlib/tst-canon-bz26

Re: [PATCH v3 6/6] stdlib: Add testcase fro BZ #26241

On 20/01/2021 01:33, DJ Delorie wrote: > > Adhemerval Zanella via Libc-alpha writes: >> - tst-setcontext9 tst-bz20544 >> + tst-setcontext9 tst-bz20544 tst-canon-bz26341 > > New test, ok. > >> +LDLIBS-tst-canon-bz26341 = $(shared-thread-library) > > Ok. > >> diff

Re: [PATCH 1/5] posix: Sync regex code with gnulib

On 19/01/2021 23:55, Paul Eggert wrote: > On 1/19/21 7:43 AM, Bruno Haible wrote: >> Adhemerval Zanella wrote: >>> -# if (__GNUC__ >= 7) || (__clang_major__ >= 10) >>> +# if (__GNUC__ >= 7) || (defined __clang_major__ &&__clang_major__ >= 10) >> I would write it as: >> >> +# if (__GNUC__ >= 7) |

[PATCH] gc-random: Replace implementation with call to getrandom.

Hi. I re-read the discussion around getrandom vs gc-random and didn't see any point in keeping the duplicated code. I believe the getrandom-approach is better than what was in gc-gnulib.c today, so this patch make it use that function. I have pushed the patch below. /Simon From 44ed0db8c93f6a81

exec*e tests: Avoid test failures on Cygwin

On Cygwin, I see these test failures: FAIL: test-execle.sh C:/cygwin64/home/bruno/testdir-all/build-cygwin64/gltests/test-exec-child.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory FAIL test-execle.sh (exit status: 1)

Re: canonicalize test failures on Cygwin

Ken Brown wrote: > I took a quick look, and it appears that this is a Cygwin bug in which > realpath() fails with ENOENT instead of ENOTDIR. Yes, I confirm. POSIX says that when one of the components "names an existing fil

Re: ptsname_r on Cygwin

> While https://www.kernel.org/doc/man-pages/online/pages/man3/ptsname_r.3.html > says that ptsname_r, upon failure, should return an error code, on Cygwin, > it returns 0 and stores the empty string in 'buffer'. Let me document this issue. 2021-01-20 Bruno Haible doc: Document ptsna