I wrote:
> It smells like additional tests for fchmod(), fchmodat(), lchmod() could
> uncover bugs on some platforms. So I'm adding more tests.
And indeed, on AIX 7.2 one of these new tests fails:
../../gltests/test-fchmodat.c:60: assertion 'fchmodat (AT_FDCWD, BASE "file/",
0600, 0) == -1' fail
It smells like additional tests for fchmod(), fchmodat(), lchmod() could
uncover bugs on some platforms. So I'm adding more tests.
2021-01-09 Bruno Haible
fchmod-tests, fchmodat tests, lchmod tests: Add more tests.
* tests/test-fchmod.c: Include .
(BASE): New macro.
> +AC_DEFINE([HAVE_NEARLY_WORKING_UTIMENSAT], [1],
> + [Define to 1 of utimensat works, except for the trailing slash
> handling.])
Oops, there was a typo here.
2021-01-09 Bruno Haible
utimensat: Fix typo in last commit.
* m4/utimensat.m4 (gl_FUNC_UTIMENSAT)
> 2021-01-05 Bruno Haible
>
> truncate: Work around trailing slash bug in truncate() on AIX 7.2.
> * m4/truncate.m4 (gl_FUNC_TRUNCATE): Add a test whether truncate
> rejects trailing slashes. Set REPLACE_TRUNCATE and define
> TRUNCATE_TRAILING_SLASH_BUG if not.
> *
On 1/8/21 5:24 PM, Darshit Shah wrote:
/home/rincewind/Programming/wget/lib/regexec.c:1444: undefined reference
to `regmatch_list_free'
Oof, it's because Gnulib's replacement of 'free' with 'rpl_free' caused
the function definition to be named 'regmatch_list_rpl_free'.
Thanks for reporting
On 1/4/21 9:03 AM, Adhemerval Zanella wrote:
For __GT_NOCREATE (mktemp, tempnam, tmpnam) getrandom is also used
on first try, otherwise randomness is obtained using the clock plus
a linear congruential generator.
Why not use getrandom in the first try also for __GT_DIR (mkdtemp) and
__GT_FILE
On 1/4/21 9:03 AM, Adhemerval Zanella wrote:
-# define __lstat64(version, file, buf) lstat (file, buf)
+# define __lxstat64(version, file, buf) lstat (file, buf)
That change isn't quite right for the !_LIBC case, since it doesn't
define the __stat64 macro and it defines __lstat64 with the wro
On 1/4/21 4:52 AM, Adhemerval Zanella wrote:
The extra comparison might avoid the scratch_buffer resize that will
fail (since malloc will fail to try allocate PTRDIFF_MAX object), but
it will be used only when such objects are provided (which depending
of the system should not happen).
As you s
Hi,
Since this patch has been applied, GNU Wget fails during the linking
stage due to regmatch_list_free not being available:
/usr/bin/ld: ../lib/libgnu.a(regex.o): in function `set_regs':
/home/rincewind/Programming/wget/lib/regexec.c:1444: undefined reference
to `regmatch_list_free'
/usr/bin/ld
This patch looks good for glibc, once the previous two regex patches are
done. I installed it into Gnulib by applying the attached, so that
regex_internal.h can stay in lock-step between Gnulib and glibc.
>From 87ed1f9c4bc4ae9e98e1293465a5b3a929b9c3f9 Mon Sep 17 00:00:00 2001
From: Paul Eggert
D
On 1/6/21 10:17 AM, Adhemerval Zanella wrote:
__libc_use_alloca/alloca is replaced with malloc regardless.
These allocations are so small that they should be put on the stack
instead of using malloc. I did that in Gnulib by installing the attached
patch. The idea is that the resulting regexec
On 1/8/21 1:49 PM, Bruno Haible wrote:
So, the problem is a signed-integer overflow of constants in a dead
(unreachable) code branch.
Yes, I get many warnings like that in Oracle Developer Studio too, with
some of the Gnulib tests. Either ignore the warnings, or don't use
-Woverflow, or (as w
Sergey Poznyakoff wrote:
> With recent gnulib (v0.1-4336-gbdae9a5), attempting to compile
> parse-datetime.c fails with:
>
> $ make -k parse-datetime.o V=1
> gcc -DHAVE_CONFIG_H -I. -I.. -Wall -ggdb -MT parse-datetime.o -MD -MP -MF
> .deps/parse-datetime.Tpo -c -o parse-datetime.o parse-datet
On 1/6/21 10:17 AM, Adhemerval Zanella wrote:
It replaces the regmatch_t with a dynarray list.
regexec.c is shared with Gnulib, so some work needed to be done on the
Gnulib side for this patch since Gnulib didn't have dynarray. Dynarray
is something I've been meaning to add to Gnulib for some
* lib/scratch_buffer.h (__libc_scratch_buffer_dupfree):
New macro, needed to support recent changes in this module.
---
ChangeLog| 4
lib/scratch_buffer.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index aff3584e4..540f15a3c 100644
--- a/ChangeLog
Hello,
With recent gnulib (v0.1-4336-gbdae9a5), attempting to compile
parse-datetime.c fails with:
$ make -k parse-datetime.o V=1
gcc -DHAVE_CONFIG_H -I. -I.. -Wall -ggdb -MT parse-datetime.o -MD -MP -MF
.deps/parse-datetime.Tpo -c -o parse-datetime.o parse-datetime.c
In file included from p
Paul Eggert writes:
> On 1/6/21 1:55 PM, Simon Josefsson via Gnulib discussion list wrote:
>
>> I'm using the patch below in gsasl, what do you think?
>
> Thanks, looks good to me.
>
> On 1/6/21 3:54 PM, Bernhard Voelker wrote:
>
>> And instead of adding yet another way to do the same job, should
17 matches
Mail list logo
