Re: [PATCH] read-file: add variants that clear internal memory

Bruno Haible writes: > It would be useful to first concentrate on the first part, the refactoring > that introduces flags and RF_BINARY. This would provide a patch that is easier > to review and does not have the following problems: > - internal_fread_file still exists, although fread_file is a

Re: [PATCH v2] win32: don't force _WIN32_WINNT to a lower version

Hi, On 2020-05-26 22:38, Bruno Haible wrote: Hi Steve, /* Ensure that declares GetFileSizeEx. */ +#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x0500 # undef _WIN32_WINNT # define _WIN32_WINNT _WIN32_WINNT_WIN2K +#endif What do you gain by this? What does it bring to compile

Re: doc/gnulib-intro.texi: A "to" is missing in a sentence.

On 2020-05-26 22:53, Bjarni Ingi Gislason wrote: > The text is: > > All patches should be posted the list, ... Thanks for the report ... I installed the attached patch. > It is also in the files "doc/gnulib.html" and "doc/gnulib.info". Those are generated from the *.texi file. Have a nice

doc/gnulib-intro.texi: A "to" is missing in a sentence.

The text is: All patches should be posted the list, ... It is also in the files "doc/gnulib.html" and "doc/gnulib.info". -- Bjarni I. Gislason

Re: [PATCH v2] win32: don't force _WIN32_WINNT to a lower version

Hi Steve, > > /* Ensure that declares GetFileSizeEx. */ > +#if !defined(_WIN32_WINNT) || _WIN32_WINNT < 0x0500 > # undef _WIN32_WINNT > # define _WIN32_WINNT _WIN32_WINNT_WIN2K > +#endif > What do you gain by this? What does it bring to compile this code with a higher _WIN32_WINNT valu

Re: Warnings in count-one-bits.h

Gisle Vanem wrote: > The lines in count-one-bits.h: > # pragma intrinsic __cpuid > # pragma intrinsic __popcnt > # pragma intrinsic __popcnt64 > > triggers these warnings: >count-one-bits.h(79): warning C4083: expected '('; found identifier > '__cpuid' >count-one-bits.h(80): warning C4

Re: Compile error in argz.c

Gisle Vanem wrote: > The use of '__argv' as parameter names, causes this > error from clang-cl: >argz.c(234,1): error: conflicting types for 'argz_extract' >argz_extract (const char *argz, size_t len, char **argv) >^ >.\argz.h(68,13): note: previous declaration is here >extern v

Re: [PATCH] read-file: add variants that clear internal memory

Hi Daiki, > > If you agree, I'd like to see two commits: > > 1. the introduction of the flags and RF_BINARY, > > 2. the RF_SENSITIVE flag. > > > > Do you want me to code the first commit, or do you want to do it? > > Sure, that would make things much simpler. I'm attaching a patch along > th

Re: [PATCH] read-file: add variants that clear internal memory

Bruno Haible writes: > If you agree, I'd like to see two commits: > 1. the introduction of the flags and RF_BINARY, > 2. the RF_SENSITIVE flag. > > Do you want me to code the first commit, or do you want to do it? Sure, that would make things much simpler. I'm attaching a patch along these

Re: portability of fopen and 'e' (O_CLOEXEC) flag

Hi Daiki, > > Thank you for this; would it make sense to use it in the modules that do > > one-shot fopen/fclose, such as read-file? Here are proposed patches for other modules. Does this look right? Note: The patch to sethostname.c is only relevant for Minix. Minix does not have multithreading

Warnings in count-one-bits.h

The lines in count-one-bits.h: # pragma intrinsic __cpuid # pragma intrinsic __popcnt # pragma intrinsic __popcnt64 triggers these warnings: count-one-bits.h(79): warning C4083: expected '('; found identifier '__cpuid' count-one-bits.h(80): warning C4083: expected '('; found identifier '

Compile error in argz.c

The use of '__argv' as parameter names, causes this error from clang-cl: argz.c(234,1): error: conflicting types for 'argz_extract' argz_extract (const char *argz, size_t len, char **argv) ^ .\argz.h(68,13): note: previous declaration is here extern void argz_extract (const char *restric

[PATCH v2] win32: don't force _WIN32_WINNT to a lower version

--- lib/ftruncate.c | 2 ++ lib/sethostname.c | 6 -- lib/stat-w32.c| 6 -- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/ftruncate.c b/lib/ftruncate.c index a1856374e..990b71dbb 100644 --- a/lib/ftruncate.c +++ b/lib/ftruncate.c @@ -30,8 +30,10 @@ argument.

Re: [PATCH] read-file: add variants that clear internal memory

Hi Daiki, > The functions provided by the read-file module are handy, but they are > suboptimal for reading sensitive materials, because they do not clear > the allocated memory blocks upon failure. > ... > It's tempting to make this behavior enabled by default, but I worry that > it may cause any

[PATCH] read-file: add variants that clear internal memory

Hello, The functions provided by the read-file module are handy, but they are suboptimal for reading sensitive materials, because they do not clear the allocated memory blocks upon failure. The attached patch adds a set of variants that deal with that. It's tempting to make this behavior enabled

Re: portability of fopen and 'e' (O_CLOEXEC) flag

Hi Daiki, > Thank you for this; would it make sense to use it in the modules that do > one-shot fopen/fclose, such as read-file? This would improve things for multithreaded programs that call exec or posix_spawn. There are not that many programs of this kind. But on the other hand, multithreading