Re: list, set, oset, map, omap: avoid imperative voice in documentation

2020-02-08 Thread Bruno Haible
Paul Eggert wrote: > Plus, it's odd to use one style before a "{" and a different style after. I think it's useful to make this emphasis - in order to write a function specification that can be understood without reading the function body. When I write code, I'm of course a bit annoyed to make th

Re: bug#39236: [musl] coreutils cp mishandles error return from lchmod

2020-02-08 Thread Bruno Haible
Hi Paul, > similarly for lchmod on non-symlinks. When I see a new autoconf test that activates an override, in order to guarantee a certain documented behaviour, I like to add a unit test - because in the past we several times had an override that would not have passed the autoconf test either.

Re: fchmodat with AT_SYMLINK_NOFOLLOW

2020-02-08 Thread Bruno Haible
Hi Paul, > I installed the attached patch to Gnulib in preparation for the upcoming > glibc fix. The patch causes fchmodat with AT_SYMLINK_NOFOLLOW to work on > non-symlinks, and similarly for lchmod on non-symlinks. The idea is to > avoid this sort of problem in the future, and to let Coreutil

Fix compilation errors in a testdir created with --with-c++-tests

2020-02-08 Thread Bruno Haible
In a testdir created through ./gnulib-tool --create-testdir --dir=... --single-configure --with-c++-tests lchmod fchmodat I'm getting compilation errors, such as: In file included from test-string-c++.cc:22: ../gllib/string.h:707: error: type of 'memrchr' is unknown ../gllib/string.h:707: error

doc: update for glibc 2.31

2020-02-08 Thread Bruno Haible
It's good if the gnulib documentation reflects the newest glibc release, not some older release. 2020-02-08 Bruno Haible doc: Update for glibc 2.31. * doc/glibc-functions/pthread_clockjoin_np.texi: New file. * doc/gnulib.texi: Include it. * doc/pastposix-functi

Re: [PATCH] [PATCH] mountlist: Consider smb3 filesystems as remote.

2020-02-08 Thread Pádraig Brady
On 05/02/2020 14:16, Kenneth D'souza wrote: Recognize filesystems of type smb3 as remote. Signed-off-by: Kenneth D'souza --- lib/mountlist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/mountlist.c b/lib/mountlist.c index 61063ce91..969fedf8b 100644 --- a/lib/mountlist.c +++ b/lib