Re: [PATCH] regex: port to Gawk on nonstandard platforms

2020-01-27 Thread arnold
Paul Eggert wrote: > On 1/26/20 1:42 AM, arn...@skeeve.com wrote: > > And then in places in regcomp.c BITSET_WORD_BITS is tested in > > several #if/#elif statements. > > Ouch, I hadn't noticed that. It's exercised only on non-GCC platforms > that don't support INT_WIDTH etc., which is why I didn

Re: clang-10 warning in hash.c

2020-01-27 Thread Bruno Haible
I wrote: > And I dislike it because the transformation is correct only if > (float) SIZE_MAX >= SIZE_MAX. In the other case, > (float) SIZE_MAX < SIZE_MAX, the transformation is incorrect > [think of the particular value new_candidate = (float) SIZE_MAX]. Ouch, I was assuming that the comparison s

Re: [PATCH] regex: port to Gawk on nonstandard platforms

2020-01-27 Thread Paul Eggert
On 1/26/20 1:42 AM, arn...@skeeve.com wrote: And then in places in regcomp.c BITSET_WORD_BITS is tested in several #if/#elif statements. Ouch, I hadn't noticed that. It's exercised only on non-GCC platforms that don't support INT_WIDTH etc., which is why I didn't see it in my testing. I insta

Re: clang-10 warning in hash.c

2020-01-27 Thread Bruno Haible
Paul Eggert wrote: > In the past I've worked around problems like these by writing things > like "SIZE_MAX + 1.0f <= new_candidate" instead of "SIZE_MAX <= > new_candidate" This may deserve a warning that adding 1.0f does not change the value. > Presumably the Clang folks want us to insert a ca

Re: clang-10 warning in hash.c

2020-01-27 Thread Paul Eggert
On 1/27/20 5:09 AM, Bruno Haible wrote: IMO you should file a ticket with the clang people. That sounds appropriate. In the past I've worked around problems like these by writing things like "SIZE_MAX + 1.0f <= new_candidate" instead of "SIZE_MAX <= new_candidate" (partly under the argument

GNU Tools Cauldron 2020

2020-01-27 Thread Olivier Hainque
Hello, We are pleased to invite you all to the next GNU Tools Cauldron, taking place in Paris on June 12-14, 2020. As for the previous instances, we have setup a wiki page for details: https://gcc.gnu.org/wiki/cauldron2020 The conference is free to attend, registration in advance is required.

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-27 Thread Bruno Haible
Giulio Benetti wrote: > > There should not be a in public include file directories! > > Indeed there is not, there is and it is part of uclibc: > https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/libintl.h Ah! Most of the contents of this is OK. But - gettext_noop - gettext_pr

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-27 Thread Giulio Benetti
Hi Bruno, sorry I'm following too many things in parallel and I've made a mess on explaining! On 1/27/20 6:38 PM, Bruno Haible wrote: Giulio Benetti wrote: Since you reported a redefinition warning regarding 'gettext_noop', gettext_noop must have been defined as a macro already elsewhere. Wh

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-27 Thread Bruno Haible
Giulio Benetti wrote: > > Since you reported a redefinition warning regarding 'gettext_noop', > > gettext_noop must have been defined as a macro already elsewhere. Where? > > gettext_noop() is defined in environment gettext.h What do you mean by "environment gettext.h"?? The documentation [1] sa

Re: [PATCH] lib/gettext.h: fix warning if gettext is already present

2020-01-27 Thread Giulio Benetti
Hi Bruno, On 1/27/20 2:41 AM, Bruno Haible wrote: Giulio Benetti wrote: In my specific case I'm adding package libbytesize [1], where they add src/gettext.h But libbytesize uses gettext.h as they should: They use the file internally, without installing it in public locations upon "make instal

Re: clang-10 warning in hash.c

2020-01-27 Thread Bruno Haible
Hi Tim, > Not sure if the compiler is correct here, but maybe worth a look: > > hash.c:549:11: error: implicit conversion from 'unsigned long' to > 'float' changes value from 18446744073709551615 to 18446744073709551616 > [-Werror,-Wimplicit-int-float-conversion] > if (SIZE_MAX <= new_candi

clang-10 warning in hash.c

2020-01-27 Thread Tim Rühsen
Not sure if the compiler is correct here, but maybe worth a look: hash.c:549:11: error: implicit conversion from 'unsigned long' to 'float' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] if (SIZE_MAX <= new_candidate) ^