Re: Gnulib's alloca.h used even when there is a system header

2019-02-28 Thread Eli Zaretskii
Ping! This discussion seems to have stalled, without reaching any firms conclusion. Can we please finish discussing this? Or maybe it is OK to install the patch I proposed up-thread? TIA > Date: Tue, 19 Feb 2019 19:18:15 +0200 > From: Eli Zaretskii > CC: bug-gnulib@gnu.org, egg...@cs.ucla.edu

[PATCH] Fix pointer comparison

2019-02-28 Thread Michal Privoznik
While generally it might be safe to compare pointer against literal 0, it may make one think that the pointer is an int. Use explicit comparison against NULL (or !ptr). Signed-off-by: Michal Privoznik --- lib/alloca.c | 10 +- lib/backup-find.c| 2 +- lib/bitset/list.c|