Re: relocatable-prog: avoid warnings from Automake

2019-01-23 Thread Akim Demaille
> Le 24 janv. 2019 à 02:08, Bruno Haible a écrit : > > Hi Akim, Hi Bruno, >> This is what I get currently: >> >> cd bison && /bin/sh build-aux/missing automake-1.16 --gnu Makefile >> lib/gnulib.mk:1677: warning: .PHONY was already defined in condition TRUE, >> which includes condition RELO

Re: array-list: Pacify warnings about unused arguments (-Wunused-parameter)

2019-01-23 Thread Akim Demaille
Hi Eric, > Le 23 janv. 2019 à 23:24, Eric Blake a écrit : > > Why not this: > > -gl_array_iterator_free (gl_list_iterator_t *iterator) > +gl_array_iterator_free (gl_list_iterator_t *iterator _GL_UNUSED) > > like we do elsewhere? Sure. I did that, and installed it. Thanks!

Re: relocatable: avoid compiler warnings (-Wshadow)

2019-01-23 Thread Akim Demaille
> Le 24 janv. 2019 à 02:00, Bruno Haible a écrit : > > Hi Akim, > > It's good to reduce warnings. But I'm unhappy about the choice of > identifiers you made: There are various different prefixes involved > here (install prefix, original prefix, current prefix, etc.), and > the code is complic

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
> (2) threadlib.m4 defines LIBMULTITHREAD in a way that is meant to defeat > -Wl,--as-needed. But it does not work, due to the reordering of > options done by libtool. Let me take out the code that does not work. 2019-01-23 Bruno Haible threadlib: Revert commit from 2018-06-2

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
Let me summarize the issue. (1) The distro sets LDFLAGS="-Wl,--as-needed". So, libraries that not are not required through at least 1 symbol are not linked in. (2) threadlib.m4 defines LIBMULTITHREAD in a way that is meant to defeat -Wl,--as-needed. But it does not work, due to the reorder

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
Dmitry V. Levin wrote: > According to the log, it was libtool that broke a valid command > > /bin/sh ../../libtool --tag=CC --preserve-dup-deps --mode=link gcc -O2 -g > -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 > -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong

Re: relocatable: avoid compiler warnings (-Wshadow)

2019-01-23 Thread Bruno Haible
Hi Akim, > diff --git a/lib/relocatable.c b/lib/relocatable.c > index 17cdb6590..033c44139 100644 > --- a/lib/relocatable.c > +++ b/lib/relocatable.c > @@ -282,23 +282,21 @@ compute_curr_prefix (const char *orig_installprefix, >} > > { > - size_t curr_prefix_len = cp - curr_ins

Re: relocatable-prog: avoid warnings from Automake

2019-01-23 Thread Bruno Haible
Hi Akim, > This is what I get currently: > > cd bison && /bin/sh build-aux/missing automake-1.16 --gnu Makefile > lib/gnulib.mk:1677: warning: .PHONY was already defined in condition TRUE, > which includes condition RELOCATABLE_VIA_WRAPPER ... I've seen this warning also with respect to normal

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Dmitry V. Levin
On Wed, Jan 23, 2019 at 10:24:26PM +, Richard W.M. Jones wrote: > On Thu, Jan 24, 2019 at 01:09:52AM +0300, Dmitry V. Levin wrote: > > On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > > > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > > > Hi, > > > >

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
On Thu, Jan 24, 2019 at 01:09:52AM +0300, Dmitry V. Levin wrote: > On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > > Hi, > > > > > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > >

Re: array-list: Pacify warnings about unused arguments (-Wunused-parameter)

2019-01-23 Thread Eric Blake
On 1/23/19 3:37 PM, Akim Demaille wrote: > In Bison. > > commit decda5a491a8e8900bea0f4346d8dfca191d4b90 > Author: Akim Demaille > Date: Wed Jan 23 22:36:54 2019 +0100 > > array-list: Pacify warnings about unused arguments (-Wunused-parameter) > > * lib/gl_array_list.c (gl_array_i

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Dmitry V. Levin
On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > Hi, > > > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > > [...] >

Re: relocatable: avoid compiler warnings (-Wshadow)

2019-01-23 Thread Ben Pfaff
On Wed, Jan 23, 2019 at 10:33:20PM +0100, Akim Demaille wrote: > Hi, > > This is to avoid warnings such as: > > bison/lib/relocatable.c: In function 'compute_curr_prefix': > bison/lib/relocatable.c:285:14: warning: declaration of 'curr_prefix_len' > shadows a global declaration [-Wshadow] >

Re: relocatable-prog: avoid warnings from Automake

2019-01-23 Thread Ben Pfaff
On Wed, Jan 23, 2019 at 10:48:23PM +0100, Akim Demaille wrote: > Hi Ben, > > This is what I get currently: > > cd bison && /bin/sh build-aux/missing automake-1.16 --gnu Makefile > lib/gnulib.mk:1677: warning: .PHONY was already defined in condition TRUE, > which includes condition RELOCATABLE_V

relocatable: avoid compiler warnings (-Wshadow)

2019-01-23 Thread Akim Demaille
Hi, This is to avoid warnings such as: bison/lib/relocatable.c: In function 'compute_curr_prefix': bison/lib/relocatable.c:285:14: warning: declaration of 'curr_prefix_len' shadows a global declaration [-Wshadow] size_t curr_prefix_len = cp - curr_installdir; ^~~

relocatable-prog: avoid warnings from Automake

2019-01-23 Thread Akim Demaille
Hi Ben, This is what I get currently: cd bison && /bin/sh build-aux/missing automake-1.16 --gnu Makefile lib/gnulib.mk:1677: warning: .PHONY was already defined in condition TRUE, which includes condition RELOCATABLE_VIA_WRAPPER ... Makefile.am:71: 'lib/local.mk' included from here lib/local.

array-list: Pacify warnings about unused arguments (-Wunused-parameter)

2019-01-23 Thread Akim Demaille
In Bison. commit decda5a491a8e8900bea0f4346d8dfca191d4b90 Author: Akim Demaille Date: Wed Jan 23 22:36:54 2019 +0100 array-list: Pacify warnings about unused arguments (-Wunused-parameter) * lib/gl_array_list.c (gl_array_iterator_free): "Use" the argument. diff --git a/ChangeLog

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > Hi, > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > [...] > > I checked the history of the Fedora package which adds these flags, and > > i

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Michael Hudson-Doyle
On Thu, 24 Jan 2019 at 10:03, Dmitry V. Levin wrote: > Hi, > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > [...] > > I checked the history of the Fedora package which adds these flags, and > > it seems lik

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Dmitry V. Levin
Hi, On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: [...] > I checked the history of the Fedora package which adds these flags, and > it seems like --as-needed was added for: > > https://fedoraproject.org/wiki/Cha

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > Hi Rich, > > > I cannot reproduce this locally, hence my bug report is rather devoid > > of details. However, it's 100% reproducible in Koji (the Fedora > > Rawhide build system) on *all* architectures except armv7: > > > > FAIL: te

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
Hi Rich, > I cannot reproduce this locally, hence my bug report is rather devoid > of details. However, it's 100% reproducible in Koji (the Fedora > Rawhide build system) on *all* architectures except armv7: > > FAIL: test-rwlock1 > == > Unexpected outcome 3 > FAIL: test-thread_c

test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
I cannot reproduce this locally, hence my bug report is rather devoid of details. However, it's 100% reproducible in Koji (the Fedora Rawhide build system) on *all* architectures except armv7: FAIL: test-rwlock1 == Unexpected outcome 3 FAIL: test-thread_create The full log is h

Re: [PATCH] vasnprintf: Don't use %n on android

2019-01-23 Thread Tim Rühsen
On 23.01.19 01:25, Bruno Haible wrote: > Hi Tim and Hugo, > >>> I also don't see much here (Debian unstable): >>> >>> $ grep -A1 -i 'checking.*printf' config.log >>> configure:6305: checking for vasnprintf >>> configure:6305: result: no >>> configure:6305: checking for snprintf >>> configure:6305: