Re: [PATCH] Add renameat2 function [BZ #17662]

2018-07-02 Thread Florian Weimer
On 07/02/2018 07:38 PM, Paul Eggert wrote: Florian Weimer wrote: Without kernel support, a non-zero argument returns EINVAL, not ENOSYS. This mirrors what the kernel does for invalid renameat2 flags. The Gnulib renameat2 function

Re: [PATCH] Add renameat2 function [BZ #17662]

2018-07-02 Thread Paul Eggert
Joseph Myers wrote: We've had complaints in glibc about fallbacks that introduce races (e.g. for pselect). Do you have reason to believe that this race is somehow different and introducing it will never cause problems for users? "Never" i

Re: [PATCH] Add renameat2 function [BZ #17662]

2018-07-02 Thread Joseph Myers
On Mon, 2 Jul 2018, Paul Eggert wrote: > The Gnulib renameat2 function > has > different semantics with non-zero flags. On GNU/Linux if > flags==RENAME_NOREPLACE and the Linux syscall fails due to > EINVAL/ENOSYS/ENOTSUP, Gnulib r

Re: [PATCH] Add renameat2 function [BZ #17662]

2018-07-02 Thread Paul Eggert
Florian Weimer wrote: Without kernel support, a non-zero argument returns EINVAL, not ENOSYS. This mirrors what the kernel does for invalid renameat2 flags. The Gnulib renameat2 function has different semantics with non-zero