test-poll failing on FreeBSD 10/11

2018-05-08 Thread Daniel P . Berrangé
Libvirt CI recently started running "make check" on our FreeBSD 10 & 11 hosts, and we see frequent failure of the test-poll unit test in gnulib IIUC, gnulib is not actually building a replacement poll() function on FreeBSD, it is merely running the gnulib test suite against the FreeBSD system impl

Re: af_alg benchmarks and performance

2018-05-08 Thread Bruno Haible
Hi Matteo, > I see the same for PPC64 and S390X, in the time being I'll borrow two > machines and provide tests on them. When you test these, please can you also report the 'priority' that /proc/crypto shows for these algorithms? I'm trying to find a reasonable 'priority' threshold for the afalg_

Re: af_alg benchmarks and performance

2018-05-08 Thread Matteo Croce
On Tue, May 8, 2018 at 3:25 AM, Assaf Gordon wrote: > A comment about the above: > Talking about "crypto API" lumps together encryption (e.g. AES) and hashing. > The link [3] talks about the "AES-NI" which is used for encryption > (and from personal anecdotal evidence indeed provide nice speedups

Re: af_alg benchmarks and performance

2018-05-08 Thread Matteo Croce
On Tue, May 8, 2018 at 1:10 AM, Bruno Haible wrote: > Hi all, > > Thanks for your benchmarking help and explanations. > > Let me try to summarize. > > * We need to consider each of the algorithms md5, sha1 sha256 separately, > because each algorithm has a different performance characteristi

Re: optimizing af_alg

2018-05-08 Thread Matteo Croce
On Tue, May 8, 2018 at 2:59 AM, Bruno Haible wrote: > Matteo Croce wrote: >> Obviously it works only if you always use the same algo and with a >> single thread > > Why only in a single thread? Can't you do > > socket(AF_ALG, SOCK_SEQPACKET, 0) = 3 > bind(3, {sa_family=AF_ALG, sa_data="h