Re: Warning in spawn-pipe.c (create_pipe)

2017-12-14 Thread Bruno Haible
Hi Tim, > > 1) It is not a goal to have absolutely no warnings with GCC or > >with clang. It is perfectly OK, IMO, if a compilation with "gcc -Wall" > >shows, say, 5 warnings in 10 files. The maintainer will get used to > >these warnings and see new warnings when they arise. > > That

Re: Warning in spawn-pipe.c (create_pipe)

2017-12-14 Thread Bruno Haible
Hi Tim, > > Or through an in-file pragma that specifically documents that we are > > intentionally ignoring the warning. > > I vote for this. Does this patch eliminate the warning? I couldn't reproduce the issue with clang 3.9.1 on Linux, therefore I have to ask you to test it. Bruno diff --g

Re: Warning in spawn-pipe.c (create_pipe)

2017-12-14 Thread Tim Rühsen
On 12/13/2017 11:24 PM, Bruno Haible wrote: > Hi Tim, > >> clang's warning: >> >> spawn-pipe.c:364:34: warning: variable 'child' may be uninitialized when >> used here [-Wconditional-uninitialized] >> register_slave_subprocess (child); >> ^ > > I agree

Re: Warning in spawn-pipe.c (create_pipe)

2017-12-14 Thread Tim Rühsen
On 12/13/2017 11:29 PM, Eric Blake wrote: > On 12/13/2017 04:24 PM, Bruno Haible wrote: > >> Is '-Wconditional-uninitialized' implied in -Wall? If yes, I vote for >> adding '-Wno-conditional-uninitialized' at least for this specific file >> (through a Makefile.am variable). > > Or through an in-f

Re: latest gcc vs lib/timespec.h:85

2017-12-14 Thread Tim Rühsen
On 12/13/2017 10:55 PM, Paul Eggert wrote: > On 12/13/2017 01:32 AM, Tim Rühsen wrote: >> Now clang throws out an annoying warning about the return value of  > >> timespec_cmp(): > > In file included from wget.c:51: > > ../lib/timespec.h:94:20: warning: implicit conversion loses integer > > precis