Hi Bruno,
I refreshed the patches based on the latest master branch.
Basically the problem we discussed may still exist. But anyway we have a
clear patch without the sm3 basis.
Changelog:
- fix the following 10 failures:
[gc-gnulib.c] 8 failures
lib/gc-gnulib.c: In function 'gc_init':
lib/gc-gn
Hi Bruno,
I sent a new submission based on the latest master branch for a clear
review without sm3 basis.
Plz refer to "[PATCH] sm3: support to compile with libgcrypt".
Let's continue the discussion over it.
Thanks,
Jia
于 2017/10/29 上午9:54, Jia Zhang 写道:
>
>
> 于 2017/10/29 上午4:25, Bruno Haib
于 2017/10/29 上午4:25, Bruno Haible 写道:
> Hi Jia,
>
>> Here is the V3 changelog:
>>
>> - Correct @LIB_CRYPTO@ build issue in m4/sm3.m4.
>
> Thanks for the update. The module 'crypto/sm3' passes the test, so
> I pushed that part of the patch in your name.
>
> The module 'crypto/gc-sm3' does not
On Haiku, I'm seeing this configure output:
...
checking for posix_spawn... yes
checking whether posix_spawn works... cmp: EOF on conftest.ok
no
checking for ptrdiff_t... yes
...
This patch should avoid the spurious message. 'cmp' is required by POSIX to
emit a diagnostics to stderr, even when no
On Haiku, the functions inet_ntop, inet_pton require linking with "-lnetwork".
But INET_NTOP_LIB and INET_PTON_LIB come out as empty. This leads to a
link error:
gcc-x86 -g -O2 -L/boot/home/config/lib -o test-inet_ntop test-inet_ntop.o
libtests.a ../gllib/libgnu.a libtests.a
test-inet_ntop.o
On Haiku (a recent one), the gnulib module 'ioctl' produces a compilation
error:
In file included from /boot/system/develop/headers/posix/sys/types.h:127:0,
from ./sys/types.h:28,
from ../../gllib/poll.c:29:
./sys/ioctl.h:484:1: error: conflicting types for 'ioctl
Hi Jia,
> Here is the V3 changelog:
>
> - Correct @LIB_CRYPTO@ build issue in m4/sm3.m4.
Thanks for the update. The module 'crypto/sm3' passes the test, so I pushed
that part of the patch in your name.
The module 'crypto/gc-sm3' does not pass the test:
$ ./gnulib-tool --create-testdir --dir=te
Hi Bruno,
Here is the V3 changelog:
- Correct @LIB_CRYPTO@ build issue in m4/sm3.m4.
- Merge patch 4 and 5 together.
- Make the commit header more readable for patch 2,3,4, and add the
short file change descriptions.
Thanks,
Jia
From 12be745f4a86ef73340ef88b7156fae262f70b84 Mon Sep 17 00:00:00
于 2017/10/28 下午9:09, Bruno Haible 写道:
> Jia Zhang wrote:
>>> gcc: error: @LIB_CRYPTO@: No such file or directory
>>
>> Thanks for your comments. I fixed it and the test passes. I just
>> feel strange that test-sm3 was built out without error if I
>> compiled gnulib with coreutils together.
>
>
Jia Zhang wrote:
> > gcc: error: @LIB_CRYPTO@: No such file or directory
>
> Thanks for your comments. I fixed it and the test passes. I just feel
> strange that test-sm3 was built out without error if I compiled gnulib
> with coreutils together.
It passed with coreutils because coreutils request
于 2017/10/28 下午8:44, Bruno Haible 写道:
> [Dropping coreutils, since I'm replying only the gnulib part.]
>
> Hi Jia,
>
>> Plz refer to the following PRs for code review.
>>
>> - For the new gnulib module crypto/sm3
>> https://github.com/coreutils/gnulib/pull/3/commits
>
> Usually, on this mail
[Dropping coreutils, since I'm replying only the gnulib part.]
Hi Jia,
> Plz refer to the following PRs for code review.
>
> - For the new gnulib module crypto/sm3
> https://github.com/coreutils/gnulib/pull/3/commits
Usually, on this mailing list, we share patches through 'git format-patch -1
Hi Pádraig & Bruno,
This is the V2 review request for SM3 hash algorithm.
As promised, I have made SM3 hash algorithm available in the latest
libgcrypt. See
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=4423bf3cc4432b9bfe801ff74cb05e6f0dd3eccd
The V2 patch adds the support
13 matches
Mail list logo
