Re: [PATCH 1/6] parse-datetime, posixtm: avoid uninit access

2017-09-25 Thread Paul Eggert
Thien-Thi Nguyen wrote: Maybe add a preemptive comment, or factor the assignments into a macro (w/ comment)? It's not worth a macro. Feel free to add a comment.

Re: [PATCH 1/6] parse-datetime, posixtm: avoid uninit access

2017-09-25 Thread Thien-Thi Nguyen
() Paul Eggert () Mon, 25 Sep 2017 18:29:08 -0700 Do not access uninitialized storage, even though the resulting value is never used. [...] - tm0 = tm; + tm0.tm_sec = tm.tm_sec; + tm0.tm_min = tm.tm_min; + tm0.tm_hour = tm.tm_hour; + tm0.tm_mday

Re: [coreutils/gnulib] m4/host-os.m4: Fixed bug inserting string 'GNU/' to Linux, kFreeBSD, etc (#2)

2017-09-25 Thread Bernhard Voelker
On 09/24/2017 04:54 AM, Farhan Khan wrote: > Operating systems consist of far more than their core utilities. If its > argued that we should acknowledge the userspace, we should be consistent > and acknowledge all of the userspace. Change the string to > 'BSD/Oracle/Microsoft/Redhat/ISC/Apache/MIT/

Re: OpenGrok for gnulib (and other software)

2017-09-25 Thread Mathieu Lirzin
Hello, Assaf Gordon writes: > I'm running a small OpenGrok* server with various software > including gnulib, glibc, coreutils and other libraries/programs: > > https://opengrok.housegordon.com/ > > The gnulib source code is here: > https://opengrok.housegordon.com/source/xref/gnulib/ > > Rep

OpenGrok for gnulib (and other software)

2017-09-25 Thread Assaf Gordon
Hello, I'm running a small OpenGrok* server with various software including gnulib, glibc, coreutils and other libraries/programs: https://opengrok.housegordon.com/ The gnulib source code is here: https://opengrok.housegordon.com/source/xref/gnulib/ Repositories are updated from git twice a

[PATCH 4/6] maint: fix overflow checking in nap.h

2017-09-25 Thread Paul Eggert
* modules/chown-tests: * modules/fchownat-tests, modules/fdutimensat-tests: * modules/futimens-tests, modules/lchown-tests: * modules/stat-time-tests, modules/utime-tests: * modules/utimens-tests, modules/utimensat-tests: Depend on intprops. * tests/nap.h: Include intprops.h. (diff_timespec): Handl

[PATCH 3/6] sys_types: update URL

2017-09-25 Thread Paul Eggert
* m4/sys_types_h.m4: Use https: URL. --- ChangeLog | 3 +++ m4/sys_types_h.m4 | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 912a48e80..0995e5d53 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2017-09-25 Paul Eggert +

[PATCH 5/6] duplocale-tests: fix unlikely crash

2017-09-25 Thread Paul Eggert
* tests/test-duplocale.c (get_locale_dependent_values): Don’t crash with absurdly long month names. --- ChangeLog | 4 tests/test-duplocale.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 9935941df..c1bf07eff 100644 --- a/Chang

[PATCH 1/6] parse-datetime, posixtm: avoid uninit access

2017-09-25 Thread Paul Eggert
* lib/parse-datetime.y (parse_datetime2): * lib/posixtm.c (posixtime): Do not access uninitialized storage, even though the resulting value is never used. --- ChangeLog| 8 lib/parse-datetime.y | 16 ++-- lib/posixtm.c| 7 ++- 3 files changed, 28 inse

[PATCH 2/6] parse-datetime: fix dependency

2017-09-25 Thread Paul Eggert
* modules/parse-datetime (Depends-on): Depend on nstrftime, not strftime. --- ChangeLog | 4 modules/parse-datetime | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 9c6d73f72..912a48e80 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,

[PATCH 6/6] uniname/uniname-tests: integer overflow fix

2017-09-25 Thread Paul Eggert
* tests/uniname/test-uninames.c (fill_names, fill_aliases): Check for integer overflow. --- ChangeLog | 4 tests/uniname/test-uninames.c | 12 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index c1bf07eff..4585cf12b 100

vma-iter: Improvements for BSD platforms

2017-09-25 Thread Bruno Haible
I'm improving the support of BSD platforms in the 'vma-iter' module (used by GNU clisp). 2017-09-25 Bruno Haible vma-iter: Improvements for BSD platforms. - Add support for GNU/kFreeBSD. - Make it work on FreeBSD and NetBSD even when /proc is not mounted. - Spee

Re: pygnulib: Portability fixes

2017-09-25 Thread Bruno Haible
Dmitry Selyutin wrote: > hopefully most Unices > either have Python 3 by default or at least have it in repositories, ports, > etc. Yes, they do. You can assume Python >= 3.2 nowadays when you invoke 'python3'. [1] 'python2' is also widely deployed [2]; I assume that's because of backward compa

Re: pygnulib: Portability fixes

2017-09-25 Thread Mathieu Lirzin
Dmitry Selyutin writes: > Wow, that's a surprise. Sure, we must support all Python 3 versions. Thank > you, I've applied it. Please check if everything is OK, I'm not a Git guru: > since parser and config were a bit ahead, I did the same as you did, > committed, then exported a patch via $(git

Re: strfmon in the C locale

2017-09-25 Thread Eric Blake
On 09/23/2017 11:01 AM, Bruno Haible wrote: > > So, this implementation of strfmon is very standards-compliant. > But without a distinction between positive and negative values, > and without a visible decimal separator, this behaviour is useless, > or even dangerous (if a programmer was not aware

Re: pygnulib: Portability fixes

2017-09-25 Thread Dmitry Selyutin
Hi Mathieu, thank you for submitting it. > Here is a patch that removes the use of 'enum.Flags' that didn't exist > until python 3.6. It seems that 'enum' classes are not well supported > with older version too. So it seems more reasonable to not use them at > all. Wow, that's a surprise. Sure,

pygnulib: Portability fixes

2017-09-25 Thread Mathieu Lirzin
Hello, I have checked the "python" branch. Here is a patch that removes the use of 'enum.Flags' that didn't exist until python 3.6. It seems that 'enum' classes are not well supported with older version too. So it seems more reasonable to not use them at all. >From 84b81d499f2b926c2771ed700b01

pygnulib development process documentation (was: [PATCH] gnulib-tool.py: Clean the imports)

2017-09-25 Thread Mathieu Lirzin
Dmitry Selyutin writes: >> Sorry, I was unaware of that branch. What about adding some information >> about the gnulib-tool.py development process in a "README-hacking" file? > Frankly I don't know what to write here yet. :-) I mean that there must be > something already to play with, but the w

Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols

2017-09-25 Thread Adhemerval Zanella
On 22/09/2017 18:43, Paul Eggert wrote: > On 09/22/2017 06:02 AM, Adhemerval Zanella wrote: >> +   ((flags & (GLOB_ERR | GLOB_NOESCAPE | GLOB_ALTDIRFUNC)) >> +   | GLOB_NOSORT | GLOB_ONLYDIR), > > The indenting is not quite right here: the "|" should be under the 2nd > "(" i