Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

2017-09-07 Thread Paul Eggert
On 09/12/15 10:35, Pádraig Brady wrote: p.s. I see that find does a stat per file on XFS, while d_type can be used to distinguish dirs there. On XFS DT_DIR is set for dirs and DT_UNKNOWN otherwise. I wonder is there some optimization we could do for that case. There might be, but what are you b

[PATCH] argp: state that argp_error does not return

2017-09-07 Thread Pavel Raiskup
Issue observed because the new GCC 7 -Wimplicit-fallthrough is whining when useless 'break;' is not specified after argp_error call. * lib/argp.h (__argp_error): Declare as _Noreturn. * lib/argp-help.c (__argp_error): Explicitly throw backtrace if the function was about to return. --- lib/argp-he

Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

2017-09-07 Thread Pádraig Brady
On 05/09/17 01:36, Kamil Dudka wrote: > On Thursday, December 10, 2015 2:26:38 AM CEST Pádraig Brady wrote: >> On 09/12/15 10:35, Pádraig Brady wrote: >>> On 09/12/15 06:34, Kamil Dudka wrote: The flag is needed to implement the -noleaf option of find. * lib/fts.c (link_count_optimize_ok)

Re: gnulib-tool.py

2017-09-07 Thread Bruno Haible
Hi Dmitry, > As for merging into master, I tried to do it, but didn't succeed: git > complains a lot on whitespaces and similar stuff. I suspect it may be > caused by custom git hook. Yes, the custom git hook can emit errors and warnings. The messages about whitespace are only warnings, as far as

Re: gnulib-tool.py

2017-09-07 Thread Dmitry Selyutin
Hi Tim, thank you for your kind words! As for merging into master, I tried to do it, but didn't succeed: git complains a lot on whitespaces and similar stuff. I suspect it may be caused by custom git hook. Bruno, Paul, could you help me with merging? I suppose that right now almost everything shal