Re: libc-config.h + cdefs.h

2017-09-05 Thread Paul Eggert
Gisle Vanem wrote: The new files libc-config.h and cdefs.h, break MSVC in several ways: 1) libc-config.h: # undef __inline '__inline' is a built-in reserved word used through-out the MS SDK. '#undef X' is merely a preprocessor directive; it doesn't affect whether X is treated as a rese

Re: SIGSEGV in partial_quotearg_n()

2017-09-05 Thread Paul Eggert
James Youngman wrote: gnulib foliks, do you have test data which results in FTS_DC being returned by fts_read? If not, have you tested in any other way that ent->fts_cycle->fts_pathlen is in-bounds for this case? The Gnulib tests for fts are minimal and don't use FTS_DC as far as I know. I t

Re: [PATCH 8/9] posix: Use enum for __glob_pattern_type result

2017-09-05 Thread Paul Eggert
Adhemerval Zanella wrote: +enum glob_pattern_type_t +{ + __GLOB_NONE = 0x0, + __GLOB_SPECIAL = 0x1, + __GLOB_BACKSLASH = 0x2, + __GLOB_BRACKET = 0x4 +}; The identifier glob_pattern_type_t is not used elsewhere, so let's omit it. This makes it clearer that we're merely defining han

Re: gnulib-tool.py

2017-09-05 Thread Dmitry Selyutin
Hi Tim, that's exactly what I've done today. I've just pushed some changes into repository; could you please try the latest version? I didn't have time to integrate --no-changelog support yet (it seems it was either unimplemented before or appeared after project was completed). Thank you for tryin

Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

2017-09-05 Thread Kamil Dudka
On Thursday, December 10, 2015 2:26:38 AM CEST Pádraig Brady wrote: > On 09/12/15 10:35, Pádraig Brady wrote: > > On 09/12/15 06:34, Kamil Dudka wrote: > >> The flag is needed to implement the -noleaf option of find. > >> * lib/fts.c (link_count_optimize_ok): Implement the FTS_NOLEAF flag. > >> * l

Re: max_align_t fails with clang 6.1 on OS X 10.10

2017-09-05 Thread Werner LEMBERG
>> +} _gl_max_align_t; >> +#define max_align_t _gl_max_align_t >> #endif >> # endif /* _@GUARD_PREFIX@_STDDEF_H */ >> This one is not brittle and is not a big change. If Paul agrees, I >> would commit this, and you (Werner) would not need to reorganize >> your package's configuration. > >