Re: [PATCH] m4: Remove ternary operator from extern-inline

2017-06-05 Thread Bruno Haible
Hi, Martin Kletzander wrote: > When compiling libvirt with updated GCC (v7.1.0), the following warning > pops out (which then ends up treated like an error): > > ../config.h:2994:48: error: this use of "defined" may not be portable > [-Werror=expansion-to-defined] > || (defined _FOR

[PATCH] m4: Remove ternary operator from extern-inline

2017-06-05 Thread Martin Kletzander
When compiling libvirt with updated GCC (v7.1.0), the following warning pops out (which then ends up treated like an error): ../config.h:2994:48: error: this use of "defined" may not be portable [-Werror=expansion-to-defined] || (defined _FORTIFY_SOURCE && 0 < _FORTIFY_SOURCE \ If I

Re: preferring ptrdiff_t to size_t for object counts

2017-06-05 Thread Bruno Haible
Hi Paul, I'd like to understand how much better this "ptrdiff_t world" is. > This has the advantage that signed integer overflow can be detected > automatically on some platforms You mean "-fsanitize=undefined", right? Does this also catch the following situations? a) Pointer subtraction. I

Re: preferring ptrdiff_t to size_t for object counts

2017-06-05 Thread Bruno Haible
Hi Paul, > GNU Emacs has long been using signed types (typically ptrdiff_t) to count > objects. This has the advantage that signed integer overflow can be detected > automatically on some platforms (unfortunately, size_t arithmetic silently > wraps > around). I have one objection, but a big o

Re: getopt broken when building with glibc 2.25.90

2017-06-05 Thread Daniel P. Berrange
On Fri, Jun 02, 2017 at 11:18:04AM -0700, Paul Eggert wrote: > On 06/02/2017 09:25 AM, Daniel P. Berrange wrote: > > Fedora rawhide is now shipping with glibc 2.25.90 and when trying to > > build libvirt with gnulib's getopt module, it crashes & burns > > > >CC getopt.lo > > In file incl