Hi Eric,
Thanks for noticing and fixing this faster than I could.
> A better approach is to replace the autoconf macro with a version
> of our own that doesn't probe anything, so that the AC_DEFINE is
> reached exactly once.
Yes, agreed.
> +AC_DEFUN([AC_FUNC_STRERROR_R], [
> + AC_DEFINE([HAVE_
On 11/01/2016 04:39 PM, Bruno Haible wrote:
All the new change does was to remove this forward-caution,
right?
Yes. It's also sideways caution, in the sense that neither kernel might
be "newer" than the other.
Requiring autoconf's AC_FUNC_STRERROR_R and then calling AC_DEFINE
ourselves leads to two insertions of #define STRERROR_R_CHAR_P
in confdefs.h, but with different values (at least on glibc). This
in turn sparks a gcc warning about redeclaring the macro, and kills
any subsequent tests that use -We
On 10/16/2016 11:17 AM, Bruno Haible wrote:
> There are two problems:
>
> 1) argp-help.c uses STRERROR_R_CHAR_P, which is defined by the macro
>AC_FUNC_STRERROR_R, but argp.m4 does not require it (only error.m4 does).
>
> 2) When the strerror_r-posix module is in place, the results of
>A
