Re: [PATCH] accept4 tests: fix specified flags

2015-10-08 Thread Pádraig Brady
On 08/10/15 13:47, Pino Toscano wrote: > Pass only SOCK_* flags to accept4, as they are the only documented > ones, and passing others may trigger EINVAL. > * tests/test-accept4.c: (main): Pass SOCK_CLOEXEC instead of > O_CLOEXEC | O_BINARY to accept4. > --- > ChangeLog| 7 +++ > t

[PATCH] accept4 tests: fix specified flags

2015-10-08 Thread Pino Toscano
Pass only SOCK_* flags to accept4, as they are the only documented ones, and passing others may trigger EINVAL. * tests/test-accept4.c: (main): Pass SOCK_CLOEXEC instead of O_CLOEXEC | O_BINARY to accept4. --- ChangeLog| 7 +++ tests/test-accept4.c | 4 ++-- 2 files changed, 9 inse

[PATCH] Fix test-accept4 on FreeBSD

2015-10-08 Thread Pino Toscano
Hi, currently, test-accept4 asserts on FreeBSD 10.1-RELEASE, as the errno returned on accept4 failures is reported as EINVAL (and not EBADF as expected). The issue is due to wrong flags passed to accept4 in the test itself: both the Linux [1] and the FreeBSD [2] man pages document only SOCK_* fla